René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[MNT]: Refactor autoscaling in 3D","articleBody":"### Summary\n\nFrom https://github.com/matplotlib/matplotlib/pull/28403#pullrequestreview-2126623221:\r\n\r\n#### Current logic\r\n\r\n\u003e Extract all data coordinates *xyz* from the artist and feed them into `auto_scale_xyz()`.\r\n\r\nThis updates the `xy_dataLim`, `zz_dataLim` BBoxes via `.Bbox.update_from_data_xy/x/y()`, which in turn creates a `Path` and calls `.Bbox.update_from_path()`.\r\n\r\nThis is quite a lot data pushing (and maybe copying) just to update dataLim bboxes.\r\n\r\n#### Proposed logic\r\n\r\nSeparation of concerns: The Artists should have a function to get their data lims. These limits should be used to update the Bbox. Basically some `Bbox.update_from_box`, a kind of an in-place `Bbox.union`, which we don't seem to have.\r\n\r\nEssentially, we have should implement a 3D variant of Collection.get_datalim` for 3D.\n\n### Proposed fix\n\nRough outline: We may start minimal with rolling a small\r\n```\r\nclass _Bbox3d:\r\n    def __init__(self, points):\r\n        ((self.xmin, self.xmax),\r\n         (self.ymin, self.ymax),\r\n         (self.zmin, self.zmax)) = points\r\n\r\n    def to_bbox_xy(self):\r\n        return Bbox(((self.xmin, self.xmax), (self.ymin, self.ymax)))\r\n\r\n    def to_bbox_zz(self):\r\n        # first component contains z, second is unused\r\n        return Bbox(((self.zmin, self.zmax), (0, 0)))\r\n```\r\nand implement `_get_datalim3d() -\u003e _Bbox3d` on the 3d collections.\r\n\r\nThen\r\n```\r\ndef add_collection(col, autolim=True):\r\n    ...\r\n    if autolim:\r\n        self.auto_scale_lim(col.get_datalim3d())\r\n```\r\nand\r\n```\r\ndef auto_scale_lim(bbox3d):\r\n     ...\r\n     self.dataLim_xy.update_from_box(bbox3d.to_bbox_xy())\r\n     self.dataLim_zz.update_from_box(bbox3d.to_bbox_zz())\r\n```\r\n","author":{"url":"https://github.com/timhoffm","@type":"Person","name":"timhoffm"},"datePublished":"2024-06-24T13:54:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/28444/matplotlib/issues/28444"}