René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[ENH]: Improve typing of Figure.subplots","articleBody":"### Bug summary\r\n\r\nThe type stubs for Figure.subplots has two `@overloads`. One is generic, and the other is specialised for squeeze=False (in which case the return value is always nd.ndarray). But there are also some other cases where the type could be more accurately inferred.\r\n\r\n### Code for reproduction\r\n\r\n```Python\r\nfrom matplotlib.figure import Figure\r\n\r\nfig = Figure()\r\nreveal_type(fig.subplots())\r\nreveal_type(fig.subplots(2))\r\nreveal_type(fig.subplots(1, 2))\r\n```\r\n\r\n\r\n### Actual outcome\r\n\r\nWhen run in mypy:\r\n```\r\ninfer.py:4: note: Revealed type is \"Union[numpy.ndarray[Any, Any], matplotlib.axes.SubplotBase, matplotlib.axes._axes.Axes]\"\r\ninfer.py:5: note: Revealed type is \"Union[numpy.ndarray[Any, Any], matplotlib.axes.SubplotBase, matplotlib.axes._axes.Axes]\"\r\ninfer.py:6: note: Revealed type is \"Union[numpy.ndarray[Any, Any], matplotlib.axes.SubplotBase, matplotlib.axes._axes.Axes]\"\r\n```\r\n\r\n### Expected outcome\r\n\r\n```\r\ninfer.py:4: note: Revealed type is \"Union[matplotlib.axes.SubplotBase, matplotlib.axes._axes.Axes]\"\r\ninfer.py:5: note: Revealed type is \"numpy.ndarray[Any, Any]]\"\r\ninfer.py:6: note: Revealed type is \"numpy.ndarray[Any, Any]]\"\r\n```\r\n\r\n### Additional information\r\n\r\nThe last two examples may be impossible to implement, because you'd need a way to type \"a literal integer != 1\". But the first case is the one I initially ran into. I was able to work around it by replacing it with `fig.add_subplot()`, but that isn't semantically identical.\r\n\r\n### Operating system\r\n\r\nUbuntu\r\n\r\n### Matplotlib Version\r\n\r\n3.8.0\r\n\r\n### Matplotlib Backend\r\n\r\nTkAgg\r\n\r\n### Python version\r\n\r\n3.10.12\r\n\r\n### Jupyter version\r\n\r\n_No response_\r\n\r\n### Installation\r\n\r\npip","author":{"url":"https://github.com/bmerry","@type":"Person","name":"bmerry"},"datePublished":"2024-04-08T09:32:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/28045/matplotlib/issues/28045"}