René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: `NavigationToolbar2QT` should use `@Slot` annotation","articleBody":"### Bug summary\r\n\r\nhttps://doc.qt.io/qtforpython-6/tutorials/basictutorial/signals_and_slots.html#the-slot-class says \r\n\r\n\u003e We recommend marking all methods used by signal connections with a `@QtCore.Slot()` decorator. Not doing causes run-time overhead due to the method being added to the `QMetaObject` when creating the connection. This is particularly important for `QObject` classes registered with QML, where missing decorators can introduce bugs.\r\n\r\n`NavigationToolbar2QT` does not do that.\r\n\r\n### Code for reproduction\r\n\r\n```python\r\nimport os\r\n\r\nfrom matplotlib.backends.backend_qt import NavigationToolbar2QT\r\nfrom matplotlib.backends.backend_qtagg import FigureCanvasQTAgg\r\nfrom PySide6.QtWidgets import QApplication\r\n\r\nos.environ[\"QT_LOGGING_RULES\"] = \"qt.pyside.libpyside.warning=true\"\r\n\r\napp = QApplication()\r\ncanvas = FigureCanvasQTAgg()\r\nNavigationToolbar2QT(canvas)\r\n```\r\n\r\n\r\n### Actual outcome\r\n```\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"home()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"back()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"forward()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"pan()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"zoom()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"configure_subplots()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"edit_parameters()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\nqt.pyside.libpyside: Warning: Registering dynamic slot \"save_figure()\" on NavigationToolbar2QT. Consider annotating with @Slot()\r\n```\r\n### Expected outcome\r\n\r\nSilence\r\n\r\n### Operating system\r\n\r\nWindows 10 (also Ubuntu 23.10)\r\n\r\n### Matplotlib Version\r\n\r\n3.8.0\r\n\r\n### Matplotlib Backend\r\n\r\nQtAgg\r\n\r\n### Python version\r\n\r\nPython 3.12.0\r\n\r\n### Jupyter version\r\n\r\nirrelevant\r\n\r\n### Installation\r\n\r\npip","author":{"url":"https://github.com/bersbersbers","@type":"Person","name":"bersbersbers"},"datePublished":"2023-10-27T05:43:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/27214/matplotlib/issues/27214"}