René's URL Explorer Experiment


Title: [Bug]: `check_figures_equal` decorator doesn't respect new figure properties set in test · Issue #24875 · matplotlib/matplotlib · GitHub

Open Graph Title: [Bug]: `check_figures_equal` decorator doesn't respect new figure properties set in test · Issue #24875 · matplotlib/matplotlib

X Title: [Bug]: `check_figures_equal` decorator doesn't respect new figure properties set in test · Issue #24875 · matplotlib/matplotlib

Description: Bug summary We use the check_figures_equal in testing to compare figures. This decorator uses two figure instances fig_test and fig_ref for comparison. If we set any figure properties (like facecolor) in the test, they don't seem to be p...

Open Graph Description: Bug summary We use the check_figures_equal in testing to compare figures. This decorator uses two figure instances fig_test and fig_ref for comparison. If we set any figure properties (like facecol...

X Description: Bug summary We use the check_figures_equal in testing to compare figures. This decorator uses two figure instances fig_test and fig_ref for comparison. If we set any figure properties (like facecol...

Opengraph URL: https://github.com/matplotlib/matplotlib/issues/24875

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: `check_figures_equal` decorator doesn't respect new figure properties set in test","articleBody":"### Bug summary\r\n\r\nWe use the `check_figures_equal` in testing to compare figures. This decorator uses two figure instances `fig_test` and `fig_ref` for comparison. If we set any figure properties (like `facecolor`) in the test, they don't seem to be propagated when saving the actual figure.\r\n\r\nRan into this while writing a test for #24816 (cc @anntzer, for reference)\r\n\r\n### Code for reproduction\r\n\r\n```python\r\n@check_figures_equal(extensions=[\"png\"])\r\ndef test_test(fig_test, fig_ref):\r\n    ax_test = fig_test.add_subplot()\r\n    ax_test.set(xticks=[], yticks=[])\r\n    fig_test.set_facecolor(\"teal\")\r\n\r\n    ax_ref = fig_ref.add_subplot()\r\n    ax_ref.set(xticks=[], yticks=[])\r\n    fig_ref.set_facecolor(\"none\")\r\n```\r\n\r\n\r\n### Actual outcome\r\n\r\nThis test passes, which suggests that the two figures created are equal but they actually aren't since the facecolor for both figures are set to be different.\r\n\r\n### Expected outcome\r\n\r\nThis test shouldn't pass and the figures should have facecolors \"teal\" and \"none\" respectively.\r\n\r\n### Additional information\r\n\r\n_No response_\r\n\r\n### Operating system\r\n\r\nArch\r\n\r\n### Matplotlib Version\r\n\r\n3.6.0.dev1889+gc59a7fa8db.d20230103\r\n\r\n### Matplotlib Backend\r\n\r\n_No response_\r\n\r\n### Python version\r\n\r\n3.10\r\n\r\n### Jupyter version\r\n\r\n_No response_\r\n\r\n### Installation\r\n\r\nNone","author":{"url":"https://github.com/chahak13","@type":"Person","name":"chahak13"},"datePublished":"2023-01-03T19:12:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/24875/matplotlib/issues/24875"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:450622cf-88a7-89d2-e385-8aadda9758cd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEB4E:2804AF:5E926E:813EFC:6A5253C5
html-safe-nonceffe9f4fc53d6e3d2e6c35f17d396bfd1cc9816fa2325190b2e656d9077698b86
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjRFOjI4MDRBRjo1RTkyNkU6ODEzRUZDOjZBNTI1M0M1IiwidmlzaXRvcl9pZCI6IjIyNDk5MDU1MDcyNTgyMjU2MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4311e2bb57554cd7cb81bcb7a2bf05c39eaf026a1fe7a2aa6064f5363bd99ee0
hovercard-subject-tagissue:1517809324
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/24875/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a06dfca9d5dff96af4172a9a1251e5ddc9e219012e887b158ebc6239834fb9b6/matplotlib/matplotlib/issues/24875
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a06dfca9d5dff96af4172a9a1251e5ddc9e219012e887b158ebc6239834fb9b6/matplotlib/matplotlib/issues/24875
og:image:altBug summary We use the check_figures_equal in testing to compare figures. This decorator uses two figure instances fig_test and fig_ref for comparison. If we set any figure properties (like facecol...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechahak13
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/issues/24875#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F24875
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F24875
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/issues/24875
Reloadhttps://github.com/matplotlib/matplotlib/issues/24875
Reloadhttps://github.com/matplotlib/matplotlib/issues/24875
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/24875
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/24875
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
[Bug]: check_figures_equal decorator doesn't respect new figure properties set in testhttps://github.com/matplotlib/matplotlib/issues/24875#top
https://github.com/chahak13
chahak13https://github.com/chahak13
on Jan 3, 2023https://github.com/matplotlib/matplotlib/issues/24875#issue-1517809324
#24816https://github.com/matplotlib/matplotlib/pull/24816
@anntzerhttps://github.com/anntzer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.