Title: [TST]: Add classic style to all old image tests. · Issue #24716 · matplotlib/matplotlib · GitHub
Open Graph Title: [TST]: Add classic style to all old image tests. · Issue #24716 · matplotlib/matplotlib
X Title: [TST]: Add classic style to all old image tests. · Issue #24716 · matplotlib/matplotlib
Description: Summary All the old image tests use the classic style, whereas new test we ask contributors to add style='mpl20' to the image_comparison decorator. @image_comparison('new_style.png', remove_text=True, style='mpl20') As a first step to ma...
Open Graph Description: Summary All the old image tests use the classic style, whereas new test we ask contributors to add style='mpl20' to the image_comparison decorator. @image_comparison('new_style.png', remove_text=Tr...
X Description: Summary All the old image tests use the classic style, whereas new test we ask contributors to add style='mpl20' to the image_comparison decorator. @image_comparison('new_style.png'...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/24716
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[TST]: Add classic style to all old image tests.","articleBody":"### Summary\r\n\r\nAll the old image tests use the classic style, whereas new test we ask contributors to add `style='mpl20'` to the `image_comparison` decorator. \r\n\r\n```\r\n@image_comparison('new_style.png', remove_text=True, style='mpl20')\r\n```\r\n\r\nAs a first step to making the new style the testing default, we should go through and change all the old image comparison tests to explicitly use the classic style:\r\n\r\n```\r\n@image_comparison('old_style.png', style='classic')\r\n```\r\n\r\nThis will hit a lot of the tests, but could be done piecemeal or all in one swoop if someone is clever with writing a parser to add the style kwarg. \r\n\r\nEventually the way to test that everything has been caught will be to change the default to 'mpl20' and make sure none of the image tests fail.\r\n\r\n","author":{"url":"https://github.com/jklymak","@type":"Person","name":"jklymak"},"datePublished":"2022-12-13T17:15:19.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/24716/matplotlib/issues/24716"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:70842351-1b0c-f854-8235-9f4ac3361f68 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A00A:12A1BB:3BE42D:509555:6A5290D5 |
| html-safe-nonce | c92fab410b77db5cff2dccb26620415cd049e8a1fe905f06396ec1bfc7b775cf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDBBOjEyQTFCQjozQkU0MkQ6NTA5NTU1OjZBNTI5MEQ1IiwidmlzaXRvcl9pZCI6IjgzMDM4NjY5MDExNjkzNDQ3MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 14d0721085a715e62c1c4fa60b9d4f69ce00d34d32b46eb9947b2dd10789539f |
| hovercard-subject-tag | issue:1494753266 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/24716/issue_layout |
| twitter:image | https://opengraph.githubassets.com/77c3fce9ed70a4e693740c1d8aa90b20af0147ee88e6f8f6ef62b60da60a2541/matplotlib/matplotlib/issues/24716 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/77c3fce9ed70a4e693740c1d8aa90b20af0147ee88e6f8f6ef62b60da60a2541/matplotlib/matplotlib/issues/24716 |
| og:image:alt | Summary All the old image tests use the classic style, whereas new test we ask contributors to add style='mpl20' to the image_comparison decorator. @image_comparison('new_style.png', remove_text=Tr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jklymak |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width