Title: [MNT]: Remove origin and extents parameters from tricontour[f]() · Issue #24006 · matplotlib/matplotlib · GitHub
Open Graph Title: [MNT]: Remove origin and extents parameters from tricontour[f]() · Issue #24006 · matplotlib/matplotlib
X Title: [MNT]: Remove origin and extents parameters from tricontour[f]() · Issue #24006 · matplotlib/matplotlib
Description: Summary from: #23995 (comment) tricontour[f] documents and accepts parameters origin and extent, but interestingly, they are not used 😲. They are only used in contour[f], where one can leave out X and Y, in which case origin and extent d...
Open Graph Description: Summary from: #23995 (comment) tricontour[f] documents and accepts parameters origin and extent, but interestingly, they are not used 😲. They are only used in contour[f], where one can leave out X ...
X Description: Summary from: #23995 (comment) tricontour[f] documents and accepts parameters origin and extent, but interestingly, they are not used 😲. They are only used in contour[f], where one can leave out X ...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/24006
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[MNT]: Remove origin and extents parameters from tricontour[f]()","articleBody":"### Summary\r\n\r\nfrom: https://github.com/matplotlib/matplotlib/pull/23995#discussion_r979445788\r\n\r\n`tricontour[f]` documents and accepts parameters `origin` and `extent`, but interestingly, they are not used :astonished:. They are only used in `contour[f]`, where one can leave out X and Y, in which case `origin` and `extent` define where to place the data in the Axes. When one thinks about it, this concept does obviously does not apply to triangular grids. One always has to specify x and y, either directly or via a `Triangulation.\r\n\r\nIt's a bit hard to see that `origin` and `extent` are unused, because they are passed through multiple levels of kwargs and are added as attributes to `ContourSet`, which is the common base class of `TriContourSet` and `QuadContourSet`. But `TriContourSet` does not use them. One can also check this by removing the validation checks on these values and then passing in nonsense values: The plot does not care. It seems this docstring part was copied from `contour[f]` without thinking about it.\r\n\r\n\r\n\r\n### Proposed fix\r\n\r\n*Goal*: Remove `origin` and `extents` parameters from `tricontour[f]()`\r\n\r\nThings to do:\r\n- Find out the how to properly handle `origin` and `extent` in the `ContourSet` class hierarchy. Likely move to `QuadContourSet`. But it might be that we have leave it in `ContourSet` but warn/error when used in `TriContourSet`.\r\n- Based on that determine the proper place to deprecate them.\r\n- Change the `tricontour[f]` docstring accordingly (deprecation statement and mention that they don't have any effect).\r\n- When the deprecation expires, clean up.\r\n\r\nNote: Nobody has complained that these parameters don't have any effect, so I assume nobody uses them intentionally. But since they are documented, I think we still have to jump the deprecation hoops.","author":{"url":"https://github.com/timhoffm","@type":"Person","name":"timhoffm"},"datePublished":"2022-09-25T19:20:46.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/24006/matplotlib/issues/24006"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:51dad22a-8ce5-180f-b8b6-0e8da8aa688f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E826:2371E7:50BC2F9:715E182:6A5104B5 |
| html-safe-nonce | 5e10c5a358b2711f7d3f68fcc103b63ed2948fef502bc8839a70a655a84ac494 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODI2OjIzNzFFNzo1MEJDMkY5OjcxNUUxODI6NkE1MTA0QjUiLCJ2aXNpdG9yX2lkIjoiMjYwNjMwMTEyMDM4NjEwNjU0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 092631e06e48ec5272f0fffc6e1f7329fce0b3dd6d66124473e17c75830a131e |
| hovercard-subject-tag | issue:1385135084 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/24006/issue_layout |
| twitter:image | https://opengraph.githubassets.com/10de225e81d381a935d63eaaaec5b06205215b77dc52eeb184730bf9ae7ca9f1/matplotlib/matplotlib/issues/24006 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/10de225e81d381a935d63eaaaec5b06205215b77dc52eeb184730bf9ae7ca9f1/matplotlib/matplotlib/issues/24006 |
| og:image:alt | Summary from: #23995 (comment) tricontour[f] documents and accepts parameters origin and extent, but interestingly, they are not used 😲. They are only used in contour[f], where one can leave out X ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | timhoffm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12 |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 90441ea9b98e7491aa6ebcd135fccce4e2396f48 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width