René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: Overflow of 16-bit integer in Agg renderer causes PolyCollections to be drawn at incorrect locations","articleBody":"### Bug summary\n\nBecause the pixel x coordinates of scanline cells are casted from 32-bit integers to 16-bit ones in Agg ([this line](https://github.com/matplotlib/matplotlib/blob/3b79f63980c767fabc59ec5ba267818d8b4b5671/extern/agg24-svn/include/agg_scanline_p.h#L96)), some polygons that are outside the drawing area may actually be drawn at an incorrect location if they are far enough from the viewport so that the 16-bit integer used for actual drawing overflows and the value happens to be inside the drawing area.\n\n### Code for reproduction\n\n```python\nimport matplotlib.pyplot as plt\r\nimport matplotlib\r\nmatplotlib.use('TkAgg')\r\n\r\n# Create a 120x120 px figure\r\nfig = plt.figure(figsize=(120, 120), dpi=1)\r\n# Add axis that fills the whole figure\r\nax = fig.add_axes([0, 0, 1, 1])\r\nax.axis('off')\r\n# Plot one fill_between at x, y = 0, width = 100 and height = 50\r\nax.fill_between([0, 100], 0, 50, color='r')\r\n# Plot another fill_between at x = 65536, y = 50, width=100 and height = 50\r\n# 65536 causes the 16-bit integer to overflow so that the coordinate becomes actually 0\r\nax.fill_between([2 ** 16, 2 ** 16 + 100], 50, 100, color='b')\r\n# Set limits to ensure that one pixel in the rasterized image corresponds to one unit in the axis\r\nax.set_xlim(-10, 110)\r\nax.set_ylim(-10, 110)\r\n# Agg has the bug, Pdf does not\r\nplt.savefig('bug.png', dpi=1)\r\nplt.savefig('nobug.pdf', dpi=1)\r\nplt.show()\n```\n\n\n### Actual outcome\n\nThe PolyCollections are both drawn in the image, even though they are 65536 units apart and the x axis goes from -10 to 110.\r\n![bug](https://user-images.githubusercontent.com/22271977/189086700-199e718e-63f4-4928-800e-7075154a449a.png)\r\n\n\n### Expected outcome\n\nThere should only be the red rectangle, as in this PDF.\r\n[nobug.pdf](https://github.com/matplotlib/matplotlib/files/9525611/nobug.pdf)\r\n\n\n### Additional information\n\nI debugged this quite a bit, and turns out it is a bit tricky to replicate this. The PolyCollections need to be able to fit in the axes completely so that the optimized `draw_markers` function [is called](https://github.com/matplotlib/matplotlib/blob/3b79f63980c767fabc59ec5ba267818d8b4b5671/lib/matplotlib/collections.py#L406). Then, inside Agg, transforms are applied so that pixel coordinates are calculated. These coordinates are fine, as they use 32-bit integers. However, when Agg draws the scanlines, it converts the coordinates to 16-bit integers. If the axis is zoomed in enough and everything lines up just right, some points that have very high positive or very high negative pixel coordinates may appear in the viewport because the int16 conversion causes the 16-bit coordinate to over- or underflow and to be inside the viewport. An obvious fix could be to use int32 instead of int16 while drawing, but I don't know if that's possible or if matplotlib is even the right place to report, as this bug seems to be in Agg code. The original figure where I discovered this had many fill_betweens, and when zoomed in, some fill_betweens from earlier or later in the data would appear.\r\n\r\nNote that at least on my machine, the figure that is shown in the window might not have the bug present, but the saved PNG file should have it.\r\n\r\nI checked also the main branch (version `3.6.0.dev3132+gf8cf0ee5e7`), and it has the bug.\n\n### Operating system\n\nProbably anything where Agg runs (verified on RHEL8 and Windows)\n\n### Matplotlib Version\n\n3.5.3\n\n### Matplotlib Backend\n\nQtAgg\n\n### Python version\n\n3.9.13\n\n### Jupyter version\n\n_No response_\n\n### Installation\n\nconda","author":{"url":"https://github.com/Exploder98","@type":"Person","name":"Exploder98"},"datePublished":"2022-09-08T12:24:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/23826/matplotlib/issues/23826"}