René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: macosx subplot tool causes segfault when window closed","articleBody":"### Bug summary\n\nOn current main, clicking on the subplot tool the additional figure pops up and can be interacted with properly, however when clicking the close button the app crashes with a segfault. Possibly trying to release an object that has already been released/garbage collected previously... I can only reproduce this by clicking the subplot button. Manually calling `fig.canvas.toolbar.configure_subplots()` seems to work fine when closing that window. Perhaps we need an explicit retain on the objc side...\r\n\r\nThis was brought about by the change to ARC in #23060. I'm going to put the release critical label on it, because a segfault seems worse than memory leaks. Probably smart to revert #23060 if no one has an immediate fix for it.\n\n### Code for reproduction\n\n```python\nimport matplotlib.pyplot as plt\r\nplt.figure()\r\nplt.show()\n```\n\n\n### Actual outcome\n\nRelevant traceback:\r\n```\r\nException Type:        EXC_BAD_ACCESS (SIGSEGV)\r\nException Codes:       KERN_INVALID_ADDRESS at 0x0000000000000020\r\nException Codes:       0x0000000000000001, 0x0000000000000020\r\nException Note:        EXC_CORPSE_NOTIFY\r\n\r\nTermination Reason:    Namespace SIGNAL, Code 11 Segmentation fault: 11\r\nTerminating Process:   exc handler [42279]\r\n\r\nVM Region Info: 0x20 is not in any region.  Bytes before following region: 140737486852064\r\n      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL\r\n      UNUSED SPACE AT START\r\n---\u003e  \r\n      VM_ALLOCATE              7fffffe91000-7fffffe92000 [    4K] r-x/r-x SM=ALI  \r\n\r\nThread 0 Crashed::  Dispatch queue: com.apple.main-thread\r\n0   libobjc.A.dylib               \t    0x7ff80c2cd01f objc_release + 31\r\n1   libobjc.A.dylib               \t    0x7ff80c2d10da AutoreleasePoolPage::releaseUntil(objc_object**) + 164\r\n2   libobjc.A.dylib               \t    0x7ff80c2cdf5f objc_autoreleasePoolPop + 168\r\n3   CoreFoundation                \t    0x7ff80c4bfb8a _CFAutoreleasePoolPop + 22\r\n4   Foundation                    \t    0x7ff80d3334f0 -[NSAutoreleasePool drain] + 133\r\n5   AppKit                        \t    0x7ff80ef2bf9b -[NSApplication run] + 636\r\n6   _macosx.cpython-310-darwin.so \t       0x1161d13c3 show + 211\r\n```\n\n### Expected outcome\n\nNo segfault\n\n### Additional information\n\n_No response_\n\n### Operating system\n\n_No response_\n\n### Matplotlib Version\n\nmain\n\n### Matplotlib Backend\n\nmacosx\n\n### Python version\n\n_No response_\n\n### Jupyter version\n\n_No response_\n\n### Installation\n\n_No response_","author":{"url":"https://github.com/greglucas","@type":"Person","name":"greglucas"},"datePublished":"2022-08-17T22:13:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/23653/matplotlib/issues/23653"}