Title: DEV: Decide if pre-commit should continue to be used · Issue #22949 · matplotlib/matplotlib · GitHub
Open Graph Title: DEV: Decide if pre-commit should continue to be used · Issue #22949 · matplotlib/matplotlib
X Title: DEV: Decide if pre-commit should continue to be used · Issue #22949 · matplotlib/matplotlib
Description: OK, I have turned pre-commit on for the main repo (it was already on for pytest-mpl and ipympl). I am not super stoked that it has the ability to push to the main repo, but it is not the only application with similar access. Originally p...
Open Graph Description: OK, I have turned pre-commit on for the main repo (it was already on for pytest-mpl and ipympl). I am not super stoked that it has the ability to push to the main repo, but it is not the only appli...
X Description: OK, I have turned pre-commit on for the main repo (it was already on for pytest-mpl and ipympl). I am not super stoked that it has the ability to push to the main repo, but it is not the only appli...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/22949
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"DEV: Decide if pre-commit should continue to be used","articleBody":"\u003e OK, I have turned pre-commit on for the main repo (it was already on for pytest-mpl and ipympl). I am not super stoked that it has the ability to push to the main repo, but it is not the only application with similar access.\r\n\r\n_Originally posted by @tacaswell in https://github.com/matplotlib/matplotlib/issues/22777#issuecomment-1114065762_\r\n\r\n@tacaswell turned on pre-commit.ci for PR #22777\r\n\r\n[](https://results.pre-commit.ci/latest/github/matplotlib/matplotlib/main)\r\n\r\nfollowing discussions in PR #22809, PR #22777, and [on Gitter](https://gitter.im/matplotlib/matplotlib?at=6250b4dbddcba117a25fbf96).\r\n\r\nThere was not a clear consensus if the dev team was comfortable with another service that has push permissions like those shown in https://github.com/matthewfeickert/matplotlib/pull/9 being connected to the `matplotlib/matplotlib` repo and if the examples shown in https://github.com/matthewfeickert/matplotlib/pull/12 provided information that was acceptable.\r\n\r\nGiven https://github.com/matplotlib/matplotlib/pull/22777#issuecomment-1114061390\r\n\r\n\u003e I'm in favor of getting this running on CI in any way that marks with a red-x, merging this, and then iterating on how best to notify at what needs to be changed.\r\n\r\npre-commit.ci was turned on, but the dev team should decide if they are happy with it or not. If they are happy with it, I am willing to help answer any questions they have in the future on it and make demo PRs on my forks of any situations they might be concerned with. If they are not happy, I am willing to help implement a solution that is acceptable to them.","author":{"url":"https://github.com/matthewfeickert","@type":"Person","name":"matthewfeickert"},"datePublished":"2022-04-30T23:54:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/22949/matplotlib/issues/22949"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3071c487-6002-ee3f-f178-5344aa814d59 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B91C:69D3C:2C5748:3A98DD:6A5168D0 |
| html-safe-nonce | 135435a573ccec4dec712ae4ed178da371b56f2d63e55630db755c7c1c907ef6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTFDOjY5RDNDOjJDNTc0ODozQTk4REQ6NkE1MTY4RDAiLCJ2aXNpdG9yX2lkIjoiNTkzNTE4MDIxODI0MzMxMTgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f91c9a8beacee63cd61d9bf71982271e182f20768be5544a63b82ace064da661 |
| hovercard-subject-tag | issue:1221946645 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/22949/issue_layout |
| twitter:image | https://opengraph.githubassets.com/df13173887b1da6e710905be79b5b39e684713418f314604dabf22ed6525d8b4/matplotlib/matplotlib/issues/22949 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df13173887b1da6e710905be79b5b39e684713418f314604dabf22ed6525d8b4/matplotlib/matplotlib/issues/22949 |
| og:image:alt | OK, I have turned pre-commit on for the main repo (it was already on for pytest-mpl and ipympl). I am not super stoked that it has the ability to push to the main repo, but it is not the only appli... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | matthewfeickert |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 60eaaf6d4dbaa817031b556aebd8a0a7eeb81b97 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width