René's URL Explorer Experiment


Title: [MNT]: sort out renderers · Issue #22744 · matplotlib/matplotlib · GitHub

Open Graph Title: [MNT]: sort out renderers · Issue #22744 · matplotlib/matplotlib

X Title: [MNT]: sort out renderers · Issue #22744 · matplotlib/matplotlib

Description: Summary Various methods require a renderer, in particular get_tightbbox and get_window_extent. We have quite a few inconsistencies here. Many implementations of get_window_extent have renderer as an optional kwarg, and fallback: fallback...

Open Graph Description: Summary Various methods require a renderer, in particular get_tightbbox and get_window_extent. We have quite a few inconsistencies here. Many implementations of get_window_extent have renderer as a...

X Description: Summary Various methods require a renderer, in particular get_tightbbox and get_window_extent. We have quite a few inconsistencies here. Many implementations of get_window_extent have renderer as a...

Opengraph URL: https://github.com/matplotlib/matplotlib/issues/22744

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[MNT]: sort out renderers","articleBody":"### Summary\n\nVarious methods require a renderer, in particular `get_tightbbox` and `get_window_extent`.  We have quite a few inconsistencies here.\r\n\r\nMany implementations of `get_window_extent` have `renderer` as an optional kwarg, and fallback:  fallbacks are `self.figure._cachedRenderer` (`Text`, `Legend`) and some other `get_window_extent` don't need the renderer.  \r\n\r\n`get_tightbbox` always needs the renderer, but largely to pass to `get_window_extent` calls on `Text` objects.  \r\n\r\n`tight_layout` and `constrained_layout` need the renderer, but that is only because they want to pass it to the `get_tightbbox`.  \r\n\r\n\n\n### Proposed fix\n\n\r\nIt _seems_ that we don't need to specify the renderer most of the time in `get_window_extent`, but can safely fall back on the `_cachedRenderer` or `fig.canvas.get_renderer`, so it seems more consistent to just make this argument always optional.  However, perhaps I'm missing a subtlety where the user may want to call `get_window_extent(renderer=different_renderer)`, but I have no idea what that use case is.  \r\n\r\n1. make renderer a kwarg in all `get_window_extent` methods.\r\n3. improve the fallbacks in all the `get_window_extents`: I'm not sure `_cachedRenderer` is adequate, and we probably want `Figure._get_cachedRenderer` that has some fallbacks in `_cachedRenderer` is None, or fakes a draw to fill the cache.  \r\n4. make renderer an optional kwarg in all `get_tightbbox` methods.  \r\n\r\nThis needs comment though from folks who understand the renderer system better: @QuLogic @anntzer @tacaswell ?  Thanks!","author":{"url":"https://github.com/jklymak","@type":"Person","name":"jklymak"},"datePublished":"2022-03-31T07:45:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/22744/matplotlib/issues/22744"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4cb634e3-1cd6-eada-c82a-250b5c3a400e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDDF6:3CF864:15C0B8D:1CC635C:6A51C053
html-safe-nonce68852d8cea26f0a49d9923fb401aca63b2e2b8f366237a88fb74ef446543d1ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREY2OjNDRjg2NDoxNUMwQjhEOjFDQzYzNUM6NkE1MUMwNTMiLCJ2aXNpdG9yX2lkIjoiNjUxMzEwNTE4OTMyMjQ3MzU1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac018ebc3063795284953ef9ccf3c6e04fe3a61c26230c5e94d39e03b3918c423f
hovercard-subject-tagissue:1187655230
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/22744/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ff8baff5c609b73eb84fd4d8af0d8006e67d0327e97c5bec5dfa6ff6a4d28a4f/matplotlib/matplotlib/issues/22744
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ff8baff5c609b73eb84fd4d8af0d8006e67d0327e97c5bec5dfa6ff6a4d28a4f/matplotlib/matplotlib/issues/22744
og:image:altSummary Various methods require a renderer, in particular get_tightbbox and get_window_extent. We have quite a few inconsistencies here. Many implementations of get_window_extent have renderer as a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejklymak
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/issues/22744#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F22744
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F22744
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/issues/22744
Reloadhttps://github.com/matplotlib/matplotlib/issues/22744
Reloadhttps://github.com/matplotlib/matplotlib/issues/22744
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/22744
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/22744
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
[MNT]: sort out renderershttps://github.com/matplotlib/matplotlib/issues/22744#top
Maintenancehttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Maintenance%22
https://github.com/jklymak
jklymakhttps://github.com/jklymak
on Mar 31, 2022https://github.com/matplotlib/matplotlib/issues/22744#issue-1187655230
@QuLogichttps://github.com/QuLogic
@anntzerhttps://github.com/anntzer
@tacaswellhttps://github.com/tacaswell
Maintenancehttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Maintenance%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.