René's URL Explorer Experiment


Title: [Bug]: FontManager.addfont doesn't accept pathlib.Path of TTF font · Issue #22582 · matplotlib/matplotlib · GitHub

Open Graph Title: [Bug]: FontManager.addfont doesn't accept pathlib.Path of TTF font · Issue #22582 · matplotlib/matplotlib

X Title: [Bug]: FontManager.addfont doesn't accept pathlib.Path of TTF font · Issue #22582 · matplotlib/matplotlib

Description: Bug summary The FontManager.addfont() method is documented as accepting a path-like, but if a path-like for a .ttf font file is passed it raises TypeError Code for reproduction from pathlib import Path from matplotlib import get_data_pat...

Open Graph Description: Bug summary The FontManager.addfont() method is documented as accepting a path-like, but if a path-like for a .ttf font file is passed it raises TypeError Code for reproduction from pathlib import ...

X Description: Bug summary The FontManager.addfont() method is documented as accepting a path-like, but if a path-like for a .ttf font file is passed it raises TypeError Code for reproduction from pathlib import ...

Opengraph URL: https://github.com/matplotlib/matplotlib/issues/22582

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: FontManager.addfont doesn't accept pathlib.Path of TTF font","articleBody":"### Bug summary\r\n\r\nThe [`FontManager.addfont()`](https://github.com/matplotlib/matplotlib/blob/710fce3df95e22701bd68bf6af2c8adbc9d67a79/lib/matplotlib/font_manager.py#L1077-L1094) method is documented as accepting a path-like, but if a path-like for a .ttf font file is passed it raises `TypeError`\r\n\r\n### Code for reproduction\r\n\r\n```python\r\nfrom pathlib import Path\r\nfrom matplotlib import get_data_path, __version__\r\nfrom matplotlib.font_manager import fontManager\r\n\r\npath = Path(get_data_path()) / \"fonts\" / \"ttf\" / \"cmr10.ttf\"\r\n\r\nprint(\"matplotlib\", __version__)\r\nfontManager.addfont(str(path))  # Works\r\nprint(\"str ok\")\r\nfontManager.addfont(path)  # TypeError\r\nprint(\"path ok\")\r\n```\r\n\r\n\r\n### Actual outcome\r\n\r\n```\r\nmatplotlib 3.5.1\r\nstr ok\r\nTraceback (most recent call last):\r\n  File \"/home/twm/dev/roofs/repro.py\", line 10, in \u003cmodule\u003e\r\n    fontManager.addfont(path)  # TypeError\r\n  File \"/home/twm/dev/roofs/venv/lib/python3.9/site-packages/matplotlib/font_manager.py\", line 1092, in addfont\r\n    font = ft2font.FT2Font(path)\r\nTypeError: First argument must be a path or binary-mode file object\r\n```\r\n\r\n### Expected outcome\r\n\r\n```\r\nmatplotlib 3.5.1\r\nstr ok\r\npath ok\r\n```\r\n\r\n### Additional information\r\n\r\nIt looks like the simplest fix would be to convert path-likes to `str` since [`FT2Font` is implemented in C++](https://github.com/matplotlib/matplotlib/blob/9197433d50ed77c37a2d5fcb4e0a3f4b26112c8e/src/ft2font.cpp).\r\n\r\n### Operating system\r\n\r\nUbuntu 20.04\r\n\r\n### Matplotlib Version\r\n\r\n3.5.1\r\n\r\n### Matplotlib Backend\r\n\r\nTkAgg\r\n\r\n### Python version\r\n\r\n3.9.5\r\n\r\n### Jupyter version\r\n\r\nN/A\r\n\r\n### Installation\r\n\r\npip","author":{"url":"https://github.com/twm","@type":"Person","name":"twm"},"datePublished":"2022-03-02T04:00:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/22582/matplotlib/issues/22582"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5d86fcab-e6c1-21ea-5bf4-e0df000c6894
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBFEE:9D184:C271D2:105E463:6A5169F2
html-safe-nonce8ad3c31de75bc2318d7694a7c8d126038f0ee6179481643a53bd93ff9680adb4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkVFOjlEMTg0OkMyNzFEMjoxMDVFNDYzOjZBNTE2OUYyIiwidmlzaXRvcl9pZCI6IjUwNjQzMDU0MzUyNjcxNzkzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfda196294fa21797c6dde08aac1df7ef1b42c5a571b5631d113d4a4ce82424d3
hovercard-subject-tagissue:1156320360
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/22582/issue_layout
twitter:imagehttps://opengraph.githubassets.com/86f0344ba8bdefd5a57a73e047ac468f79b22c18b133efa0d921f37ff4173285/matplotlib/matplotlib/issues/22582
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/86f0344ba8bdefd5a57a73e047ac468f79b22c18b133efa0d921f37ff4173285/matplotlib/matplotlib/issues/22582
og:image:altBug summary The FontManager.addfont() method is documented as accepting a path-like, but if a path-like for a .ttf font file is passed it raises TypeError Code for reproduction from pathlib import ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametwm
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release60eaaf6d4dbaa817031b556aebd8a0a7eeb81b97
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/issues/22582#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F22582
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F22582
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/issues/22582
Reloadhttps://github.com/matplotlib/matplotlib/issues/22582
Reloadhttps://github.com/matplotlib/matplotlib/issues/22582
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/22582
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/22582
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
#22591https://github.com/matplotlib/matplotlib/pull/22591
[Bug]: FontManager.addfont doesn't accept pathlib.Path of TTF fonthttps://github.com/matplotlib/matplotlib/issues/22582#top
#22591https://github.com/matplotlib/matplotlib/pull/22591
Difficulty: Easyhttps://matplotlib.org/devdocs/devel/contribute.html#good-first-issueshttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Difficulty%3A%20Easy%22
Good first issueOpen a pull request against these issues if there are no active ones!https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Good%20first%20issue%22
status: has patchpatch suggested, PR still neededhttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20has%20patch%22
topic: text/fontshttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20text%2Ffonts%22
v3.6.0https://github.com/matplotlib/matplotlib/milestone/65
https://github.com/twm
twmhttps://github.com/twm
on Mar 2, 2022https://github.com/matplotlib/matplotlib/issues/22582#issue-1156320360
FontManager.addfont()https://github.com/matplotlib/matplotlib/blob/710fce3df95e22701bd68bf6af2c8adbc9d67a79/lib/matplotlib/font_manager.py#L1077-L1094
FT2Font is implemented in C++https://github.com/matplotlib/matplotlib/blob/9197433d50ed77c37a2d5fcb4e0a3f4b26112c8e/src/ft2font.cpp
Difficulty: Easyhttps://matplotlib.org/devdocs/devel/contribute.html#good-first-issueshttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Difficulty%3A%20Easy%22
Good first issueOpen a pull request against these issues if there are no active ones!https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Good%20first%20issue%22
status: has patchpatch suggested, PR still neededhttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20has%20patch%22
topic: text/fontshttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20text%2Ffonts%22
v3.6.0https://github.com/matplotlib/matplotlib/milestone/65
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.