René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Qt swapping ctrl and cmd on OSX","articleBody":"There is special casing for ctl / cmd in the Qt backend on OSX\r\n\r\nhttps://github.com/matplotlib/matplotlib/blob/9465538da0ebd041c3a87f7b004339c17576ae55/lib/matplotlib/backends/backend_qt.py#L49-L51\r\n\r\nThat is making the tests fail.  \r\n\r\nLooking at a US mac keyboard on the left side I see:\r\n\r\n```\r\nctrl | option | command\r\n```\r\n\r\nand looking at US windows keyboard I see\r\n\r\n```\r\nctrl | meta (aka windows) | alt\r\n```\r\n\r\nhowever that does not tell us what keycodes they actually generate.\r\n\r\nWe used to implement this logic differently (before we unified the qt backend code) \r\n\r\n### 3.4.3\r\n\r\nhttps://github.com/matplotlib/matplotlib/blob/919145fe9849c999aa491457c6de6faede5959c3/lib/matplotlib/backends/backend_qt5.py#L62-L67\r\n\r\n### 3.2.2\r\n\r\nhttps://github.com/matplotlib/matplotlib/blob/a1a5298b0d4a8d8230103d0fa8d369fca7fdeea0/lib/matplotlib/backends/backend_qt5.py#L70-L85\r\n\r\nThis swapping goes all the way back to 5fdd68adac02827bb28f17ea88d2a6996c4acb1d (2012).\r\n\r\nI think we need to:\r\n\r\n - have a mac user with a mac keyboard veryify that the keys they hit match the keycodes we expect\r\n - if the keys are right to the human typing then fix the tests (probably by tweaking what the key-codes fed in are)\r\n - if the keys are wrong to the human typing\r\n    - if they are consistent across mpl versions on osx: gnash our teeth in despair and figure out how we want to fix this (on one hand, we should make sure that the key-codes are consistent across platfroms, on the other hand we do not want to break existing OSX users).\r\n    - if they changed from 3.4 to the default branch, fix the re-mapping\r\n\r\nI also have a worry that Qt has started to fix this for us.\r\n\r\n----\r\n\r\nFYI: I just ran the latest tests and these are now failing for me and I'm wondering if it has to do with being on a mac? The tests look like they are swapping cmd/ctrl, so I tried swapping the modifier keys on my system and that didn't help.\r\n\r\n```bash\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[Qt5Agg-control] - AssertionError: assert 'cmd+a' == 'ctrl+a'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[Qt5Agg-alt_control] - AssertionError: assert 'alt+cmd' == 'alt+control'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[Qt5Agg-control_alt] - AssertionError: assert 'cmd+alt' == 'ctrl+alt'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[Qt5Agg-modifier_order] - AssertionError: assert 'cmd+alt+ctrl+á' == 'ctrl+alt+super+á'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[Qt5Agg-backspace_mod] - AssertionError: assert 'cmd+backspace' == 'ctrl+backspace'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[QtAgg-control] - AssertionError: assert 'cmd+a' == 'ctrl+a'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[QtAgg-alt_control] - AssertionError: assert 'alt+cmd' == 'alt+control'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[QtAgg-control_alt] - AssertionError: assert 'cmd+alt' == 'ctrl+alt'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[QtAgg-modifier_order] - AssertionError: assert 'cmd+alt+ctrl+á' == 'ctrl+alt+super+á'\r\nFAILED lib/matplotlib/tests/test_backend_qt.py::test_correct_key[QtAgg-backspace_mod] - AssertionError: assert 'cmd+backspace' == 'ctrl+backspace'\r\n```\r\n\r\nIt looks like these _may_ be getting skipped on the macos-latest CI?\r\n\r\n```bash\r\nSKIPPED [22] lib/matplotlib/tests/test_backend_qt.py:168: No usable Qt bindings\r\n```\r\n\r\n_Originally posted by @greglucas in https://github.com/matplotlib/matplotlib/issues/20868#issuecomment-921432176_\r\n","author":{"url":"https://github.com/tacaswell","@type":"Person","name":"tacaswell"},"datePublished":"2021-09-17T13:52:29.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/21110/matplotlib/issues/21110"}