Title: [MNT]: Should set_size_inches be updated to use device_pixel_ratio? · Issue #21090 · matplotlib/matplotlib · GitHub
Open Graph Title: [MNT]: Should set_size_inches be updated to use device_pixel_ratio? · Issue #21090 · matplotlib/matplotlib
X Title: [MNT]: Should set_size_inches be updated to use device_pixel_ratio? · Issue #21090 · matplotlib/matplotlib
Description: Summary set_size_inches currently uses matplotlib/lib/matplotlib/figure.py Line 2659 in eecdbbc dpi_ratio = getattr(canvas, '_dpi_ratio', 1) I haven't actually tried, but I wonder if that was missed in #19126, and should be changed to ca...
Open Graph Description: Summary set_size_inches currently uses matplotlib/lib/matplotlib/figure.py Line 2659 in eecdbbc dpi_ratio = getattr(canvas, '_dpi_ratio', 1) I haven't actually tried, but I wonder if that was misse...
X Description: Summary set_size_inches currently uses matplotlib/lib/matplotlib/figure.py Line 2659 in eecdbbc dpi_ratio = getattr(canvas, '_dpi_ratio', 1) I haven't actually tried, but I wonder if th...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/21090
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[MNT]: Should set_size_inches be updated to use device_pixel_ratio?","articleBody":"### Summary\n\nset_size_inches currently uses\r\nhttps://github.com/matplotlib/matplotlib/blob/eecdbbc110faec59956a6c86741e8eb956209538/lib/matplotlib/figure.py#L2659\r\nI haven't actually tried, but I wonder if that was missed in https://github.com/matplotlib/matplotlib/pull/19126, and should be changed to `canvas.device_pixel_ratio`?\r\n\r\n(Likewise, backend_macosx.py would likely need to be updated in the same manner?)\n\n### Proposed fix\n\n_No response_","author":{"url":"https://github.com/anntzer","@type":"Person","name":"anntzer"},"datePublished":"2021-09-16T09:07:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/21090/matplotlib/issues/21090"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e665e29c-6e25-b9cf-d73b-a2e994b4967a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 840C:135646:C4FDB1:109CD15:6A52C46E |
| html-safe-nonce | 46893783df857a46408bb289310066f30756333bc6d91892ef1e64e32a091779 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDBDOjEzNTY0NjpDNEZEQjE6MTA5Q0QxNTo2QTUyQzQ2RSIsInZpc2l0b3JfaWQiOiI1NjQwNTQzNTg0ODM3MDkyNDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6046b8f71eaeacd5f84379e78a9bbc7a835b593334946cf9d225e29eb714d492 |
| hovercard-subject-tag | issue:997969565 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/21090/issue_layout |
| twitter:image | https://opengraph.githubassets.com/02759eddd002d86e67ec7a8f118657cd8aee6e01e22bb77b2774f67892067453/matplotlib/matplotlib/issues/21090 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/02759eddd002d86e67ec7a8f118657cd8aee6e01e22bb77b2774f67892067453/matplotlib/matplotlib/issues/21090 |
| og:image:alt | Summary set_size_inches currently uses matplotlib/lib/matplotlib/figure.py Line 2659 in eecdbbc dpi_ratio = getattr(canvas, '_dpi_ratio', 1) I haven't actually tried, but I wonder if that was misse... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anntzer |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width