René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: make_norm_from_scale should create picklable classes even when used in-line.","articleBody":"### Bug summary\n\nThe new `matplotlib.colors.make_norm_from_scale` helper dynamically generates a norm class from a scale class.  Currently, in the codebase, it is only used as a decorator to create \"toplevel\" classes (e.g., it is used to generate LogNorm from LogScale, etc.), but it can also be used within other functions to dynamically generate a norm class based on a user-given arbitrary scale (see #20752 for an example of application, which is however not necessary to understand for what follows).  In the latter case, the dynamically generate class is currently not picklable (because pickling of classes relies on the existence of global names, see e.g. [\"classes are pickled by named reference\"](https://docs.python.org/3/library/pickle.html#what-can-be-pickled-and-unpickled )).  It would be generally useful to get rid of this restriction, which can be done by implementing the [`__reduce__` protocol](https://docs.python.org/3/library/pickle.html#object.__reduce__); there's already other examples in the codebase of dynamically generated classes that use the same mechanism).\r\n\r\nI'm tagging this as \"good first issue\" because there's no API design and the eng goal is clear, but medium (perhaps hard) difficulty because it requires somewhat sophisticated understanding of the details of the pickling process.\n\n### Code for reproduction\n\n```python\npickle.dumps(matplotlib.colors.make_norm_from_scale(matplotlib.scale.LogitScale, matplotlib.colors.Normalize))\n```\n\n\n### Actual outcome\n\n```\r\nCan't pickle \u003cclass 'matplotlib.colors.Normalize'\u003e: it's not the same object as matplotlib.colors.Normalize\r\n```\r\n(Note the additional confusion here: there's two classes that are both named `matplotlib.colors.Normalize` -- the original one and the dynamically generated one -- but they are different.)\n\n### Expected outcome\n\nA correct round-trippable pickle.\n\n### Operating system\n\n_No response_\n\n### Matplotlib Version\n\nmaster (unreleased, pre 3.5)\n\n### Matplotlib Backend\n\n_No response_\n\n### Python version\n\n_No response_\n\n### Jupyter version\n\n_No response_\n\n### Other libraries\n\n_No response_\n\n### Installation\n\nsource\n\n### Conda channel\n\n_No response_","author":{"url":"https://github.com/anntzer","@type":"Person","name":"anntzer"},"datePublished":"2021-07-28T08:21:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/20755/matplotlib/issues/20755"}