Title: make_keyword_only doesn't work for pyplot-wrapped methods · Issue #20684 · matplotlib/matplotlib · GitHub
Open Graph Title: make_keyword_only doesn't work for pyplot-wrapped methods · Issue #20684 · matplotlib/matplotlib
X Title: make_keyword_only doesn't work for pyplot-wrapped methods · Issue #20684 · matplotlib/matplotlib
Description: Adding a @_api.make_keyword_only to a method that has a pyplot wrapper fails. make_keyword_only currently doesn't work with functions that have pyplot wrappers, because make_keyword_only fakes the displayed function signature to pretend ...
Open Graph Description: Adding a @_api.make_keyword_only to a method that has a pyplot wrapper fails. make_keyword_only currently doesn't work with functions that have pyplot wrappers, because make_keyword_only fakes the ...
X Description: Adding a @_api.make_keyword_only to a method that has a pyplot wrapper fails. make_keyword_only currently doesn't work with functions that have pyplot wrappers, because make_keyword_only fakes ...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/20684
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"make_keyword_only doesn't work for pyplot-wrapped methods","articleBody":"Adding a `@_api.make_keyword_only` to a method that has a pyplot wrapper fails. \r\n\r\n`make_keyword_only` currently doesn't work with functions that have pyplot wrappers, because make_keyword_only fakes the displayed function signature to pretend that the switch to kwonly already occurred, but the pyplot wrapper should be generated using the old (non-kwonly) signature, but that's not the case right now.\r\nIt's going to be slightly annoying to fix but probably just needs some wrangling, can you open a separate issue to track this? In any case I don't think this is required for this PR.\r\n\r\n_Originally posted by @anntzer in https://github.com/matplotlib/matplotlib/pull/18782#discussion_r672675696_","author":{"url":"https://github.com/jklymak","@type":"Person","name":"jklymak"},"datePublished":"2021-07-19T23:04:38.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/20684/matplotlib/issues/20684"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:09608ac5-8d2d-6346-5f1f-b39f6886c3f5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ABF0:117213:5AEBAB:78C4C6:6A530418 |
| html-safe-nonce | c36c0801d6561abec240b6a9942f5d4b8c22c4b7b7a67d57f762631619b8345a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkYwOjExNzIxMzo1QUVCQUI6NzhDNEM2OjZBNTMwNDE4IiwidmlzaXRvcl9pZCI6Ijc5NDQ1OTczMTkyNjUyMjM3MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5b77d3a84621ca626c58adab98d96e52d3c2225940f7161920f0236ecc07fff0 |
| hovercard-subject-tag | issue:948093030 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/20684/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1f0253e116a302aad29f94adf2cf06b0cdf24e1fdcf0de05d2ba1e3c56393659/matplotlib/matplotlib/issues/20684 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1f0253e116a302aad29f94adf2cf06b0cdf24e1fdcf0de05d2ba1e3c56393659/matplotlib/matplotlib/issues/20684 |
| og:image:alt | Adding a @_api.make_keyword_only to a method that has a pyplot wrapper fails. make_keyword_only currently doesn't work with functions that have pyplot wrappers, because make_keyword_only fakes the ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jklymak |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width