Title: MAINT: CircleCI build merged PRs · Issue #20658 · matplotlib/matplotlib · GitHub
Open Graph Title: MAINT: CircleCI build merged PRs · Issue #20658 · matplotlib/matplotlib
X Title: MAINT: CircleCI build merged PRs · Issue #20658 · matplotlib/matplotlib
Description: Describe the issue CircleCI (unlike Travis, AppVeyor, Azure, GitHub Actions, etc.) by default just builds PR branches themselves, as opposed to those PRs merged with upstream/master. This forces people to rebase to deal with issues that ...
Open Graph Description: Describe the issue CircleCI (unlike Travis, AppVeyor, Azure, GitHub Actions, etc.) by default just builds PR branches themselves, as opposed to those PRs merged with upstream/master. This forces pe...
X Description: Describe the issue CircleCI (unlike Travis, AppVeyor, Azure, GitHub Actions, etc.) by default just builds PR branches themselves, as opposed to those PRs merged with upstream/master. This forces pe...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/20658
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"MAINT: CircleCI build merged PRs","articleBody":"### Describe the issue\r\n\r\nCircleCI (unlike Travis, AppVeyor, Azure, GitHub Actions, etc.) by default just builds PR branches themselves, as opposed to those PRs merged with `upstream/master`. This forces people to rebase to deal with issues that crop up, for example in https://github.com/matplotlib/matplotlib/pull/20585#issuecomment-881693489, and also decreases uniformity across CIs.\r\n\r\n\u003c!-- A short 1-2 sentences that succinctly describe what could be improved --\u003e\r\n\r\n### Proposed fix\r\n\r\nFor a while (years?) in MNE now we have manually merged pull requests after the `checkout` step. I'm happy to [port our code](https://github.com/mne-tools/mne-python/blob/main/.circleci/config.yml#L64-L72) if people agree it would be useful. The only time it breaks or dies is when there are merge conflicts (i.e., the code can't be successfully merged), which arguably is fine behavior because people should merge/rebase at that point anyway.\r\n\r\n*EDIT:* Also need [these lines](https://github.com/mne-tools/mne-python/blob/main/.circleci/config.yml#L27-L31)","author":{"url":"https://github.com/larsoner","@type":"Person","name":"larsoner"},"datePublished":"2021-07-16T20:29:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/20658/matplotlib/issues/20658"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7953c7af-87dc-9e18-5a77-38a9407bb167 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E7E4:198E4:C64557:11F7CE3:6A55FD98 |
| html-safe-nonce | f1d9098e530055ff97596cf9227bc0a62be9f94fb15535ef7cdf4cf782af597a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0U0OjE5OEU0OkM2NDU1NzoxMUY3Q0UzOjZBNTVGRDk4IiwidmlzaXRvcl9pZCI6IjUzMzU3NjgyOTg4NzY2OTgwMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 61623a5d365a4d49be4c9a1cfb6d2b211d869eb1c7b93fc607f8b19d595a721d |
| hovercard-subject-tag | issue:946578458 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/20658/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5afd496e32fe4cf6e4580b8e34414cc6a05eef29279a096b15ccf1b38f896cc0/matplotlib/matplotlib/issues/20658 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5afd496e32fe4cf6e4580b8e34414cc6a05eef29279a096b15ccf1b38f896cc0/matplotlib/matplotlib/issues/20658 |
| og:image:alt | Describe the issue CircleCI (unlike Travis, AppVeyor, Azure, GitHub Actions, etc.) by default just builds PR branches themselves, as opposed to those PRs merged with upstream/master. This forces pe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | larsoner |
| hostname | github.com |
| expected-hostname | github.com |
| None | f4368738fc918fecd9b3958f6b49218bbe60d4185f38e72e3954e11f1ad0213a |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ed27e29ef37c0e8f612ea3fed8118b955b8314e2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width