René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"matplotlib dev: What happened to figure.dpi ?","articleBody":"This morning, we got a new error testing against matplotlib dev. Example log at https://app.circleci.com/pipelines/github/astropy/astropy/4691/workflows/582b72af-3420-4af5-a185-f0e41601edfd/jobs/86623\r\n\r\n```\r\n_______________________ test_no_numpy_warnings[contours] _______________________\r\n\r\nignore_matplotlibrc = None\r\ntmpdir = local('/tmp/pytest-of-root/pytest-0/test_no_numpy_warnings_contour0')\r\ngrid_type = 'contours'\r\n\r\n    @pytest.mark.parametrize('grid_type', ['lines', 'contours'])\r\n    def test_no_numpy_warnings(ignore_matplotlibrc, tmpdir, grid_type):\r\n        ax = plt.subplot(1, 1, 1, projection=WCS(TARGET_HEADER))\r\n        ax.imshow(np.zeros((100, 200)))\r\n        ax.coords.grid(color='white', grid_type=grid_type)\r\n    \r\n        with pytest.warns(None) as warning_lines:\r\n\u003e           plt.savefig(tmpdir.join('test.png').strpath)\r\n\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/astropy/visualization/wcsaxes/tests/test_misc.py:80: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/pyplot.py:956: in savefig\r\n    fig.canvas.draw_idle()   # need this if 'transparent=True' to reset colors\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/backend_bases.py:2058: in draw_idle\r\n    self.draw(*args, **kwargs)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/backends/backend_agg.py:406: in draw\r\n    self.figure.draw(self.renderer)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/artist.py:74: in draw_wrapper\r\n    result = draw(artist, renderer, *args, **kwargs)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/artist.py:51: in draw_wrapper\r\n    return draw(artist, renderer, *args, **kwargs)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/figure.py:2727: in draw\r\n    renderer, self, artists, self.suppressComposite)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/image.py:132: in _draw_list_compositing_images\r\n    a.draw(renderer)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/astropy/visualization/wcsaxes/core.py:459: in draw\r\n    super().draw(renderer, **kwargs)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/artist.py:51: in draw_wrapper\r\n    return draw(artist, renderer, *args, **kwargs)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/_api/deprecation.py:421: in wrapper\r\n    return func(*inner_args, **inner_kwargs)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/axes/_base.py:3102: in draw\r\n    mimage._draw_list_compositing_images(renderer, self, artists)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/image.py:132: in _draw_list_compositing_images\r\n    a.draw(renderer)\r\n../../.tox/py37-test-image-mpldev/lib/python3.7/site-packages/matplotlib/artist.py:51: in draw_wrapper\r\n    return draw(artist, renderer, *args, **kwargs)\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\n\r\nself = \u003cmatplotlib.collections.PathCollection object at 0x7f51ca1ac128\u003e\r\nrenderer = \u003cmatplotlib.backends.backend_agg.RendererAgg object at 0x7f51cc0a0ef0\u003e\r\n\r\n    @artist.allow_rasterization\r\n    def draw(self, renderer):\r\n\u003e       self.set_sizes(self._sizes, self.figure.dpi)\r\nE       AttributeError: 'NoneType' object has no attribute 'dpi'\r\n```\r\n\r\n# bisect attempt\r\n\r\nd49696aba62820ce4bab41ae4a8508743e39a0e4 is the first bad commit\r\n\r\n```\r\ncommit d49696aba62820ce4bab41ae4a8508743e39a0e4\r\nAuthor: Jody Klymak \u003c...\u003e\r\nDate:   Sun Mar 14 14:08:50 2021 -0700\r\n\r\n    New doc gallery for plot_types\r\n\r\n```\r\n\r\n# Update: I don't think this is true actually... I have no idea what is going on\r\n\r\nI think I traced it to https://github.com/astropy/astropy/blob/796b585f989319b766979df2110e0b4fa94a43a1/astropy/visualization/mpl_style.py#L63 . However, I am not sure if I should simply remove this setting or there is a new way to set it. Any advise would be greatly appreciated. Thanks!\r\n\r\n```python\r\n# Version 1 astropy plotting style for matplotlib\r\nastropy_mpl_style_1 = {\r\n    # ...\r\n    # Other\r\n    'savefig.dpi': 72,\r\n}\r\n```","author":{"url":"https://github.com/pllim","@type":"Person","name":"pllim"},"datePublished":"2021-04-09T14:21:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/19928/matplotlib/issues/19928"}