Title: Subclasses of Polygon with numpydoc xref throws error b/c of CapStyle, JoinStyle · Issue #19839 · matplotlib/matplotlib · GitHub
Open Graph Title: Subclasses of Polygon with numpydoc xref throws error b/c of CapStyle, JoinStyle · Issue #19839 · matplotlib/matplotlib
X Title: Subclasses of Polygon with numpydoc xref throws error b/c of CapStyle, JoinStyle · Issue #19839 · matplotlib/matplotlib
Description: Problem The sphinx links to CapStyle and JoinStyle in v3.4.0 are relative to the file, so a subclass of matplotlib.patches.Patch in a package with numpydoc xref (https://numpydoc.readthedocs.io/en/latest/install.html) turned on cannot li...
Open Graph Description: Problem The sphinx links to CapStyle and JoinStyle in v3.4.0 are relative to the file, so a subclass of matplotlib.patches.Patch in a package with numpydoc xref (https://numpydoc.readthedocs.io/en/...
X Description: Problem The sphinx links to CapStyle and JoinStyle in v3.4.0 are relative to the file, so a subclass of matplotlib.patches.Patch in a package with numpydoc xref (https://numpydoc.readthedocs.io/en/...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/19839
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Subclasses of Polygon with numpydoc xref throws error b/c of CapStyle, JoinStyle","articleBody":"\u003c!--To help us understand and resolve your issue, please fill out the form to the best of your ability.--\u003e\r\n\u003c!--You can feel free to delete the sections that do not apply.--\u003e\r\n\r\n### Problem\r\n\r\nThe sphinx links to `CapStyle` and `JoinStyle` in v3.4.0 are relative to the file, so a subclass of `matplotlib.patches.Patch` in a package with numpydoc xref (https://numpydoc.readthedocs.io/en/latest/install.html) turned on cannot link to the objects and errors with.\r\n```WARNING: py:obj reference target not found: CapStyle```\r\n```WARNING: py:obj reference target not found: JoinStyle```\r\n\r\nhttps://matplotlib.org/stable/api/_as_gen/matplotlib.patches.Patch.html#matplotlib.patches.Patch.set_capstyle\r\nhttps://matplotlib.org/stable/api/_as_gen/matplotlib.patches.Patch.html#matplotlib.patches.Patch.set_joinstyle\r\n\r\n```\r\n @docstring.interpd\r\n def set_capstyle(self, s):\r\n \"\"\"\r\n Set the `.CapStyle`.\r\n\r\n Parameters\r\n ----------\r\n s : `.CapStyle` or %(CapStyle)s\r\n \"\"\"\r\n cs = CapStyle(s)\r\n self._capstyle = cs\r\n self.stale = True\r\n```\r\n\r\n**Edit:**\r\n\r\nThe problem also appears to involve ``Patches.__init__``. I can monkey-patch a fix with \r\n\r\n```\r\nPolygon.__init__.__doc__ = Polygon.__init__.__doc__.replace(\r\n \"`.CapStyle`\", \"``matplotlib._enums.CapStyle``\")\r\nPolygon.__init__.__doc__ = Polygon.__init__.__doc__.replace(\r\n \"`.JoinStyle`\", \"``matplotlib._enums.JoinStyle``\")\r\nPolygon.set_capstyle.__doc__ = Polygon.set_capstyle.__doc__.replace(\r\n \"`.CapStyle`\", \"``matplotlib._enums.CapStyle``\")\r\nPolygon.set_joinstyle.__doc__ = Polygon.set_joinstyle.__doc__.replace(\r\n \"`.JoinStyle`\", \"``matplotlib._enums.JoinStyle``\")\r\n```\r\n\r\n### Suggested Improvement\r\n\r\n* This line could be be changed to say\r\n```\r\n @docstring.interpd\r\n def set_capstyle(self, s):\r\n \"\"\"\r\n Set the `~matplotlib._enums.CapStyle`.\r\n\r\n Parameters\r\n ----------\r\n s : `~matplotlib._enums.CapStyle` or %(CapStyle)s\r\n \"\"\"\r\n cs = CapStyle(s)\r\n self._capstyle = cs\r\n self.stale = True\r\n```\r\n\r\n\u003c!--\r\nIf you have an idea to improve the documentation please suggest it here\r\n\r\n* This line should be be changed to say [...]\r\n* Include a paragraph explaining [...]\r\n* Add a figure showing [...]\r\n--\u003e\r\n\r\n**Matplotlib version**\r\n\u003c!--Please specify the version of matplotlib and the version of the documentation that you are using:--\u003e\r\n * Operating system: Big Sur \u0026 Ubuntu\r\n * Matplotlib version 3.4.0\r\n * Matplotlib documentation version (is listed under the logo): 3.4.0\r\n","author":{"url":"https://github.com/nstarman","@type":"Person","name":"nstarman"},"datePublished":"2021-03-31T19:03:22.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":18},"url":"https://github.com/19839/matplotlib/issues/19839"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:fb1602b7-7f06-914a-f3ee-b81463895d4a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9FB6:9C6CC:4B5A71:67BD8B:6A506E72 |
| html-safe-nonce | 7609d1616705dd42ffe2ef1167bc8d5ed7b8c4dd56c4d5044a678f2149d833ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkI2OjlDNkNDOjRCNUE3MTo2N0JEOEI6NkE1MDZFNzIiLCJ2aXNpdG9yX2lkIjoiMTk5ODYwNjYzMTQ2NjcyNDk3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d049d60bd4360e4273f310d30ac70bce581c9d9389742d966445dfab239981be |
| hovercard-subject-tag | issue:847152986 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/19839/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b1f1bb59b181bf7c435249930c49cbd2669d0f232dfb3ab2e874f1b906e2cd83/matplotlib/matplotlib/issues/19839 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b1f1bb59b181bf7c435249930c49cbd2669d0f232dfb3ab2e874f1b906e2cd83/matplotlib/matplotlib/issues/19839 |
| og:image:alt | Problem The sphinx links to CapStyle and JoinStyle in v3.4.0 are relative to the file, so a subclass of matplotlib.patches.Patch in a package with numpydoc xref (https://numpydoc.readthedocs.io/en/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nstarman |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width