René's URL Explorer Experiment


Title: Accept additional string formatting styles in sankey · Issue #19133 · matplotlib/matplotlib · GitHub

Open Graph Title: Accept additional string formatting styles in sankey · Issue #19133 · matplotlib/matplotlib

X Title: Accept additional string formatting styles in sankey · Issue #19133 · matplotlib/matplotlib

Description: Currently, Sankey class accepts number formatting for labels using the old printf string formatting. I think the relevant line is here: matplotlib/lib/matplotlib/sankey.py Line 742 in a02ffbc quantity = self.format % abs(number) + self.u...

Open Graph Description: Currently, Sankey class accepts number formatting for labels using the old printf string formatting. I think the relevant line is here: matplotlib/lib/matplotlib/sankey.py Line 742 in a02ffbc quant...

X Description: Currently, Sankey class accepts number formatting for labels using the old printf string formatting. I think the relevant line is here: matplotlib/lib/matplotlib/sankey.py Line 742 in a02ffbc quant...

Opengraph URL: https://github.com/matplotlib/matplotlib/issues/19133

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Accept additional string formatting styles in sankey","articleBody":"Currently, Sankey class accepts number formatting for labels using the old printf string formatting. \r\n\r\nI think the relevant line is here:\r\n\r\nhttps://github.com/matplotlib/matplotlib/blob/a02ffbcd898793c95de66d3bdb4dc0a8b6c5a3d0/lib/matplotlib/sankey.py#L742\r\n\r\nF-strings seem to be preferred over this format (you probably know this already but here's [some reasons](https://realpython.com/python-formatted-output/)). A specific reason is that I can't easily use thousands separator with the old printf format, while this is trivial with f-strings.\r\n\r\nI can rewrite this pretty easily by changing the parameter to format for an f string, [as described here](https://stackoverflow.com/a/54780825).\r\n\r\nCan I put in a pull request thingy? Or is there a particular reason for this old format?","author":{"url":"https://github.com/CharlesHe16","@type":"Person","name":"CharlesHe16"},"datePublished":"2020-12-17T01:08:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":26},"url":"https://github.com/19133/matplotlib/issues/19133"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1aa18257-48de-c286-f016-6627ef6af7df
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDD34:1BA1D0:EA43F:130700:6A52EBC3
html-safe-noncecbd4b7e7929644bf79701d82ede955022402a68a766c1b6f060eb577352ab305
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDM0OjFCQTFEMDpFQTQzRjoxMzA3MDA6NkE1MkVCQzMiLCJ2aXNpdG9yX2lkIjoiNTY2OTQyMjI4MzUxMDQ0Mjk0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ab43f121537a8a53ea98129f2525f98fb659e74d472d978bd767f52ab4130e6
hovercard-subject-tagissue:769393578
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/19133/issue_layout
twitter:imagehttps://opengraph.githubassets.com/50af0e62a106e0cd9a388dbde23fa0d823a55901d1dd264917e09246003a8045/matplotlib/matplotlib/issues/19133
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50af0e62a106e0cd9a388dbde23fa0d823a55901d1dd264917e09246003a8045/matplotlib/matplotlib/issues/19133
og:image:altCurrently, Sankey class accepts number formatting for labels using the old printf string formatting. I think the relevant line is here: matplotlib/lib/matplotlib/sankey.py Line 742 in a02ffbc quant...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCharlesHe16
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/issues/19133#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F19133
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F19133
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/issues/19133
Reloadhttps://github.com/matplotlib/matplotlib/issues/19133
Reloadhttps://github.com/matplotlib/matplotlib/issues/19133
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/19133
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/19133
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Accept additional string formatting styles in sankeyhttps://github.com/matplotlib/matplotlib/issues/19133#top
Good first issueOpen a pull request against these issues if there are no active ones!https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Good%20first%20issue%22
New featurehttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22New%20feature%22
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
https://github.com/CharlesHe16
CharlesHe16https://github.com/CharlesHe16
on Dec 17, 2020https://github.com/matplotlib/matplotlib/issues/19133#issue-769393578
matplotlib/lib/matplotlib/sankey.pyhttps://github.com/matplotlib/matplotlib/blob/a02ffbcd898793c95de66d3bdb4dc0a8b6c5a3d0/lib/matplotlib/sankey.py#L742
a02ffbchttps://github.com/matplotlib/matplotlib/commit/a02ffbcd898793c95de66d3bdb4dc0a8b6c5a3d0
some reasonshttps://realpython.com/python-formatted-output/
as described herehttps://stackoverflow.com/a/54780825
Good first issueOpen a pull request against these issues if there are no active ones!https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Good%20first%20issue%22
New featurehttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22New%20feature%22
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.