René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"plot_surface should shade at draw time after projection to axes space, instead of doing so in data space","articleBody":"\u003c!--To help us understand and resolve your issue, please fill out the form to the best of your ability.--\u003e\r\n\u003c!--You can feel free to delete the sections that do not apply.--\u003e\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\n```python\r\nimport matplotlib.pyplot as plt\r\nimport numpy as np\r\n\r\nfig = plt.figure()\r\nx, y = np.mgrid[-10:11, -10:11]\r\nz = -(x ** 2 + y ** 2)\r\n\r\nax = fig.add_subplot(121, projection=\"3d\")\r\npc = ax.plot_surface(x, y, z)\r\nax = fig.add_subplot(122, projection=\"3d\")\r\npc = ax.plot_surface(x, y, z / 10)\r\n\r\nplt.show()\r\n```\r\ngives\r\n![test](https://user-images.githubusercontent.com/1322974/88836345-d1b92600-d1d6-11ea-8d41-818ae19c0abb.png)\r\n\r\nIn the right plot, the shading is basically constant throughout the image; in the left one, it changes very sharply at the tip of the paraboloid -- in fact, it nearly looks like the patches immediately at the left and the right are close to being the darkest and the brightest ones!  Given that these two patches have nearly the same orientation, how is that possible?\r\n\r\nFrom a quick investigation, I believe the root of the issue is the following: the shading is computed as the dot product of the patch normal(\\*) and the illumination direction, but this dot product is taken *in data space* (immediately when the Poly3DCollection is built in plot_surface) rather than after projection to \"3d screen space\" (at draw time).  In data space, the angle between the patches at the tip of the paraboloid is indeed much larger (the z-scale is much wider than the x/y-scale), hence the large change in dot product.\r\n\r\n(\\*) The patch normal is approximated using just three of the vertices of each patch, but this is not the source of the issue -- using e.g. the average of the normals computed at each vertex of the patch doesn't help.\r\n\r\nTherefore, I believe the shading should instead be computed at draw time, after projection to \"3d screen space\".  As another argument in favor of such behavior, consider also that if we ever manage to support log-scale in mplot3d, we'd certainly have to compute the dot products after scale application (because they are even more meaningless before scale application).  As usual, this could possibly be opt-in via a flag... or perhaps not.\r\n\r\n**Matplotlib version**\r\n\u003c!--Please specify your platform and versions of the relevant libraries you are using:--\u003e\r\n  * Operating system: linux\r\n  * Matplotlib version: master\r\n  * Matplotlib backend (`print(matplotlib.get_backend())`): qt5agg\r\n  * Python version: 38\r\n  * Jupyter version (if applicable):\r\n  * Other libraries: \r\n\r\n\u003c!--Please tell us how you installed matplotlib and python e.g., from source, pip, conda--\u003e\r\n\u003c!--If you installed from conda, please specify which channel you used if not the default--\u003e\r\n\r\n","author":{"url":"https://github.com/anntzer","@type":"Person","name":"anntzer"},"datePublished":"2020-07-29T18:17:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/18120/matplotlib/issues/18120"}