René's URL Explorer Experiment


Title: Proposal: add_subfigs.... · Issue #17375 · matplotlib/matplotlib · GitHub

Open Graph Title: Proposal: add_subfigs.... · Issue #17375 · matplotlib/matplotlib

X Title: Proposal: add_subfigs.... · Issue #17375 · matplotlib/matplotlib

Description: In #14421 there was some concern that gridspec was being overloaded and that something else should be doing that layout. I've mocked the following up, and it works quite well so far. Getting past mockup will be a fair bit of work, so wan...

Open Graph Description: In #14421 there was some concern that gridspec was being overloaded and that something else should be doing that layout. I've mocked the following up, and it works quite well so far. Getting past m...

X Description: In #14421 there was some concern that gridspec was being overloaded and that something else should be doing that layout. I've mocked the following up, and it works quite well so far. Getting pa...

Opengraph URL: https://github.com/matplotlib/matplotlib/issues/17375

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Proposal: add_subfigs....","articleBody":"In #14421 there was some concern that `gridspec` was being overloaded and that something else should be doing that layout.  \r\n\r\nI've mocked the following up, and it works quite well so far.  Getting past mockup will be a fair bit of work, so wanted some comment.\r\n\r\nFor sub-grids, currently we would do:\r\n\r\n```python\r\nfig = plt.figure()\r\ngs = fig.add_gridspec(2, 1)\r\n\r\naxs0 = gs[0, 0].subgridspec(3, 2).subplots()\r\naxs1 = gs[1, 0].subgridspec(3, 2).subplots()\r\n```\r\n\r\n![demo1](https://user-images.githubusercontent.com/1562854/81484699-9cff8900-91fc-11ea-97c2-48e771e9ab6f.png)\r\n\r\nWhich is fine, for what it is.  But imagine you want to have a colorbar that only pertains to `gs[0, 0]` or a legend just for that gridspec, or a suptitle. Currently we would have to add all that to `gridspec`.  But as @timhoffm pointed out, gridspec is not *really* equipped for this sort of thing.  \r\n\r\nHere instead I propose we create a new base class for `Figure`, say `FigureBase` and make `Figure` a subclass of that, and `SubFigure` a subclass of that.  \r\n\r\n`FigureBase` contains all the layout-specific functions of `Figure` and all the figure-level artists (figure legends, figure colorbars, suptitle, future supx/ylabel, etc).  `FigureBase` then gets a new method `subfigures` and `add_subfigure`, which give a virtual figure within the current figure. \r\n\r\nNow, instead of the above, we write:\r\n\r\n```python \r\nfig = plt.figure()\r\nsfigs = fig.subfigures(2, 1)\r\naxs0 = sfigs[0, 0].subplots(3, 2)\r\naxs1 = sfigs[1, 0].subplots(2, 2)\r\n```\r\n\r\n![demoNew](https://user-images.githubusercontent.com/1562854/81484695-9709a800-91fc-11ea-957f-25c00ddf40fe.png)\r\n\r\nYou can also do `add_subfigure` using subplotspecs\r\n\r\n```python\r\nfig = plt.figure()\r\ngs = fig.add_gridspec(2, 2)\r\nsfig = fig.add_subfigure(gs[:, 1])\r\naxs0 = sfig.subplots(3, 2)\r\n\r\nax1 = fig.add_subplot(gs[0, 0])\r\nax2 = fig.add_subplot(gs[1, 0])\r\nplt.show()\r\n```\r\n\r\n![demoNew2](https://user-images.githubusercontent.com/1562854/81484787-5bbba900-91fd-11ea-9cbc-d586f719559a.png)\r\n\r\nThe subfigs should be  API-wise the same as a normal figure.    And a subfig can then create subfigs. The subfigs keep track of their parent fig, and the parent keeps track of its subfigs, so traversing the tree is straight forward. \r\n\r\nI think this is cleaner than overloading gridspec.  Its semi-major surgery on Figure, but I've already implemented the above without too much pain.  The layout is all achieved relatively painlessly by having a second transform with the parent so that if `x0`, `y0` etc are in the parent's co-ordinates the subfigure has a `transFigure` given by:\r\n\r\n```python\r\n        self.bbox_relative = Bbox.from_bounds(x0, y0, widthf, heightf)\r\n        self.bbox = TransformedBbox(self.bbox_relative,\r\n                                    self._parent.transFigure)\r\n        self.transFigure = BboxTransformTo(self.bbox)\r\n```\r\n\r\nAnyway, wanted to throw this out there for comment or thoughts.  This seems a potentially cleaner way to arrange hierarchies of subplots.  \r\n\r\n\r\n","author":{"url":"https://github.com/jklymak","@type":"Person","name":"jklymak"},"datePublished":"2020-05-09T21:08:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/17375/matplotlib/issues/17375"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0cc607d7-914c-4bac-6d9a-cd7b354c3a84
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC13A:497D6:B93574:FA18F6:6A51F004
html-safe-nonce9267066196e43f5b1ee08c0920e651d61dcf8a1c73070e75e059cb7300d80ad8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTNBOjQ5N0Q2OkI5MzU3NDpGQTE4RjY6NkE1MUYwMDQiLCJ2aXNpdG9yX2lkIjoiNTY2NjA0NDAxMjU1OTIwMDI2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacffa08af197743a4ae3cb6b140bc4e4d64286c6eb5d8eaaaecf4c6d5acd80377d
hovercard-subject-tagissue:615260420
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/17375/issue_layout
twitter:imagehttps://opengraph.githubassets.com/62a51b24e68083759e457b97515ecd7bcb287717da329c376fe10e8962a64489/matplotlib/matplotlib/issues/17375
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/62a51b24e68083759e457b97515ecd7bcb287717da329c376fe10e8962a64489/matplotlib/matplotlib/issues/17375
og:image:altIn #14421 there was some concern that gridspec was being overloaded and that something else should be doing that layout. I've mocked the following up, and it works quite well so far. Getting past m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejklymak
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/issues/17375#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F17375
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fissues%2F17375
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/issues/17375
Reloadhttps://github.com/matplotlib/matplotlib/issues/17375
Reloadhttps://github.com/matplotlib/matplotlib/issues/17375
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/17375
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/issues/17375
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Proposal: add_subfigs....https://github.com/matplotlib/matplotlib/issues/17375#top
New featurehttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22New%20feature%22
topic: geometry managerLayoutEngine, Constrained layout, Tight layouthttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20geometry%20manager%22
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
https://github.com/jklymak
jklymakhttps://github.com/jklymak
on May 9, 2020https://github.com/matplotlib/matplotlib/issues/17375#issue-615260420
#14421https://github.com/matplotlib/matplotlib/pull/14421
https://user-images.githubusercontent.com/1562854/81484699-9cff8900-91fc-11ea-97c2-48e771e9ab6f.png
@timhoffmhttps://github.com/timhoffm
https://user-images.githubusercontent.com/1562854/81484695-9709a800-91fc-11ea-957f-25c00ddf40fe.png
https://user-images.githubusercontent.com/1562854/81484787-5bbba900-91fd-11ea-9cbc-d586f719559a.png
New featurehttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22New%20feature%22
topic: geometry managerLayoutEngine, Constrained layout, Tight layouthttps://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20geometry%20manager%22
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.