René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"check_figures_equal regression from 3.2.0 to 3.2.1","articleBody":"\u003c!--To help us understand and resolve your issue, please fill out the form to the best of your ability.--\u003e\r\n\u003c!--You can feel free to delete the sections that do not apply.--\u003e\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nPreviously, tests using check_figures_equal worked as expected on V3.2.0.  When upgrading to V3.2.1, with no other changes to system, tests now fail with the error message:\r\n\r\n```\r\nfile c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\matplotlib\\testing\\decorators.py, line 393\r\n          @pytest.mark.parametrize(\"ext\", extensions)\r\n          def wrapper(*args, **kwargs):\r\nE       fixture 'test_figure' not found\r\n\u003e       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, get_preparsed_fingerprint_game, get_preparsed_timeline_games, get_test_events_folder, get_test_events_folder_in_progress, get_test_json_games_folder, get_test_replay_pickle_folder, get_test_unparsed_folder, get_unparsed_test_games, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id\r\n\u003e       use 'pytest --fixtures [testpath]' for help on them.\r\n```\r\n\r\n**Code for reproduction**\r\n\r\n```python\r\n@check_figures_equal(extensions=[\"png\"])\r\ndef test_mpl_321(test_figure, reference_figure):\r\n\r\n    reference_figure.set_size_inches(8, 8)\r\n    ref_ax = reference_figure.subplots()\r\n    ref_ax.set_title(\"Test Title\")\r\n    ref_ax.pie(\r\n        [1, 2, 3, 4, 4],\r\n        labels=[\"A\", \"B\", \"C\", \"D\", \"E\"],\r\n    )\r\n\r\n\r\n    test_figure.set_size_inches(8, 8)\r\n    test_ax = test_figure.subplots()\r\n    test_ax.set_title(\"Test Title\")\r\n    test_ax.pie(\r\n        [1, 2, 3, 4, 4],\r\n        labels=[\"A\", \"B\", \"C\", \"D\", \"E\"],\r\n    )\r\n```\r\n\r\n\r\n**Actual outcome**\r\n\r\nThis is the console output showing:\r\n\r\n1. The test failing with V3.2.1\r\n2. Uninstall V3.2.1 and installing V3.2.0\r\n3. The test passing.\r\n\r\n```\r\nPS C:\\Users\\Andrew\\Workspace\\TripleAgent\u003e pytest -k test_mpl_321\r\n============================================================================================================================ test session starts =============================================================================================================================\r\nplatform win32 -- Python 3.7.5, pytest-4.5.0, py-1.8.0, pluggy-0.9.0\r\nrootdir: C:\\Users\\Andrew\\Workspace\\TripleAgent, inifile: setup.cfg\r\nplugins: xdist-1.29.0, forked-1.0.2, cov-2.7.1\r\ncollected 1223 items / 1222 deselected / 1 selected\r\n\r\ntriple_agent\\tests\\test_plot_types.py E                                                                                                                                                                                                                                 [100%]\r\n\r\n=================================================================================================================================== ERRORS ===================================================================================================================================\r\n____________________________________________________________________________________________________________________ ERROR at setup of test_mpl_321[png] _____________________________________________________________________________________________________________________\r\nfile c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\matplotlib\\testing\\decorators.py, line 393\r\n          @pytest.mark.parametrize(\"ext\", extensions)\r\n          def wrapper(*args, **kwargs):\r\nE       fixture 'test_figure' not found\r\n\u003e       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, get_preparsed_fingerprint_game, get_preparsed_timeline_games, get_test_events_folder, get_test_events_folder_in_progress, get_test_json_games_folder, get_test_replay_pickle_folder, get_test_unparsed_folder, get_unparsed_test_games, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id\r\n\u003e       use 'pytest --fixtures [testpath]' for help on them.\r\n\r\nc:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\matplotlib\\testing\\decorators.py:393\r\n============================================================================================================================== warnings summary ==============================================================================================================================\r\nc:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbformat\\notebooknode.py:4\r\n  c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbformat\\notebooknode.py:4: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working\r\n    from collections import Mapping\r\n\r\nc:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\jinja2\\utils.py:485\r\n  c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\jinja2\\utils.py:485: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working\r\n    from collections import MutableMapping\r\n\r\nc:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbconvert\\exporters\\exporter_locator.py:28\r\n  c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbconvert\\exporters\\exporter_locator.py:28: DeprecationWarning: `nbconvert.exporters.exporter_locator` is deprecated in favor of `nbconvert.exporters.base` since nbconvert 5.0.\r\n    DeprecationWarning)\r\n\r\n-- Docs: https://docs.pytest.org/en/latest/warnings.html\r\n=========================================================================================================== 1222 deselected, 3 warnings, 1 error in 17.47 seconds ============================================================================================================\r\n```\r\nUninstall V3.2.1 -\u003e Install V.3.2.0\r\n```\r\nPS C:\\Users\\Andrew\\Workspace\\TripleAgent\u003e pip uninstall matplotlib\r\nFound existing installation: matplotlib 3.2.1\r\nUninstalling matplotlib-3.2.1:\r\n  Would remove:\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\matplotlib-3.2.1-py3.7-nspkg.pth\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\matplotlib-3.2.1.dist-info\\*\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\matplotlib\\*\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\mpl_toolkits\\axes_grid1\\*\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\mpl_toolkits\\axes_grid\\*\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\mpl_toolkits\\axisartist\\*\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\mpl_toolkits\\mplot3d\\*\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\mpl_toolkits\\tests\\*\r\n    c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\pylab.py\r\nProceed (y/n)? y\r\n  Successfully uninstalled matplotlib-3.2.1\r\nPS C:\\Users\\Andrew\\Workspace\\TripleAgent\u003e pip install matplotlib==3.2.0\r\nCollecting matplotlib==3.2.0\r\n  Using cached matplotlib-3.2.0-cp37-cp37m-win_amd64.whl (9.2 MB)\r\nRequirement already satisfied: numpy\u003e=1.11 in c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages (from matplotlib==3.2.0) (1.16.3)\r\nRequirement already satisfied: python-dateutil\u003e=2.1 in c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages (from matplotlib==3.2.0) (2.8.0)\r\nRequirement already satisfied: kiwisolver\u003e=1.0.1 in c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages (from matplotlib==3.2.0) (1.0.1)\r\nRequirement already satisfied: cycler\u003e=0.10 in c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages (from matplotlib==3.2.0) (0.10.0)\r\nRequirement already satisfied: pyparsing!=2.0.4,!=2.1.2,!=2.1.6,\u003e=2.0.1 in c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages (from matplotlib==3.2.0) (2.4.0)\r\nRequirement already satisfied: six\u003e=1.5 in c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages (from python-dateutil\u003e=2.1-\u003ematplotlib==3.2.0) (1.12.0)\r\nRequirement already satisfied: setuptools in c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages (from kiwisolver\u003e=1.0.1-\u003ematplotlib==3.2.0) (40.8.0)\r\nInstalling collected packages: matplotlib\r\nSuccessfully installed matplotlib-3.2.0\r\n```\r\n```\r\nPS C:\\Users\\Andrew\\Workspace\\TripleAgent\u003e pytest -k test_mpl_321\r\n============================================================================================================================ test session starts =============================================================================================================================\r\nplatform win32 -- Python 3.7.5, pytest-4.5.0, py-1.8.0, pluggy-0.9.0\r\nrootdir: C:\\Users\\Andrew\\Workspace\\TripleAgent, inifile: setup.cfg\r\nplugins: xdist-1.29.0, forked-1.0.2, cov-2.7.1\r\ncollected 1223 items / 1222 deselected / 1 selected\r\n\r\ntriple_agent\\tests\\test_plot_types.py .                                                                                                                                                                                                                                 [100%]\r\n\r\n============================================================================================================================== warnings summary ==============================================================================================================================\r\nc:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbformat\\notebooknode.py:4\r\n  c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbformat\\notebooknode.py:4: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working\r\n    from collections import Mapping\r\n\r\nc:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\jinja2\\utils.py:485\r\n  c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\jinja2\\utils.py:485: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working\r\n    from collections import MutableMapping\r\n\r\nc:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbconvert\\exporters\\exporter_locator.py:28\r\n  c:\\users\\andrew\\appdata\\local\\programs\\python\\python37\\lib\\site-packages\\nbconvert\\exporters\\exporter_locator.py:28: DeprecationWarning: `nbconvert.exporters.exporter_locator` is deprecated in favor of `nbconvert.exporters.base` since nbconvert 5.0.\r\n    DeprecationWarning)\r\n\r\n-- Docs: https://docs.pytest.org/en/latest/warnings.html\r\n=========================================================================================================== 1 passed, 1222 deselected, 3 warnings in 20.79 seconds ===========================================================================================================\r\n```\r\n\r\n**Expected outcome**\r\n\r\nTests that were previously working are not expected to start failing on version update?  I might be missing something, but I didn't see anything in update notes about needing to refactor tests.\r\n\r\n**Matplotlib version**\r\n\u003c!--Please specify your platform and versions of the relevant libraries you are using:--\u003e\r\n  * Operating system: WIN10\r\n  * Matplotlib version: V3.2.1\r\n  * Matplotlib backend (`print(matplotlib.get_backend())`): TkAgg\r\n  * Python version: 3.7.5\r\n  * Jupyter version (if applicable): \r\n  * Other libraries: \r\n```\r\nabsl-py               0.7.1\r\nAdafruit-GPIO         1.0.3\r\nAdafruit-PureIO       0.2.3\r\napipkg                1.5\r\nappdirs               1.4.3\r\nastor                 0.7.1\r\nastroid               2.2.5\r\natomicwrites          1.3.0\r\nattrs                 19.1.0\r\nbackcall              0.1.0\r\nbeautifulsoup4        4.7.1\r\nblack                 19.10b0\r\nbleach                3.1.0\r\nbs4                   0.0.1\r\ncertifi               2018.11.29\r\nchardet               3.0.4\r\nClick                 7.0\r\ncolorama              0.4.1\r\ncolored               1.3.93\r\ncoverage              4.5.3\r\ncycler                0.10.0\r\ndecorator             4.3.0\r\ndefusedxml            0.5.0\r\nentrypoints           0.3\r\nexecnet               1.6.0\r\nfuture                0.17.1\r\ngast                  0.2.2\r\ngrpcio                1.20.1\r\ngym                   0.12.1\r\nh5py                  2.9.0\r\nidna                  2.8\r\nipykernel             5.1.0\r\nipython               7.2.0\r\nipython-genutils      0.2.0\r\nipywidgets            7.4.2\r\niso-639               0.4.5\r\niso3166               0.9\r\nisodate               0.6.0\r\nisort                 4.3.17\r\njedi                  0.13.2\r\nJinja2                2.10.1\r\njson5                 0.9.3\r\njsonpickle            1.2\r\njsonschema            3.0.1\r\njupyter-client        5.2.4\r\njupyter-console       6.0.0\r\njupyter-core          4.4.0\r\njupyterlab            2.0.1\r\njupyterlab-server     1.0.7\r\nKeras                 2.2.4\r\nKeras-Applications    1.0.7\r\nKeras-Preprocessing   1.0.9\r\nkiwisolver            1.0.1\r\nlazy-object-proxy     1.3.1\r\nlxml                  4.3.2\r\nMarkdown              3.1\r\nMarkupSafe            1.1.1\r\nmatplotlib            3.2.0\r\nmccabe                0.6.1\r\nmistune               0.8.4\r\nmock                  2.0.0\r\nmore-itertools        7.0.0\r\nmss                   4.0.3\r\nnbconvert             5.4.1\r\nnbformat              4.4.0\r\nnose                  1.3.7\r\nnotebook              5.7.8\r\nnumpy                 1.16.3\r\nopencv-contrib-python 4.0.0.21\r\nopencv-python         4.1.0.25\r\npandas                0.25.0\r\npandocfilters         1.4.2\r\nparso                 0.3.1\r\npathspec              0.6.0\r\npbr                   5.2.0\r\npickleshare           0.7.5\r\nPillow                5.4.1\r\npip                   20.0.2\r\npluggy                0.9.0\r\nprometheus-client     0.6.0\r\nprompt-toolkit        2.0.7\r\nprotobuf              3.7.1\r\npy                    1.8.0\r\npy-spy                0.1.10\r\nPyAutoGUI             0.9.42\r\npycryptodome          3.7.2\r\nPyGetWindow           0.0.4\r\npyglet                1.3.2\r\nPygments              2.3.1\r\npylint                2.3.1\r\nPyMsgBox              1.0.6\r\npyparsing             2.4.0\r\npypiwin32             223\r\nPyRect                0.1.4\r\npyrsistent            0.14.11\r\nPyScreeze             0.1.20\r\nPySocks               1.6.8\r\npytesseract           0.2.6\r\npytest                4.5.0\r\npytest-cov            2.7.1\r\npytest-forked         1.0.2\r\npytest-runner         4.4\r\npytest-xdist          1.29.0\r\npython-dateutil       2.8.0\r\nPyTweening            1.0.3\r\npytz                  2019.2\r\npywin32               224\r\npywinpty              0.5.5\r\nPyYAML                5.1\r\npyzmq                 18.0.1\r\nqtconsole             4.4.3\r\nregex                 2019.8.19\r\nrequests              2.21.0\r\nscipy                 1.3.0\r\nselenium              3.141.0\r\nSend2Trash            1.5.0\r\nsetuptools            40.8.0\r\nsimplejson            3.17.0\r\nsix                   1.12.0\r\nsnakeviz              2.0.0\r\nsoupsieve             1.8\r\nspotipy               2.4.4\r\nstreamlink            1.3.0\r\ntabulate              0.8.3\r\ntensorboard           1.13.1\r\ntensorflow            1.13.1\r\ntensorflow-estimator  1.13.0\r\ntermcolor             1.1.0\r\nterminado             0.8.2\r\ntestpath              0.4.2\r\ntoml                  0.10.0\r\ntornado               6.0.4\r\ntraitlets             4.3.2\r\ntyped-ast             1.4.0\r\nurllib3               1.24.1\r\nvulture               1.0\r\nwcwidth               0.1.7\r\nwebencodings          0.5.1\r\nwebsocket-client      0.54.0\r\nWerkzeug              0.15.2\r\nwheel                 0.33.1\r\nwidgetsnbextension    3.4.2\r\nwrapt                 1.11.1\r\n```\r\n\r\n\u003c!--Please tell us how you installed matplotlib and python e.g., from source, pip, conda--\u003e\r\n\u003c!--If you installed from conda, please specify which channel you used if not the default--\u003e\r\n\r\n","author":{"url":"https://github.com/andrewzwicky","@type":"Person","name":"andrewzwicky"},"datePublished":"2020-03-26T15:04:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/16916/matplotlib/issues/16916"}