René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Timeout parameters are accepted but not used","articleBody":"# Bug Report: Timeout parameters are accepted but not used\n\n## Summary\n\nThe `RESTClient` constructor accepts `connect_timeout` and `read_timeout` parameters, creates a `urllib3.Timeout` object, but never passes it to the `PoolManager` or uses it in HTTP requests. This means requests can hang indefinitely.\n\n## Environment\n\n- **Package**: massive==2.0.3\n- **Python**: 3.13\n- **OS**: macOS\n\n## Steps to Reproduce\n\n```python\nfrom massive import RESTClient\n\n# Create client with explicit timeouts\nclient = RESTClient(\n    api_key=\"your_api_key\",\n    connect_timeout=5.0,\n    read_timeout=5.0\n)\n\n# Check if timeout is actually used\nprint(\"Timeout object:\", client.timeout)\nprint(\"PoolManager kwargs:\", client.client.connection_pool_kw)\n```\n\n## Expected Behavior\n\nThe timeout should be passed to either:\n1. `urllib3.PoolManager(timeout=...)` at construction, or\n2. `self.client.request(..., timeout=self.timeout)` on each request\n\n## Actual Behavior\n\n```\nTimeout object: Timeout(connect=5.0, read=5.0, total=None)\nPoolManager kwargs: {'ca_certs': '...', 'cert_reqs': 'CERT_REQUIRED', 'retries': Retry(...)}\n```\n\nThe timeout object is created but **never used**. The `connection_pool_kw` does not contain a timeout, and the `_get` method in `base.py` does not pass timeout to requests.\n\n## Root Cause\n\nIn `massive/rest/base.py`:\n\n```python\n# Line 81: Timeout is created\nself.timeout = urllib3.Timeout(connect=connect_timeout, read=read_timeout)\n\n# Line 73-79: PoolManager is created WITHOUT timeout\nself.client = urllib3.PoolManager(\n    num_pools=num_pools,\n    headers=self.headers,\n    ca_certs=certifi.where(),\n    cert_reqs=\"CERT_REQUIRED\",\n    retries=retry_strategy,\n    # timeout=self.timeout  ← MISSING\n)\n\n# Line 119-124: Request is made WITHOUT timeout\nresp = self.client.request(\n    \"GET\",\n    self.BASE + path,\n    fields=params,\n    headers=headers,\n    # timeout=self.timeout  ← MISSING\n)\n```\n\n## Suggested Fix\n\nEither pass timeout to PoolManager (applies to all requests):\n\n```python\nself.client = urllib3.PoolManager(\n    num_pools=num_pools,\n    headers=self.headers,\n    ca_certs=certifi.where(),\n    cert_reqs=\"CERT_REQUIRED\",\n    retries=retry_strategy,\n    timeout=self.timeout,  # Add this\n)\n```\n\nOr pass timeout on each request (more flexible):\n\n```python\nresp = self.client.request(\n    \"GET\",\n    self.BASE + path,\n    fields=params,\n    headers=headers,\n    timeout=self.timeout,  # Add this\n)\n```\n\n## Impact\n\nWithout a working timeout, any network issue (slow server, DNS hang, etc.) can cause the SDK to hang indefinitely, blocking the calling thread.\n\n## Workaround\n\nFor async code, wrap SDK calls with `asyncio.timeout()`:\n\n```python\nimport asyncio\n\nasync def get_data_with_timeout():\n    async with asyncio.timeout(15):\n        return await asyncio.to_thread(client.get_snapshot_ticker, ...)\n```\n","author":{"url":"https://github.com/idan3","@type":"Person","name":"idan3"},"datePublished":"2026-01-07T11:02:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/983/client-python/issues/983"}