René's URL Explorer Experiment


Title: Incorrect Forex Price Spikes · Issue #668 · massive-com/client-python · GitHub

Open Graph Title: Incorrect Forex Price Spikes · Issue #668 · massive-com/client-python

X Title: Incorrect Forex Price Spikes · Issue #668 · massive-com/client-python

Description: Forex Websocket prices ("CAS.*") and Agg Data have occasional price spikes. These price spikes don't align with TradingView chart or Forex.com. I found the reason why: Polygon.io is using exchange bid price instead of trade price to popu...

Open Graph Description: Forex Websocket prices ("CAS.*") and Agg Data have occasional price spikes. These price spikes don't align with TradingView chart or Forex.com. I found the reason why: Polygon.io is using exchange ...

X Description: Forex Websocket prices ("CAS.*") and Agg Data have occasional price spikes. These price spikes don't align with TradingView chart or Forex.com. I found the reason why: Polygon.io is u...

Opengraph URL: https://github.com/massive-com/client-python/issues/668

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect Forex Price Spikes","articleBody":"Forex Websocket prices (\"CAS.*\") and Agg Data have occasional price spikes.  These price spikes don't align with TradingView chart or Forex.com. \r\n\r\nI found the reason why:\r\nPolygon.io is using exchange bid price instead of trade price to populate websocket and agg data.\r\n\r\n\r\nHere I am printing prices of CADJPY. The price 112.735 is an outlier that never happened. That price came from a stink bid on the exchange.\r\n\r\nPrint outs of Aggs and Quotes for the surrounding timestamps:\r\n\r\n```\r\nagg Agg(open=113.7, high=113.7, low=113.7, close=113.7, volume=1, vwap=113.7, timestamp=1715288494000, transactions=1, otc=None) dt 8999 ms\r\nagg Agg(open=112.735, high=112.735, low=112.735, close=112.735, volume=1, vwap=112.735, timestamp=1715288495000, transactions=1, otc=None) dt 7999 ms\r\nagg Agg(open=112.735, high=112.735, low=112.735, close=112.735, volume=1, vwap=112.735, timestamp=1715288497000, transactions=1, otc=None) dt 5999 ms\r\nagg Agg(open=113.53, high=113.53, low=113.53, close=113.53, volume=1, vwap=113.53, timestamp=1715288500000, transactions=1, otc=None) dt 2999 ms\r\nagg Agg(open=113.682, high=113.682, low=113.682, close=113.682, volume=1, vwap=113.682, timestamp=1715288503000, transactions=1, otc=None) dt -1 ms\r\nagg Agg(open=112.735, high=112.735, low=112.735, close=112.735, volume=1, vwap=112.735, timestamp=1715288504000, transactions=1, otc=None) dt -1001 ms\r\nagg Agg(open=113.62, high=113.62, low=113.62, close=113.62, volume=1, vwap=113.62, timestamp=1715288505000, transactions=1, otc=None) dt -2001 ms\r\nagg Agg(open=113.7, high=113.7, low=113.7, close=113.7, volume=1, vwap=113.7, timestamp=1715288509000, transactions=1, otc=None) dt -6001 ms\r\nagg Agg(open=113.63, high=113.63, low=113.63, close=113.63, volume=1, vwap=113.63, timestamp=1715288510000, transactions=1, otc=None) dt -7001 ms\r\n\r\n```\r\n\r\n\r\n```\r\nquote Quote(ask_exchange=48, ask_price=113.66, ask_size=None, bid_exchange=48, bid_price=113.62, bid_size=None, conditions=None, indicators=None, participant_timestamp=1715288505000000000, sequence_number=None, sip_timestamp=None, tape=None, trf_timestamp=None)\r\nquote Quote(ask_exchange=48, ask_price=114.358, ask_size=None, bid_exchange=48, bid_price=112.735, bid_size=None, conditions=None, indicators=None, participant_timestamp=1715288504000000000, sequence_number=None, sip_timestamp=None, tape=None, trf_timestamp=None)\r\nquote Quote(ask_exchange=48, ask_price=113.805, ask_size=None, bid_exchange=48, bid_price=113.682, bid_size=None, conditions=None, indicators=None, participant_timestamp=1715288503000000000, sequence_number=None, sip_timestamp=None, tape=None, trf_timestamp=None)\r\nquote Quote(ask_exchange=48, ask_price=113.57, ask_size=None, bid_exchange=48, bid_price=113.53, bid_size=None, conditions=None, indicators=None, participant_timestamp=1715288500000000000, sequence_number=None, sip_timestamp=None, tape=None, trf_timestamp=None)\r\n\r\n\r\n```\r\n\r\n\r\nAttaching images of these crazy spikes when monitoring websocket data:\r\n\r\n\r\n![image](https://github.com/polygon-io/client-python/assets/161871533/1f0dd310-fcdf-406d-8ffd-1ebcad985eb6)\r\n\r\n![image](https://github.com/polygon-io/client-python/assets/161871533/fb4b2476-2778-4c40-94fd-94d0d90bff0c)\r\n\r\n\r\n![image](https://github.com/polygon-io/client-python/assets/161871533/770488f4-6e8d-4172-aa29-0b0533bb8411)\r\n\r\nPossible solutions:\r\n1. Get actual trade data from data providers and use this to populate websocket and agg data instead of faking it.\r\n\r\n2. If trade data is not available, i recommend averaging the bid and ask price instead of just using the bid price. If the delta between bid and ask is too high, discard the price point. This seems to produce reasonable results. \r\n\r\n\r\nWithout a solution, there seems to be no point to having the \"\"CAS.*\" and \"Agg\" data when it merely uses the bid price in the existing Quote data. I implemented solution #2 already in my branch if you want to reference it, Solution #1 is the proper and preferred fix tho","author":{"url":"https://github.com/jbonilla-tao","@type":"Person","name":"jbonilla-tao"},"datePublished":"2024-05-10T23:12:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/668/client-python/issues/668"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:82aa5fa3-eeb0-53c4-0654-f47c08a2f22b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAEC6:366857:C8CBDB:1181A0D:6A4E8A81
html-safe-nonce5ed3a8424054e9c3551919808323da1561c66cdbf9e808e30748d0019d30aab0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUM2OjM2Njg1NzpDOENCREI6MTE4MUEwRDo2QTRFOEE4MSIsInZpc2l0b3JfaWQiOiIyMTQ1NjEwOTAyMzA4NTU1MzkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb4aa425fbcfafecb413ded70ebb1fb7254a097b256157ab0c4cd4bddd90de0da
hovercard-subject-tagissue:2290512725
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/massive-com/client-python/668/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6dc598830179d8a058b6447afea2c8af80e70d0485fb60b15587b6b5bcda917f/massive-com/client-python/issues/668
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6dc598830179d8a058b6447afea2c8af80e70d0485fb60b15587b6b5bcda917f/massive-com/client-python/issues/668
og:image:altForex Websocket prices ("CAS.*") and Agg Data have occasional price spikes. These price spikes don't align with TradingView chart or Forex.com. I found the reason why: Polygon.io is using exchange ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejbonilla-tao
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-preview
go-importgithub.com/massive-com/client-python git https://github.com/massive-com/client-python.git
octolytics-dimension-user_id191946194
octolytics-dimension-user_loginmassive-com
octolytics-dimension-repository_id216660192
octolytics-dimension-repository_nwomassive-com/client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id216660192
octolytics-dimension-repository_network_root_nwomassive-com/client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/massive-com/client-python/issues/668#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmassive-com%2Fclient-python%2Fissues%2F668
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmassive-com%2Fclient-python%2Fissues%2F668
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=massive-com%2Fclient-python
Reloadhttps://github.com/massive-com/client-python/issues/668
Reloadhttps://github.com/massive-com/client-python/issues/668
Reloadhttps://github.com/massive-com/client-python/issues/668
Please reload this pagehttps://github.com/massive-com/client-python/issues/668
massive-com https://github.com/massive-com
client-pythonhttps://github.com/massive-com/client-python
Notifications https://github.com/login?return_to=%2Fmassive-com%2Fclient-python
Fork 356 https://github.com/login?return_to=%2Fmassive-com%2Fclient-python
Star 1.5k https://github.com/login?return_to=%2Fmassive-com%2Fclient-python
Code https://github.com/massive-com/client-python
Issues 12 https://github.com/massive-com/client-python/issues
Pull requests 6 https://github.com/massive-com/client-python/pulls
Actions https://github.com/massive-com/client-python/actions
Security and quality 0 https://github.com/massive-com/client-python/security
Insights https://github.com/massive-com/client-python/pulse
Code https://github.com/massive-com/client-python
Issues https://github.com/massive-com/client-python/issues
Pull requests https://github.com/massive-com/client-python/pulls
Actions https://github.com/massive-com/client-python/actions
Security and quality https://github.com/massive-com/client-python/security
Insights https://github.com/massive-com/client-python/pulse
Incorrect Forex Price Spikeshttps://github.com/massive-com/client-python/issues/668#top
https://github.com/justinpolygon
bugSomething isn't workinghttps://github.com/massive-com/client-python/issues?q=state%3Aopen%20label%3A%22bug%22
datahttps://github.com/massive-com/client-python/issues?q=state%3Aopen%20label%3A%22data%22
https://github.com/jbonilla-tao
jbonilla-taohttps://github.com/jbonilla-tao
on May 10, 2024https://github.com/massive-com/client-python/issues/668#issue-2290512725
https://private-user-images.githubusercontent.com/161871533/329735619-1f0dd310-fcdf-406d-8ffd-1ebcad985eb6.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODM1MzI0NjIsIm5iZiI6MTc4MzUzMjE2MiwicGF0aCI6Ii8xNjE4NzE1MzMvMzI5NzM1NjE5LTFmMGRkMzEwLWZjZGYtNDA2ZC04ZmZkLTFlYmNhZDk4NWViNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcwOFQxNzM2MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wMzkwZjdiMDFmY2JjZWVlZGRkNjA5OGZiOGQzZjdhM2UxZjQzYWU0YTZhYzdlNTYxNmMxMDY3ZWM3NTU2YjU1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.rXQvN5mS9H63DYhNtyQpedPN0Z--M6QlnlwABL-HfZ8
https://private-user-images.githubusercontent.com/161871533/329735637-fb4b2476-2778-4c40-94fd-94d0d90bff0c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODM1MzI0NjIsIm5iZiI6MTc4MzUzMjE2MiwicGF0aCI6Ii8xNjE4NzE1MzMvMzI5NzM1NjM3LWZiNGIyNDc2LTI3NzgtNGM0MC05NGZkLTk0ZDBkOTBiZmYwYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcwOFQxNzM2MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZjYxN2MyNzk5NjgzMGY2MTA4NGIzZmEwYWI5NDY2YmYxOGQ0YjJjYTc1MjZmZjM5OTFiZTc0Y2EzNzViMDM0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.5bMkqaJhNwNrCuNrw1zAHN5oVXsJfSfRoMYF9t_12bc
https://private-user-images.githubusercontent.com/161871533/329735650-770488f4-6e8d-4172-aa29-0b0533bb8411.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODM1MzI0NjIsIm5iZiI6MTc4MzUzMjE2MiwicGF0aCI6Ii8xNjE4NzE1MzMvMzI5NzM1NjUwLTc3MDQ4OGY0LTZlOGQtNDE3Mi1hYTI5LTBiMDUzM2JiODQxMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcwOFQxNzM2MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YzdjYWQ0OTE3ZWI2M2I3ZTBjZWYwMTYyYjcwZThiOWU0Mzg2NmJhM2VhODY1NjdiY2MzY2MxYTIxZjM3ZjJhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.NTBK8fltVoU3nZNUol8Xa4ldFbkQ3X1mmgzF4iH1r2I
#2https://github.com/massive-com/client-python/pull/2
#1https://github.com/massive-com/client-python/pull/1
justinpolygonhttps://github.com/justinpolygon
bugSomething isn't workinghttps://github.com/massive-com/client-python/issues?q=state%3Aopen%20label%3A%22bug%22
datahttps://github.com/massive-com/client-python/issues?q=state%3Aopen%20label%3A%22data%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.