René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"library does not retry on 504 timeout errors","articleBody":"**Describe the bug**\r\nEven with retries=10 specified when creating the client object, the library doesn't seem to retry on 504 timeout errors. For example, a couple times last week I got a polygon.exceptions.BadResponse exception:\r\n```\r\n  File \"/path/to/lib64/python3.11/site-packages/polygon/rest/base.py\", line 192, in _paginate_iter\r\n    resp = self._get(\r\n           ^^^^^^^^^^\r\n  File \"/path/to/lib64/python3.11/site-packages/polygon/rest/base.py\", line 110, in _get\r\n    raise BadResponse(resp.data.decode(\"utf-8\"))\r\npolygon.exceptions.BadResponse: \u003chtml\u003e\r\n\u003chead\u003e\u003ctitle\u003e504 Gateway Time-out\u003c/title\u003e\u003c/head\u003e\r\n\u003cbody\u003e\r\n\u003ccenter\u003e\u003ch1\u003e504 Gateway Time-out\u003c/h1\u003e\u003c/center\u003e\r\n\u003chr\u003e\u003ccenter\u003enginx/1.19.2\u003c/center\u003e\r\n\u003c/body\u003e\r\n\u003c/html\u003e\r\n```\r\n\r\nThe core issue I think is that polygon's retry logic only retries for the default set of codes that urllib3 recognizes for retries (413, 429, 503). Adding 504 could be a simple fix.\r\n\r\nJust FYI for anyone else who is seeing this issue -- I'm currently using the tenacity library as a workaround:\r\n\r\n```python\r\ndef is_504(exception):\r\n    return isinstance(exception, polygon.exceptions.BadResponse) \\\r\n        and '504 Gateway Time-out' in str(exception)\r\npolygon_retry = tenacity.retry(retry=(tenacity.retry_if_exception(is_504)),\r\n    stop=tenacity.stop_after_attempt(10))\r\n```\r\nAnd then using `@polygon_retry` as a decorator for functions that call polygon library methods.\r\n\r\n**To Reproduce**\r\nIt's difficult to reproduce this problem since it doesn't happen very often. One way to reproduce it might be to create a mock API server that returns 504s.\r\n\r\n**Expected behavior**\r\nExpected behavior is for the polygon library to handle the timeout itself (based on the retries argument).","author":{"url":"https://github.com/kartiksubbarao","@type":"Person","name":"kartiksubbarao"},"datePublished":"2023-09-27T13:07:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/525/client-python/issues/525"}