René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"MACDIndicatorValue has histogram and signal values reversed","articleBody":"**Describe the bug**\r\nThe MACDIndicatorValue object create in response to python API call get_macd() has its histogram and signal values reversed. It appears the from_dict() deserializer either uses wrong labels or the variable assignment is incorrect.\r\n\r\n**To Reproduce**\r\nAs an example the most recent MACDIndicatorValue returned by the call\r\n\r\n    client = RESTClient(api_key=“….”)\r\n    client.get_macd(ticker=“DBC”, timestamp_lte=\"2023-09-16\", timespan=“week”, short_window=4, long_window=13, \r\n                                      signal_window=8, series_type=\"close\")\r\n\r\nis \r\n   MACDIndicatorValue(timestamp=1694318400000, value=0.6858891541204777, signal=0.23005417069090606, \r\n   histogram=0.4558349834295716)\r\n\r\nComparing with the values returned by a similar call to MACD with the same parameters in TradeView which yield:-\r\n hist (histogram) = 0.2301\r\n macd (value)     = 0.6859\r\n signal (signal)  = 0.4558\r\n\r\nAppears polygon has swapped its returned histogram and signal values. This, on the surface is confirmed by looking at the code\r\nWith respect to tag v1.12.4\r\nFile client-python/polygon/rest/models/indicators.py \r\nLine 34 \u0026 35\r\n            signal=d.get(\"histogram\", None),\r\n            histogram=d.get(\"signal\", None),\r\n\r\n**Expected behavior**\r\nWould expect the returned MACDIndicatorValue object in this situation to be :-\r\n\r\nMACDIndicatorValue(timestamp=1694318400000, value=0.6858891541204777, histogram=0.23005417069090606, signal=0.4558349834295716)\r\n\r\n**Screenshots**\r\nNone\r\n\r\n**Additional context**\r\nNone\r\n\r\n","author":{"url":"https://github.com/ibcodemonkey","@type":"Person","name":"ibcodemonkey"},"datePublished":"2023-09-17T12:30:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/517/client-python/issues/517"}