Title: get_ticker_details doesn't include the date param · Issue #320 · massive-com/client-python · GitHub
Open Graph Title: get_ticker_details doesn't include the date param · Issue #320 · massive-com/client-python
X Title: get_ticker_details doesn't include the date param · Issue #320 · massive-com/client-python
Description: Describe the bug RESTClient.get_ticker_details calls self._get with params=params, rather than params=self._get_params(...), and thus ignores the date param specified by the caller To Reproduce from polygon import RESTClient client = RES...
Open Graph Description: Describe the bug RESTClient.get_ticker_details calls self._get with params=params, rather than params=self._get_params(...), and thus ignores the date param specified by the caller To Reproduce fro...
X Description: Describe the bug RESTClient.get_ticker_details calls self._get with params=params, rather than params=self._get_params(...), and thus ignores the date param specified by the caller To Reproduce fro...
Opengraph URL: https://github.com/massive-com/client-python/issues/320
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"get_ticker_details doesn't include the date param","articleBody":"**Describe the bug**\r\n`RESTClient.get_ticker_details` calls `self._get` with `params=params`, rather than `params=self._get_params(...)`, and thus ignores the `date` param specified by the caller\r\n\r\n**To Reproduce**\r\n```python\r\nfrom polygon import RESTClient\r\n\r\nclient = RESTClient(\"\u003cAPI token\u003e\")\r\n\r\nclient.get_ticker_details(\"AAPL\", date=\"2020-10-01\")\r\n```\r\n\r\n**Expected behavior**\r\nShould perform the API request with a query param `?date=2020-10-01`\r\n\r\n**Additional context**\r\nPR incoming 😃 \r\n","author":{"url":"https://github.com/jakekdodd","@type":"Person","name":"jakekdodd"},"datePublished":"2022-10-30T15:52:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/320/client-python/issues/320"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bc5c33eb-e452-70a3-81d9-2344fe5592d8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D574:F61E5:16A8158:1F82509:6A4DF0DE |
| html-safe-nonce | 965e9344143441c418e8e03a2fca5b3a8abc8f3af9eab5c9f9a4c0fb4f8ab8ee |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTc0OkY2MUU1OjE2QTgxNTg6MUY4MjUwOTo2QTRERjBERSIsInZpc2l0b3JfaWQiOiI3Njg1NDAzMTE2NzYyNDI3NjE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1a259fab19c692a781843e064fb5a2bded6d27034d279e3c553fc12fc76671f3 |
| hovercard-subject-tag | issue:1428869746 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/massive-com/client-python/320/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0ff86e378e5395a6066b0e1cabcb6470ea31b8d0379dbfd5840550607a799fcd/massive-com/client-python/issues/320 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0ff86e378e5395a6066b0e1cabcb6470ea31b8d0379dbfd5840550607a799fcd/massive-com/client-python/issues/320 |
| og:image:alt | Describe the bug RESTClient.get_ticker_details calls self._get with params=params, rather than params=self._get_params(...), and thus ignores the date param specified by the caller To Reproduce fro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jakekdodd |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566 |
| turbo-cache-control | no-preview |
| go-import | github.com/massive-com/client-python git https://github.com/massive-com/client-python.git |
| octolytics-dimension-user_id | 191946194 |
| octolytics-dimension-user_login | massive-com |
| octolytics-dimension-repository_id | 216660192 |
| octolytics-dimension-repository_nwo | massive-com/client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 216660192 |
| octolytics-dimension-repository_network_root_nwo | massive-com/client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f4bb89367ca678f057d79b1abc45d6675b1bd5b2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width