Title: SH-1113 Fail CI when a PR description contains a GitHub closing keyword by adikus · Pull Request #43 · logtail/logtail-python · GitHub
Open Graph Title: SH-1113 Fail CI when a PR description contains a GitHub closing keyword by adikus · Pull Request #43 · logtail/logtail-python
X Title: SH-1113 Fail CI when a PR description contains a GitHub closing keyword by adikus · Pull Request #43 · logtail/logtail-python
Description: Adds a CI check that fails when a PR description contains a GitHub closing keyword (close/fix/resolve followed by an issue reference). Issues in this repo are synced with Linear. A closing keyword closes the GitHub issue the moment the PR merges, while Linear's PR automation moves the linked Linear issue to Self QA at the same time. The two automations then fight: the GitHub issue is closed, reopened (with the e-mail noise that brings for the reporter), and the Linear issue ends up back in Triage. This has happened on every synced issue since July whose PR used a closing keyword, across several of our public repos. The convention going forward: reference the issue with Refs #123 and close it from Linear (Done) or by hand once the fix is released. Notes: The check only inspects the PR description. Closing keywords in commit messages merged to the default branch also close issues, so the convention needs to reach how we write PRs too. Without branch protection this is a red badge rather than a merge blocker unless it is made a required check. Same check as BetterStackHQ/terraform-provider-better-uptime#237. Linear: SH-1113
Open Graph Description: Adds a CI check that fails when a PR description contains a GitHub closing keyword (close/fix/resolve followed by an issue reference). Issues in this repo are synced with Linear. A closing keyword ...
X Description: Adds a CI check that fails when a PR description contains a GitHub closing keyword (close/fix/resolve followed by an issue reference). Issues in this repo are synced with Linear. A closing keyword ...
Opengraph URL: https://github.com/logtail/logtail-python/pull/43
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3e5be872-d5b9-e9a5-1a88-4663e5435c5e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EDD4:3DA76D:23C666:30C061:6AFBB09A |
| html-safe-nonce | 7e49ca2d69f3dd4d7113f684ac39f93931a53e3a16f0ce9f46a98212b304311a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREQ0OjNEQTc2RDoyM0M2NjY6MzBDMDYxOjZBRkJCMDlBIiwidmlzaXRvcl9pZCI6IjkxODIzMDUyNzA3NjIyODcyNTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f6af610aeb3536e948eb12ca4410c339851fe9286d5ab652611ac32c22af68aa |
| hovercard-subject-tag | pull_request:4475547367 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/logtail/logtail-python/pull/43/files |
| twitter:image | https://avatars.githubusercontent.com/u/1838476?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1838476?s=400&v=4 |
| og:image:alt | Adds a CI check that fails when a PR description contains a GitHub closing keyword (close/fix/resolve followed by an issue reference). Issues in this repo are synced with Linear. A closing keyword ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e25fbd830d3e6ad0e8935c105cf4fdc70c593dffcd27bb45b790ae4fece5ea55 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/logtail/logtail-python git https://github.com/logtail/logtail-python.git |
| octolytics-dimension-user_id | 78922349 |
| octolytics-dimension-user_login | logtail |
| octolytics-dimension-repository_id | 351343852 |
| octolytics-dimension-repository_nwo | logtail/logtail-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 351343852 |
| octolytics-dimension-repository_network_root_nwo | logtail/logtail-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08c8f17f9d27054a108b8b6254e405de0151f660 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width