Title: Can the content filter regex backtracks be optimized? · Issue #10 · littlebizzy/force-https · GitHub
Open Graph Title: Can the content filter regex backtracks be optimized? · Issue #10 · littlebizzy/force-https
X Title: Can the content filter regex backtracks be optimized? · Issue #10 · littlebizzy/force-https
Description: I have an edge-case scenario but wanted to suggest an improvement because it "could" affect users some day. I am applying the content filter as an output buffer so that I can also convert non-https links outside of the post content. When...
Open Graph Description: I have an edge-case scenario but wanted to suggest an improvement because it "could" affect users some day. I am applying the content filter as an output buffer so that I can also convert non-https...
X Description: I have an edge-case scenario but wanted to suggest an improvement because it "could" affect users some day. I am applying the content filter as an output buffer so that I can also convert...
Opengraph URL: https://github.com/littlebizzy/force-https/issues/10
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Can the content filter regex backtracks be optimized?","articleBody":"I have an edge-case scenario but wanted to suggest an improvement because it \"could\" affect users some day.\r\n\r\nI am applying the content filter as an output buffer so that I can also convert non-https links outside of the post content. When applied to a 518K JSON payload, the preg_replace_callback() function fails. I could likely address this by modifying the pcre backtrack/recursion limits on my server.\r\n\r\nYour users may trigger a similar edge case only if they have a large post_content field - unlikely, but remotely possible and a nasty gremlin to detect as there are no errors to explain the missing output.\r\n\r\nI would submit a patch if/when I raise my regex game.\r\n","author":{"url":"https://github.com/deltafactory","@type":"Person","name":"deltafactory"},"datePublished":"2019-01-18T17:46:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/10/force-https/issues/10"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f1f3f4f4-a61a-ad2d-f51c-c63813fa51ac |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 99E8:2095E1:221EA1A:2EE07A0:6A4F3E5B |
| html-safe-nonce | eefa3d4e6eecb4c5f1dfd4c3c12998ee8c6a338e66547f6fabd645e224da7d40 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUU4OjIwOTVFMToyMjFFQTFBOjJFRTA3QTA6NkE0RjNFNUIiLCJ2aXNpdG9yX2lkIjoiNDA0MjQyNjcyNTQ3MjA5MTczOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d3b1d8f30e7b6fe193f908367eee60ed00ee39951ee7b81032293056e5cd450e |
| hovercard-subject-tag | issue:400825797 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/littlebizzy/force-https/10/issue_layout |
| twitter:image | https://opengraph.githubassets.com/208c63eb2a54fb908bba82e1b7cf64a556b9a98f9e220a48a02be31104f6d863/littlebizzy/force-https/issues/10 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/208c63eb2a54fb908bba82e1b7cf64a556b9a98f9e220a48a02be31104f6d863/littlebizzy/force-https/issues/10 |
| og:image:alt | I have an edge-case scenario but wanted to suggest an improvement because it "could" affect users some day. I am applying the content filter as an output buffer so that I can also convert non-https... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | deltafactory |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| go-import | github.com/littlebizzy/force-https git https://github.com/littlebizzy/force-https.git |
| octolytics-dimension-user_id | 10787477 |
| octolytics-dimension-user_login | littlebizzy |
| octolytics-dimension-repository_id | 95499435 |
| octolytics-dimension-repository_nwo | littlebizzy/force-https |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 95499435 |
| octolytics-dimension-repository_network_root_nwo | littlebizzy/force-https |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width