| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5667bd08-220c-e541-a4a0-463ca2f5ba22 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BF48:18F1D7:7595CB:A1E1F7:6A63A5A8 |
| html-safe-nonce | 04c9c3ea46b15389d8aa4fe6005eb9039487f31ac8248f6cf4ef940cbbfcfe14 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjQ4OjE4RjFENzo3NTk1Q0I6QTFFMUY3OjZBNjNBNUE4IiwidmlzaXRvcl9pZCI6IjcxNDIxNTQ4MTM5ODQ0NDk5NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cbe83a10f02909e0062fe178c06f7fde451cb2d894b56e7c521bd96107e8969d |
| hovercard-subject-tag | pull_request:3928676129 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/liquid-java/liquidjava/267/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/95eecf327aa71452676ee23fda3eebed670b9aa8acebc5a2b4d39c85633143b7/liquid-java/liquidjava/pull/267 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/95eecf327aa71452676ee23fda3eebed670b9aa8acebc5a2b4d39c85633143b7/liquid-java/liquidjava/pull/267 |
| og:image:alt | Description
This PR fixes VC function substitution so function equality premises are removed after they are used to rewrite later premises or the conclusion, similarly to normal VC substitution.
Ex... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rcosta358 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ca676e17c4da4532dc68541e9fc874034ae840c26b5f34da7f1c42d9a600659 |
| turbo-cache-control | no-cache |
| go-import | github.com/liquid-java/liquidjava git https://github.com/liquid-java/liquidjava.git |
| octolytics-dimension-user_id | 242831829 |
| octolytics-dimension-user_login | liquid-java |
| octolytics-dimension-repository_id | 258218369 |
| octolytics-dimension-repository_nwo | liquid-java/liquidjava |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 258218369 |
| octolytics-dimension-repository_network_root_nwo | liquid-java/liquidjava |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3a0a9f049e072eb8e5795dfddcefdba9e277501d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/liquid-java/liquidjava/pull/267#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fliquid-java%2Fliquidjava%2Fpull%2F267 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fliquid-java%2Fliquidjava%2Fpull%2F267 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=liquid-java%2Fliquidjava |
| Reload | https://github.com/liquid-java/liquidjava/pull/267 |
| Reload | https://github.com/liquid-java/liquidjava/pull/267 |
| Reload | https://github.com/liquid-java/liquidjava/pull/267 |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
|
liquid-java
| https://github.com/liquid-java |
| liquidjava | https://github.com/liquid-java/liquidjava |
|
Notifications
| https://github.com/login?return_to=%2Fliquid-java%2Fliquidjava |
|
Fork
36
| https://github.com/login?return_to=%2Fliquid-java%2Fliquidjava |
|
Star
65
| https://github.com/login?return_to=%2Fliquid-java%2Fliquidjava |
|
Code
| https://github.com/liquid-java/liquidjava |
|
Issues
20
| https://github.com/liquid-java/liquidjava/issues |
|
Pull requests
8
| https://github.com/liquid-java/liquidjava/pulls |
|
Actions
| https://github.com/liquid-java/liquidjava/actions |
|
Projects
| https://github.com/liquid-java/liquidjava/projects |
|
Security and quality
0
| https://github.com/liquid-java/liquidjava/security |
|
Insights
| https://github.com/liquid-java/liquidjava/pulse |
|
Code
| https://github.com/liquid-java/liquidjava |
|
Issues
| https://github.com/liquid-java/liquidjava/issues |
|
Pull requests
| https://github.com/liquid-java/liquidjava/pulls |
|
Actions
| https://github.com/liquid-java/liquidjava/actions |
|
Projects
| https://github.com/liquid-java/liquidjava/projects |
|
Security and quality
| https://github.com/liquid-java/liquidjava/security |
|
Insights
| https://github.com/liquid-java/liquidjava/pulse |
| rcosta358 | https://github.com/rcosta358 |
| main | https://github.com/liquid-java/liquidjava/tree/main |
| fix-vc-function-substitution | https://github.com/liquid-java/liquidjava/tree/fix-vc-function-substitution |
| Conversation | https://github.com/liquid-java/liquidjava/pull/267 |
| Commits5 (5) | https://github.com/liquid-java/liquidjava/pull/267/commits |
| Checks | https://github.com/liquid-java/liquidjava/pull/267/checks |
| Files changed | https://github.com/liquid-java/liquidjava/pull/267/files |
| Fix VC Function Substitution | https://github.com/liquid-java/liquidjava/pull/267#top |
| rcosta358 | https://github.com/rcosta358 |
| main | https://github.com/liquid-java/liquidjava/tree/main |
| fix-vc-function-substitution | https://github.com/liquid-java/liquidjava/tree/fix-vc-function-substitution |
|
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
| Jun 24, 2026 | https://github.com/liquid-java/liquidjava/pull/267#issue-4736026410 |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
| Jun 24, 2026 | https://github.com/liquid-java/liquidjava/pull/267#event-27151745518 |
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
|
bug
| https://github.com/liquid-java/liquidjava/issues?q=state%3Aopen%20label%3Abug |
|
simplification
| https://github.com/liquid-java/liquidjava/issues?q=state%3Aopen%20label%3Asimplification |
| Jun 24, 2026 | https://github.com/liquid-java/liquidjava/pull/267#event-27151745946 |
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
| force-pushed | https://github.com/liquid-java/liquidjava/compare/bdc9dad3eb39ecf9ba445de176b8c49ddd723b5d..2d2db905bdee472b9d61857eb06686f372dc4c91 |
| bdc9dad | https://github.com/liquid-java/liquidjava/commit/bdc9dad3eb39ecf9ba445de176b8c49ddd723b5d |
| 2d2db90 | https://github.com/liquid-java/liquidjava/commit/2d2db905bdee472b9d61857eb06686f372dc4c91 |
|
Compare
| https://github.com/liquid-java/liquidjava/compare/bdc9dad3eb39ecf9ba445de176b8c49ddd723b5d..2d2db905bdee472b9d61857eb06686f372dc4c91 |
| June 24, 2026 16:46 | https://github.com/liquid-java/liquidjava/pull/267#event-27156088683 |
| https://github.com/CatarinaGamboa |
| CatarinaGamboa | https://github.com/CatarinaGamboa |
|
Jun 24, 2026
| https://github.com/liquid-java/liquidjava/pull/267#pullrequestreview-4566044979 |
|
View reviewed changes
| https://github.com/liquid-java/liquidjava/pull/267/files |
| CatarinaGamboa | https://github.com/CatarinaGamboa |
| https://github.com/liquid-java/liquidjava/pull/267#pullrequestreview-4566044979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
| Jun 24, 2026 | https://github.com/liquid-java/liquidjava/pull/267#issuecomment-4793729100 |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| https://github.com/CatarinaGamboa |
| CatarinaGamboa | https://github.com/CatarinaGamboa |
|
Jul 20, 2026
| https://github.com/liquid-java/liquidjava/pull/267#pullrequestreview-4736716344 |
|
View reviewed changes
| https://github.com/liquid-java/liquidjava/pull/267/files |
| CatarinaGamboa | https://github.com/CatarinaGamboa |
| https://github.com/liquid-java/liquidjava/pull/267#pullrequestreview-4736716344 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| liquidjava-verifier/src/main/java/liquidjava/rj_language/opt/VCFunctionSubstitution.java | https://github.com/liquid-java/liquidjava/pull/267/files#diff-d183560cf349e515e132f2f14e9b6e9841da7afe63d511e98e9ea72a9f03113d |
| CatarinaGamboa | https://github.com/CatarinaGamboa |
| Jul 20, 2026 | https://github.com/liquid-java/liquidjava/pull/267#discussion_r3615733821 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| rcosta358 | https://github.com/rcosta358 |
| Jul 20, 2026 | https://github.com/liquid-java/liquidjava/pull/267#discussion_r3616273643 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| liquidjava-verifier/src/main/java/liquidjava/rj_language/opt/VCFunctionSubstitution.java | https://github.com/liquid-java/liquidjava/pull/267/files#diff-d183560cf349e515e132f2f14e9b6e9841da7afe63d511e98e9ea72a9f03113d |
| CatarinaGamboa | https://github.com/CatarinaGamboa |
| Jul 20, 2026 | https://github.com/liquid-java/liquidjava/pull/267#discussion_r3615760887 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| rcosta358 | https://github.com/rcosta358 |
| Jul 20, 2026 | https://github.com/liquid-java/liquidjava/pull/267#discussion_r3616299299 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| liquidjava-verifier/src/test/java/liquidjava/rj_language/opt/VCFunctionSubstitutionTest.java | https://github.com/liquid-java/liquidjava/pull/267/files#diff-774c3e9fde0f3e05a60f4a1551e1e748504a0e5713eafb29b09913d21aad3ab4 |
| CatarinaGamboa | https://github.com/CatarinaGamboa |
| Jul 20, 2026 | https://github.com/liquid-java/liquidjava/pull/267#discussion_r3615791742 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| rcosta358 | https://github.com/rcosta358 |
| Jul 20, 2026 | https://github.com/liquid-java/liquidjava/pull/267#discussion_r3616313121 |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
| July 20, 2026 17:56 | https://github.com/liquid-java/liquidjava/pull/267#event-28226979704 |
| rcosta358 | https://github.com/rcosta358 |
| July 20, 2026 18:57 | https://github.com/liquid-java/liquidjava/pull/267#commits-pushed-919a5b8 |
|
| https://github.com/rcosta358 |
| Fix VC Function Substitution | https://github.com/liquid-java/liquidjava/pull/267/commits/919a5b82ed77ecfa4a79eea1fc6affc1ce728dec |
| 919a5b8 | https://github.com/liquid-java/liquidjava/pull/267/commits/919a5b82ed77ecfa4a79eea1fc6affc1ce728dec |
|
| https://github.com/rcosta358 |
| Function Invocation Simple Name Workaround | https://github.com/liquid-java/liquidjava/pull/267/commits/5ec4cafd023683de8918a37453c8381aca7bf98d |
| 5ec4caf | https://github.com/liquid-java/liquidjava/pull/267/commits/5ec4cafd023683de8918a37453c8381aca7bf98d |
|
| https://github.com/rcosta358 |
| Remove Redundant If | https://github.com/liquid-java/liquidjava/pull/267/commits/585ba2ff9044f23fe6b4a8f9327e09437ede0d95 |
| 585ba2f | https://github.com/liquid-java/liquidjava/pull/267/commits/585ba2ff9044f23fe6b4a8f9327e09437ede0d95 |
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
| force-pushed | https://github.com/liquid-java/liquidjava/compare/4012d7e4c8f2b82ea5959a253959c7343db23f5f..585ba2ff9044f23fe6b4a8f9327e09437ede0d95 |
| 4012d7e | https://github.com/liquid-java/liquidjava/commit/4012d7e4c8f2b82ea5959a253959c7343db23f5f |
| 585ba2f | https://github.com/liquid-java/liquidjava/commit/585ba2ff9044f23fe6b4a8f9327e09437ede0d95 |
|
Compare
| https://github.com/liquid-java/liquidjava/compare/4012d7e4c8f2b82ea5959a253959c7343db23f5f..585ba2ff9044f23fe6b4a8f9327e09437ede0d95 |
| July 20, 2026 17:57 | https://github.com/liquid-java/liquidjava/pull/267#event-28227028307 |
| rcosta358 | https://github.com/rcosta358 |
| July 20, 2026 19:03 | https://github.com/liquid-java/liquidjava/pull/267#commits-pushed-271732e |
|
| https://github.com/rcosta358 |
| Renaming and JavaDoc | https://github.com/liquid-java/liquidjava/pull/267/commits/271732e7bda6a5ee758ecde33bc00fc7a67e1717 |
| 271732e | https://github.com/liquid-java/liquidjava/pull/267/commits/271732e7bda6a5ee758ecde33bc00fc7a67e1717 |
|
| https://github.com/rcosta358 |
| Remove Unnecessary Clones | https://github.com/liquid-java/liquidjava/pull/267/commits/1d9b4071b56546cbfc09e8a03f417aa06b0cb9e6 |
| 1d9b407 | https://github.com/liquid-java/liquidjava/pull/267/commits/1d9b4071b56546cbfc09e8a03f417aa06b0cb9e6 |
| https://github.com/rcosta358 |
| rcosta358 | https://github.com/rcosta358 |
| f3466c8 | https://github.com/liquid-java/liquidjava/commit/f3466c8e6a5d28e507e490f876a4d375b6090b50 |
| Jul 20, 2026 | https://github.com/liquid-java/liquidjava/pull/267#event-28227849642 |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
| https://github.co/hiddenchars |
| https://github.com/liquid-java/liquidjava/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fliquid-java%2Fliquidjava%2Fpull%2F267 |
|
| https://github.com/CatarinaGamboa |
|
CatarinaGamboa
| https://github.com/CatarinaGamboa |
|
| https://github.com/liquid-java/liquidjava/pull/267/files/2d2db905bdee472b9d61857eb06686f372dc4c91 |
|
| https://github.com/rcosta358 |
|
rcosta358
| https://github.com/rcosta358 |
|
bug
| https://github.com/liquid-java/liquidjava/issues?q=state%3Aopen%20label%3Abug |
|
simplification
| https://github.com/liquid-java/liquidjava/issues?q=state%3Aopen%20label%3Asimplification |
| Please reload this page | https://github.com/liquid-java/liquidjava/pull/267 |
|
| https://github.com/rcosta358 |
|
| https://github.com/CatarinaGamboa |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |