Title: Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown` · Issue #2193 · libgit2/libgit2sharp · GitHub
Open Graph Title: Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown` · Issue #2193 · libgit2/libgit2sharp
X Title: Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown` · Issue #2193 · libgit2/libgit2sharp
Description: Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Framework process exits crashes the process wit...
Open Graph Description: Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Framewo...
X Description: Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Fra...
Opengraph URL: https://github.com/libgit2/libgit2sharp/issues/2193
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown`","articleBody":"Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out.\n\nStarting with 0.31 (specifically #2127 - Use Safe Handles), a `Repository` that is still alive when a .NET Framework process exits crashes the process with an AccessViolation inside `git_repository_free` / `git_odb_free`:\n\n```\nntdll!RtlpWaitOnCriticalSection+0xa6 \u003c- DebugInfo == NULL: critical section already deleted\nntdll!RtlEnterCriticalSection+0x42\ngit2!\u003cmwindow.c static> \u003c- git_mwindow_put_pack / packfile free, global mwindow mutex\ngit2!\u003codb_pack.c static> \u003c- pack backend free\ngit2!git_odb_free+0x7a\ngit2!git_repository__cleanup / git_repository_free\nLibGit2Sharp.Core.Handles.RepositoryHandle.ReleaseHandle() (or ObjectDatabaseHandle.ReleaseHandle)\nSystem.Runtime.InteropServices.SafeHandle.Finalize()\nclr!FinalizerThread::FinalizeAllObjects \u003c- main thread is in clr!EEShutDown\n```\n\n`git_libgit2_shutdown` has already run from `NativeShutdownObject`'s finalizer and destroyed libgit2's global mutexes.\n\n## Root cause\n\n`NativeShutdownObject` derives from `CriticalFinalizerObject` **on purpose**: commit 247ca1a3 (2012, \"Make git_threads_shutdown run after git finalizers\") fixed this very crash by relying on the CLR guarantee that all normal finalizers run before any critical finalizer, so shutdown was always last.\n\n#2127 made `Libgit2Object` derive from `SafeHandleZeroOrMinusOneIsInvalid`. `SafeHandle` is itself a `CriticalFinalizerObject`, so every handle finalizer now runs in the same critical phase as the shutdown object, and the relative order is undefined (with server GC it depends on which heap each object was allocated on, so it is intermittent).\n\n## Repro (net472, server GC)\n\n`App.config` with `\u003cgcServer enabled=\"true\"/>`; open a repository on ~24 threads, read a few commits on each, keep the `Repository` objects alive in a static, return from `Main` without disposing. Crashes 10/10 on 0.32.0. With one extra `git_libgit2_init()` call (so the shutdown finalizer never reaches count 0) it passes 10/10.\n\n## Suggested fix\n\nNever tear the native library down from a finalizer at all. The finalizer-based shutdown only ever executes on .NET Framework (Core does not run finalizers at process exit), and there it is now actively harmful because SafeHandles are guaranteed to be finalized in the same phase. Options:\n\n1. Delete `NativeShutdownObject`; leave the process-lifetime `git_libgit2_init` reference outstanding (the OS reclaims everything at exit).\n2. Or keep it but make its finalizer a no-op when `AppDomain.CurrentDomain.IsFinalizingForUnload() || Environment.HasShutdownStarted`.\n\nWorkaround for consumers today: call the internal `NativeMethods.git_libgit2_init` once more via reflection so the refcount never drops to zero.\n","author":{"url":"https://github.com/KirillOsenkov","@type":"Person","name":"KirillOsenkov"},"datePublished":"2026-09-01T23:55:09Z","url":"https://github.com/libgit2/libgit2sharp/issues/2193"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ac4d1a10-64e8-4a86-818b-1c8637cdeb17 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CD50:20C5C5:78828:A64C7:6AFD5998 |
| html-safe-nonce | c28a8ba56382aafb93e5d5acde37546cdbdb6cbd6010082f732e3478d84e0fa9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDUwOjIwQzVDNTo3ODgyODpBNjRDNzo2QUZENTk5OCIsInZpc2l0b3JfaWQiOiI1Mjk1ODE3Mzg0OTc4NjM1MTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7878bc7fc1d8fa04fe0c5e3685c65cff3a94a994b091ddfd70e84867a77ac54a |
| hovercard-subject-tag | issue:5318076218 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/libgit2/libgit2sharp/2193/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5aaf0c4bd8b0e96152a138e2fa4759b70170ae9d0054b240c1d97fab946a537b/libgit2/libgit2sharp/issues/2193 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5aaf0c4bd8b0e96152a138e2fa4759b70170ae9d0054b240c1d97fab946a537b/libgit2/libgit2sharp/issues/2193 |
| og:image:alt | Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Framewo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | KirillOsenkov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e |
| turbo-cache-control | no-preview |
| go-import | github.com/libgit2/libgit2sharp git https://github.com/libgit2/libgit2sharp.git |
| octolytics-dimension-user_id | 394745 |
| octolytics-dimension-user_login | libgit2 |
| octolytics-dimension-repository_id | 1415168 |
| octolytics-dimension-repository_nwo | libgit2/libgit2sharp |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1415168 |
| octolytics-dimension-repository_network_root_nwo | libgit2/libgit2sharp |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b6f01f7cb9f35f8c09949773241a3d49dd04b340 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width