René's URL Explorer Experiment


Title: Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown` · Issue #2193 · libgit2/libgit2sharp · GitHub

Open Graph Title: Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown` · Issue #2193 · libgit2/libgit2sharp

X Title: Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown` · Issue #2193 · libgit2/libgit2sharp

Description: Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Framework process exits crashes the process wit...

Open Graph Description: Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Framewo...

X Description: Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Fra...

Opengraph URL: https://github.com/libgit2/libgit2sharp/issues/2193

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race `git_libgit2_shutdown`","articleBody":"Disclaimer: the below is AI-assisted but I'm reasonably confident it all checks out.\n\nStarting with 0.31 (specifically #2127 - Use Safe Handles), a `Repository` that is still alive when a .NET Framework process exits crashes the process with an AccessViolation inside `git_repository_free` / `git_odb_free`:\n\n```\nntdll!RtlpWaitOnCriticalSection+0xa6          \u003c- DebugInfo == NULL: critical section already deleted\nntdll!RtlEnterCriticalSection+0x42\ngit2!\u003cmwindow.c static>                        \u003c- git_mwindow_put_pack / packfile free, global mwindow mutex\ngit2!\u003codb_pack.c static>                       \u003c- pack backend free\ngit2!git_odb_free+0x7a\ngit2!git_repository__cleanup / git_repository_free\nLibGit2Sharp.Core.Handles.RepositoryHandle.ReleaseHandle()   (or ObjectDatabaseHandle.ReleaseHandle)\nSystem.Runtime.InteropServices.SafeHandle.Finalize()\nclr!FinalizerThread::FinalizeAllObjects       \u003c- main thread is in clr!EEShutDown\n```\n\n`git_libgit2_shutdown` has already run from `NativeShutdownObject`'s finalizer and destroyed libgit2's global mutexes.\n\n## Root cause\n\n`NativeShutdownObject` derives from `CriticalFinalizerObject` **on purpose**: commit 247ca1a3 (2012, \"Make git_threads_shutdown run after git finalizers\") fixed this very crash by relying on the CLR guarantee that all normal finalizers run before any critical finalizer, so shutdown was always last.\n\n#2127 made `Libgit2Object` derive from `SafeHandleZeroOrMinusOneIsInvalid`. `SafeHandle` is itself a `CriticalFinalizerObject`, so every handle finalizer now runs in the same critical phase as the shutdown object, and the relative order is undefined (with server GC it depends on which heap each object was allocated on, so it is intermittent).\n\n## Repro (net472, server GC)\n\n`App.config` with `\u003cgcServer enabled=\"true\"/>`; open a repository on ~24 threads, read a few commits on each, keep the `Repository` objects alive in a static, return from `Main` without disposing. Crashes 10/10 on 0.32.0. With one extra `git_libgit2_init()` call (so the shutdown finalizer never reaches count 0) it passes 10/10.\n\n## Suggested fix\n\nNever tear the native library down from a finalizer at all. The finalizer-based shutdown only ever executes on .NET Framework (Core does not run finalizers at process exit), and there it is now actively harmful because SafeHandles are guaranteed to be finalized in the same phase. Options:\n\n1. Delete `NativeShutdownObject`; leave the process-lifetime `git_libgit2_init` reference outstanding (the OS reclaims everything at exit).\n2. Or keep it but make its finalizer a no-op when `AppDomain.CurrentDomain.IsFinalizingForUnload() || Environment.HasShutdownStarted`.\n\nWorkaround for consumers today: call the internal `NativeMethods.git_libgit2_init` once more via reflection so the refcount never drops to zero.\n","author":{"url":"https://github.com/KirillOsenkov","@type":"Person","name":"KirillOsenkov"},"datePublished":"2026-09-01T23:55:09Z","url":"https://github.com/libgit2/libgit2sharp/issues/2193"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ac4d1a10-64e8-4a86-818b-1c8637cdeb17
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCD50:20C5C5:78828:A64C7:6AFD5998
html-safe-noncec28a8ba56382aafb93e5d5acde37546cdbdb6cbd6010082f732e3478d84e0fa9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDUwOjIwQzVDNTo3ODgyODpBNjRDNzo2QUZENTk5OCIsInZpc2l0b3JfaWQiOiI1Mjk1ODE3Mzg0OTc4NjM1MTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7878bc7fc1d8fa04fe0c5e3685c65cff3a94a994b091ddfd70e84867a77ac54a
hovercard-subject-tagissue:5318076218
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/libgit2/libgit2sharp/2193/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5aaf0c4bd8b0e96152a138e2fa4759b70170ae9d0054b240c1d97fab946a537b/libgit2/libgit2sharp/issues/2193
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5aaf0c4bd8b0e96152a138e2fa4759b70170ae9d0054b240c1d97fab946a537b/libgit2/libgit2sharp/issues/2193
og:image:altDisclaimer: the below is AI-assisted but I'm reasonably confident it all checks out. Starting with 0.31 (specifically #2127 - Use Safe Handles), a Repository that is still alive when a .NET Framewo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKirillOsenkov
hostnamegithub.com
expected-hostnamegithub.com
None66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e
turbo-cache-controlno-preview
go-importgithub.com/libgit2/libgit2sharp git https://github.com/libgit2/libgit2sharp.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id1415168
octolytics-dimension-repository_nwolibgit2/libgit2sharp
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1415168
octolytics-dimension-repository_network_root_nwolibgit2/libgit2sharp
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb6f01f7cb9f35f8c09949773241a3d49dd04b340
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/libgit2/libgit2sharp/issues/2193#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2sharp%2Fissues%2F2193
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2sharp%2Fissues%2F2193
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=libgit2%2Flibgit2sharp
Reloadhttps://github.com/libgit2/libgit2sharp/issues/2193
Reloadhttps://github.com/libgit2/libgit2sharp/issues/2193
Reloadhttps://github.com/libgit2/libgit2sharp/issues/2193
libgit2https://github.com/libgit2
libgit2sharphttps://github.com/libgit2/libgit2sharp
Codehttps://github.com/libgit2/libgit2sharp
Issues406 (406)https://github.com/libgit2/libgit2sharp/issues
Pull requests54 (54)https://github.com/libgit2/libgit2sharp/pulls
Actionshttps://github.com/libgit2/libgit2sharp/actions
Projectshttps://github.com/libgit2/libgit2sharp/projects
Wikihttps://github.com/libgit2/libgit2sharp/wiki
Security and qualityhttps://github.com/libgit2/libgit2sharp/security
Insightshttps://github.com/libgit2/libgit2sharp/insights
https://github.com/libgit2/libgit2sharp
New issuehttps://github.com/login?return_to=https://github.com/libgit2/libgit2sharp/issues/2193
New issuehttps://github.com/login?return_to=https://github.com/libgit2/libgit2sharp/issues/2193
Potential AccessViolation at process exit on .NET Framework - SafeHandle finalizers now race git_libgit2_shutdownhttps://github.com/libgit2/libgit2sharp/issues/2193#top
https://github.com/KirillOsenkov
KirillOsenkovhttps://github.com/KirillOsenkov
on Sep 1, 2026https://github.com/libgit2/libgit2sharp/issues/2193#issue-5318076218
#2127https://github.com/libgit2/libgit2sharp/pull/2127
247ca1ahttps://github.com/libgit2/libgit2sharp/commit/247ca1a30cfb722b74ada4288bcca7293f59b87b
#2127https://github.com/libgit2/libgit2sharp/pull/2127
https://github.com/KirillOsenkov
KirillOsenkovhttps://github.com/KirillOsenkov
on Sep 2, 2026https://github.com/libgit2/libgit2sharp/issues/2193#issuecomment-5502349793
https://github.com/bording
bordinghttps://github.com/bording
on Sep 2, 2026https://github.com/libgit2/libgit2sharp/issues/2193#issuecomment-5502440421
@ethomsonhttps://github.com/ethomson
@ethomsonhttps://github.com/ethomson
https://github.com/IanKemp
IanKemphttps://github.com/IanKemp
on Sep 30, 2026https://github.com/libgit2/libgit2sharp/issues/2193#issuecomment-5909136343
https://github.com/miloush
miloushhttps://github.com/miloush
on Sep 30, 2026https://github.com/libgit2/libgit2sharp/issues/2193#issuecomment-5912465136
supportedhttps://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-framework
@ethomsonhttps://github.com/ethomson
https://github.com/ChrSchu90
ChrSchu90https://github.com/ChrSchu90
on Oct 7, 2026https://github.com/libgit2/libgit2sharp/issues/2193#issuecomment-6033227031
Sign up for freehttps://github.com/signup?return_to=https://github.com/libgit2/libgit2sharp/issues/2193
Sign in to commenthttps://github.com/login?return_to=https://github.com/libgit2/libgit2sharp/issues/2193
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.