René's URL Explorer Experiment


Title: stream: fix potentially truncated writes by pks-t · Pull Request #4953 · libgit2/libgit2 · GitHub

Open Graph Title: stream: fix potentially truncated writes by pks-t · Pull Request #4953 · libgit2/libgit2

X Title: stream: fix potentially truncated writes by pks-t · Pull Request #4953 · libgit2/libgit2

Description: A cross-platform, linkable library implementation of Git that you can use in your application. - stream: fix potentially truncated writes by pks-t · Pull Request #4953 · libgit2/libgit2

Open Graph Description: This builds on parts of #4950 and extends it to fix the potential for partial writes in our stream implementation.

X Description: This builds on parts of #4950 and extends it to fix the potential for partial writes in our stream implementation.

Opengraph URL: https://github.com/libgit2/libgit2/pull/4953

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:823eee8f-c8e7-75c8-18a1-2d2804133b4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE380:269996:8CA20AD:BF8AEDF:6A5E995E
html-safe-noncedbda80c40209b64fd2bc87e9ce5b3755a2baaa511e36e456646d2eb63c34c046
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzgwOjI2OTk5Njo4Q0EyMEFEOkJGOEFFREY6NkE1RTk5NUUiLCJ2aXNpdG9yX2lkIjoiMTMwOTMwMjkwNjMxNjI5ODU5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1b92226661223bb6243300128005a49fc7be4b1db49b0bd6f05d09d013a8adc
hovercard-subject-tagpull_request:246985889
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/libgit2/libgit2/4953/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6b15f0efe33e901e5da49984da0ac335edb8e1ae4601b5cfbcbbb7e97082d60c/libgit2/libgit2/pull/4953
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6b15f0efe33e901e5da49984da0ac335edb8e1ae4601b5cfbcbbb7e97082d60c/libgit2/libgit2/pull/4953
og:image:altThis builds on parts of #4950 and extends it to fix the potential for partial writes in our stream implementation.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepks-t
hostnamegithub.com
expected-hostnamegithub.com
None7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d
turbo-cache-controlno-cache
go-importgithub.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id901662
octolytics-dimension-repository_nwolibgit2/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d2ac9bdd71d5f53f2b731c9330677e38624e301
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/libgit2/libgit2/pull/4953#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4953
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4953
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=libgit2%2Flibgit2
Reloadhttps://github.com/libgit2/libgit2/pull/4953
Reloadhttps://github.com/libgit2/libgit2/pull/4953
Reloadhttps://github.com/libgit2/libgit2/pull/4953
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
libgit2 https://github.com/libgit2
libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Fork 2.6k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Star 10.5k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Code https://github.com/libgit2/libgit2
Issues 423 https://github.com/libgit2/libgit2/issues
Pull requests 110 https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality 9 https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Code https://github.com/libgit2/libgit2
Issues https://github.com/libgit2/libgit2/issues
Pull requests https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
pks-thttps://github.com/pks-t
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
pks-t:pks/stream-truncated-writeshttps://github.com/pks-t/libgit2/tree/pks/stream-truncated-writes
Conversationhttps://github.com/libgit2/libgit2/pull/4953
Commits8 (8)https://github.com/libgit2/libgit2/pull/4953/commits
Checkshttps://github.com/libgit2/libgit2/pull/4953/checks
Files changedhttps://github.com/libgit2/libgit2/pull/4953/files
stream: fix potentially truncated writeshttps://github.com/libgit2/libgit2/pull/4953#top
pks-thttps://github.com/pks-t
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
pks-t:pks/stream-truncated-writeshttps://github.com/pks-t/libgit2/tree/pks/stream-truncated-writes
https://github.com/pks-t
pks-thttps://github.com/pks-t
Jan 23, 2019https://github.com/libgit2/libgit2/pull/4953#issue-402262129
#4950https://github.com/libgit2/libgit2/pull/4950
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/pks-t
pks-thttps://github.com/pks-t
Jan 23, 2019 https://github.com/libgit2/libgit2/pull/4953#ref-pullrequest-401137026
Clean up some warnings #4950 https://github.com/libgit2/libgit2/pull/4950
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 23, 2019 https://github.com/libgit2/libgit2/pull/4953#pullrequestreview-195560178
View reviewed changes https://github.com/libgit2/libgit2/pull/4953/files
src/stream.hhttps://github.com/libgit2/libgit2/pull/4953/files#diff-678038b2c26e76e42ea7df960f973230e4117fa758be5c16a800f41c20fa42ab
ethomsonhttps://github.com/ethomson
Jan 23, 2019https://github.com/libgit2/libgit2/pull/4953#discussion_r250226190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
pks-thttps://github.com/pks-t
Jan 23, 2019https://github.com/libgit2/libgit2/pull/4953#discussion_r250233145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
ethomsonhttps://github.com/ethomson
Jan 23, 2019https://github.com/libgit2/libgit2/pull/4953#discussion_r250234173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/neithernut
neithernuthttps://github.com/neithernut
Jan 23, 2019 https://github.com/libgit2/libgit2/pull/4953#pullrequestreview-195565348
View reviewed changes https://github.com/libgit2/libgit2/pull/4953/files
src/streams/socket.chttps://github.com/libgit2/libgit2/pull/4953/files#diff-df4acf397a2b566070ce49c7c46fd03a5547ac29cafbadb57cee5d06b66bf097
neithernuthttps://github.com/neithernut
Jan 23, 2019https://github.com/libgit2/libgit2/pull/4953#discussion_r250230129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
pks-thttps://github.com/pks-t
Jan 23, 2019https://github.com/libgit2/libgit2/pull/4953#discussion_r250231334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ethomsonhttps://github.com/ethomson
#4950https://github.com/libgit2/libgit2/pull/4950
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
pks-thttps://github.com/pks-t
Jan 23, 2019https://github.com/libgit2/libgit2/pull/4953#discussion_r250233588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/pks-t
pks-thttps://github.com/pks-t
force-pushedhttps://github.com/libgit2/libgit2/compare/1a6302112ad23f2a6061d8e5f59ee3d34e5d3d13..b52c2abac480260c5203cb322a0a942b42e5c46f
1a63021https://github.com/libgit2/libgit2/commit/1a6302112ad23f2a6061d8e5f59ee3d34e5d3d13
b52c2abhttps://github.com/libgit2/libgit2/commit/b52c2abac480260c5203cb322a0a942b42e5c46f
Compare https://github.com/libgit2/libgit2/compare/1a6302112ad23f2a6061d8e5f59ee3d34e5d3d13..b52c2abac480260c5203cb322a0a942b42e5c46f
January 23, 2019 15:08https://github.com/libgit2/libgit2/pull/4953#event-2091915774
ethomsonhttps://github.com/ethomson
January 23, 2019 16:08https://github.com/libgit2/libgit2/pull/4953#commits-pushed-2bcfa96
https://github.com/ethomson
https://github.com/pks-t
windows: add SSIZE_MAXhttps://github.com/libgit2/libgit2/pull/4953/commits/2bcfa967749e76e9748fbfd16746f21ca4681aea
2bcfa96https://github.com/libgit2/libgit2/pull/4953/commits/2bcfa967749e76e9748fbfd16746f21ca4681aea
https://github.com/pks-t
streams: make file-local functions statichttps://github.com/libgit2/libgit2/pull/4953/commits/1c64b5d634b326ab2ceaec03f5e4a2b401346e67
1c64b5dhttps://github.com/libgit2/libgit2/pull/4953/commits/1c64b5d634b326ab2ceaec03f5e4a2b401346e67
https://github.com/pks-t
streams: fix callers potentially only writing partial datahttps://github.com/libgit2/libgit2/pull/4953/commits/87405a61297f5651b4894b7b63cb29fc00a61322
87405a6https://github.com/libgit2/libgit2/pull/4953/commits/87405a61297f5651b4894b7b63cb29fc00a61322
https://github.com/pks-t
streams: handle short writes only in generic streamhttps://github.com/libgit2/libgit2/pull/4953/commits/d71195a432f892d7e59785576866d7db9fdb49d7
d71195ahttps://github.com/libgit2/libgit2/pull/4953/commits/d71195a432f892d7e59785576866d7db9fdb49d7
https://github.com/pks-t
openssl: fix potential size overflow when writing datahttps://github.com/libgit2/libgit2/pull/4953/commits/596ca54f49dc0d47e29265217cfec437f704b8f9
596ca54https://github.com/libgit2/libgit2/pull/4953/commits/596ca54f49dc0d47e29265217cfec437f704b8f9
https://github.com/pks-t
stransport: fix potential size overflow when writing datahttps://github.com/libgit2/libgit2/pull/4953/commits/afd07b9ffabe3c639507345e96ab52caafb65fe8
afd07b9https://github.com/libgit2/libgit2/pull/4953/commits/afd07b9ffabe3c639507345e96ab52caafb65fe8
https://github.com/pks-t
mbedtls: make global variables statichttps://github.com/libgit2/libgit2/pull/4953/commits/72f72fd3fede91106f65916ef16d641dbbfcec66
72f72fdhttps://github.com/libgit2/libgit2/pull/4953/commits/72f72fd3fede91106f65916ef16d641dbbfcec66
https://github.com/pks-t
mbedtls: fix potential size overflow when reading or writing datahttps://github.com/libgit2/libgit2/pull/4953/commits/b52c2abac480260c5203cb322a0a942b42e5c46f
b52c2abhttps://github.com/libgit2/libgit2/pull/4953/commits/b52c2abac480260c5203cb322a0a942b42e5c46f
https://github.com/pks-t
pks-thttps://github.com/pks-t
Jan 24, 2019 https://github.com/libgit2/libgit2/pull/4953#ref-pullrequest-402442800
Documentation fixes #4954 https://github.com/libgit2/libgit2/pull/4954
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 25, 2019 https://github.com/libgit2/libgit2/pull/4953#pullrequestreview-196465381
View reviewed changes https://github.com/libgit2/libgit2/pull/4953/files/b52c2abac480260c5203cb322a0a942b42e5c46f
src/streams/mbedtls.chttps://github.com/libgit2/libgit2/pull/4953/files/b52c2abac480260c5203cb322a0a942b42e5c46f#diff-4d48e7000166f06106fe1f79dd13ba5d152a385c2080afd13ddb4436530a1e0c
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 25, 2019https://github.com/libgit2/libgit2/pull/4953#issuecomment-457557530
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
next release https://github.com/libgit2/libgit2/issues?q=state%3Aopen%20label%3A%22next%20release%22
Jan 25, 2019https://github.com/libgit2/libgit2/pull/4953#event-2098374423
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 26, 2019https://github.com/libgit2/libgit2/pull/4953#issuecomment-457859462
#4950https://github.com/libgit2/libgit2/pull/4950
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 31, 2019https://github.com/libgit2/libgit2/pull/4953#issuecomment-459370649
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 31, 2019https://github.com/libgit2/libgit2/pull/4953#issuecomment-459370718
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 31, 2019https://github.com/libgit2/libgit2/pull/4953#event-2109617141
https://github.com/pks-t
pks-thttps://github.com/pks-t
February 7, 2019 11:28https://github.com/libgit2/libgit2/pull/4953#event-2123784662
https://github.com/pks-t
pks-thttps://github.com/pks-t
Feb 7, 2019https://github.com/libgit2/libgit2/pull/4953#issuecomment-461382530
@ethomsonhttps://github.com/ethomson
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4953
https://github.com/ethomson
ethomson https://github.com/ethomson
https://github.com/libgit2/libgit2/pull/4953/files/b52c2abac480260c5203cb322a0a942b42e5c46f
https://github.com/neithernut
neithernut https://github.com/neithernut
https://github.com/libgit2/libgit2/pull/4953/files/25cead238dff6065fac59caad9e94529f6b2a95f
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4953
https://github.com/pks-t
https://github.com/ethomson
https://github.com/neithernut
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.