René's URL Explorer Experiment


Title: Make ENABLE_WERROR actually work by lhchavez · Pull Request #4924 · libgit2/libgit2 · GitHub

Open Graph Title: Make ENABLE_WERROR actually work by lhchavez · Pull Request #4924 · libgit2/libgit2

X Title: Make ENABLE_WERROR actually work by lhchavez · Pull Request #4924 · libgit2/libgit2

Description: A cross-platform, linkable library implementation of Git that you can use in your application. - Make ENABLE_WERROR actually work by lhchavez · Pull Request #4924 · libgit2/libgit2

Open Graph Description: This change explicitly adds -Werror to the CFLAGS. Due to the way that the ADD_C_FLAG_IF_SUPPORTED() macro was mangling the flag name to convert it into a define name, any warning that had a dash i...

X Description: This change explicitly adds -Werror to the CFLAGS. Due to the way that the ADD_C_FLAG_IF_SUPPORTED() macro was mangling the flag name to convert it into a define name, any warning that had a dash i...

Opengraph URL: https://github.com/libgit2/libgit2/pull/4924

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e739571e-5ce4-9e5f-294a-411187fcb212
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1B0:1FC015:96066B:CB6080:6A5CE2C7
html-safe-noncef4c9c9a7265b70d4b8def3e8e4d0bbd0a97eb9eaea25b095b74a5ff646f8ad2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUIwOjFGQzAxNTo5NjA2NkI6Q0I2MDgwOjZBNUNFMkM3IiwidmlzaXRvcl9pZCI6Ijc1NDk3MDY3MzQ2MDI2MDkzNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacba5602b47f51ef3bc20399f7e89dc7b94e1f11af5ee94059d97cb74dfd182843
hovercard-subject-tagpull_request:242476004
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/libgit2/libgit2/4924/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/062dafc97f023e03a17a44ef19417ca965d0717f4f746d923bf1a4f35ea35f7b/libgit2/libgit2/pull/4924
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/062dafc97f023e03a17a44ef19417ca965d0717f4f746d923bf1a4f35ea35f7b/libgit2/libgit2/pull/4924
og:image:altThis change explicitly adds -Werror to the CFLAGS. Due to the way that the ADD_C_FLAG_IF_SUPPORTED() macro was mangling the flag name to convert it into a define name, any warning that had a dash i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelhchavez
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id901662
octolytics-dimension-repository_nwolibgit2/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/libgit2/libgit2/pull/4924#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4924
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4924
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=libgit2%2Flibgit2
Reloadhttps://github.com/libgit2/libgit2/pull/4924
Reloadhttps://github.com/libgit2/libgit2/pull/4924
Reloadhttps://github.com/libgit2/libgit2/pull/4924
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
libgit2 https://github.com/libgit2
libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Fork 2.6k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Star 10.5k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Code https://github.com/libgit2/libgit2
Issues 421 https://github.com/libgit2/libgit2/issues
Pull requests 107 https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality 9 https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Code https://github.com/libgit2/libgit2
Issues https://github.com/libgit2/libgit2/issues
Pull requests https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
ethomsonhttps://github.com/ethomson
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
lhchavez:werrorhttps://github.com/lhchavez/libgit2/tree/werror
Conversationhttps://github.com/libgit2/libgit2/pull/4924
Commits1 (1)https://github.com/libgit2/libgit2/pull/4924/commits
Checkshttps://github.com/libgit2/libgit2/pull/4924/checks
Files changedhttps://github.com/libgit2/libgit2/pull/4924/files
Make ENABLE_WERROR actually workhttps://github.com/libgit2/libgit2/pull/4924#top
ethomsonhttps://github.com/ethomson
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
lhchavez:werrorhttps://github.com/lhchavez/libgit2/tree/werror
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
Jan 6, 2019https://github.com/libgit2/libgit2/pull/4924#issue-396228295
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 8, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452323940
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
next release https://github.com/libgit2/libgit2/issues?q=state%3Aopen%20label%3A%22next%20release%22
Jan 8, 2019https://github.com/libgit2/libgit2/pull/4924#event-2060398846
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 8, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452328159
@pks-thttps://github.com/pks-t
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452524086
libgit2/CMakeLists.txthttps://github.com/libgit2/libgit2/blob/274a37fc78c4387e5902399600f3df85dbccbc25/CMakeLists.txt#L201-L202
274a37fhttps://github.com/libgit2/libgit2/commit/274a37fc78c4387e5902399600f3df85dbccbc25
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452524470
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
force-pushedhttps://github.com/libgit2/libgit2/compare/274a37fc78c4387e5902399600f3df85dbccbc25..6d6169314a1e49e6f052779d3e52da332ef23ee9
274a37fhttps://github.com/libgit2/libgit2/commit/274a37fc78c4387e5902399600f3df85dbccbc25
6d61693https://github.com/libgit2/libgit2/commit/6d6169314a1e49e6f052779d3e52da332ef23ee9
Compare https://github.com/libgit2/libgit2/compare/274a37fc78c4387e5902399600f3df85dbccbc25..6d6169314a1e49e6f052779d3e52da332ef23ee9
January 9, 2019 01:28https://github.com/libgit2/libgit2/pull/4924#event-2061826043
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452525396
#4928https://github.com/libgit2/libgit2/pull/4928
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452607543
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452640616
it was very explicithttps://github.com/libgit2/libgit2/commit/175ab8e7653778c3ef7c805696c8a63d0023c727
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452640787
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/neithernut
neithernuthttps://github.com/neithernut
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452643769
it was very explicithttps://github.com/libgit2/libgit2/commit/175ab8e7653778c3ef7c805696c8a63d0023c727
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452651401
go through the warnings that we enablehttps://github.com/libgit2/libgit2/blob/6d6169314a1e49e6f052779d3e52da332ef23ee9/CMakeLists.txt#L225-L236
append =errorhttps://github.com/libgit2/libgit2/blob/e6cdd17c846648aa8e1e025fa1988475886a551e/cmake/Modules/EnableWarnings.cmake
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
Jan 9, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452719810
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
force-pushedhttps://github.com/libgit2/libgit2/compare/6d6169314a1e49e6f052779d3e52da332ef23ee9..90a40e8a3b48c24424ae5dbbd7f285a6a6837734
6d61693https://github.com/libgit2/libgit2/commit/6d6169314a1e49e6f052779d3e52da332ef23ee9
90a40e8https://github.com/libgit2/libgit2/commit/90a40e8a3b48c24424ae5dbbd7f285a6a6837734
Compare https://github.com/libgit2/libgit2/compare/6d6169314a1e49e6f052779d3e52da332ef23ee9..90a40e8a3b48c24424ae5dbbd7f285a6a6837734
January 10, 2019 01:55https://github.com/libgit2/libgit2/pull/4924#event-2064744433
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
Jan 10, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-452941849
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/tiennou
tiennouhttps://github.com/tiennou
Jan 10, 2019 https://github.com/libgit2/libgit2/pull/4924#pullrequestreview-191195263
View reviewed changes https://github.com/libgit2/libgit2/pull/4924/files
cmake/Modules/AddCFlagIfSupported.cmakehttps://github.com/libgit2/libgit2/pull/4924/files#diff-96fa5058735c7c727ee41291dc292c2d67033c8f94b55e301928498dfc90e754
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
Make ENABLE_WERROR actually workhttps://github.com/libgit2/libgit2/pull/4924/commits/6af6170b684d9ba29d01d1075d22c5530664a6d5
6af6170https://github.com/libgit2/libgit2/pull/4924/commits/6af6170b684d9ba29d01d1075d22c5530664a6d5
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
force-pushedhttps://github.com/libgit2/libgit2/compare/90a40e8a3b48c24424ae5dbbd7f285a6a6837734..6af6170b684d9ba29d01d1075d22c5530664a6d5
90a40e8https://github.com/libgit2/libgit2/commit/90a40e8a3b48c24424ae5dbbd7f285a6a6837734
6af6170https://github.com/libgit2/libgit2/commit/6af6170b684d9ba29d01d1075d22c5530664a6d5
Compare https://github.com/libgit2/libgit2/compare/90a40e8a3b48c24424ae5dbbd7f285a6a6837734..6af6170b684d9ba29d01d1075d22c5530664a6d5
January 10, 2019 14:05https://github.com/libgit2/libgit2/pull/4924#event-2065944796
https://github.com/tiennou
tiennouhttps://github.com/tiennou
Jan 10, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-453142061
@lhchavezhttps://github.com/lhchavez
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/tiennou
tiennouhttps://github.com/tiennou
Jan 10, 2019 https://github.com/libgit2/libgit2/pull/4924#ref-pullrequest-397897845
Remove unconditional -Wno-deprecated-declaration on macOS #4931 https://github.com/libgit2/libgit2/pull/4931
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jan 10, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-453263644
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
99afd41https://github.com/libgit2/libgit2/commit/99afd41f1c43c856d39e3b9572d7a2103875a771
Jan 10, 2019https://github.com/libgit2/libgit2/pull/4924#event-2067049855
https://github.com/pks-t
pks-thttps://github.com/pks-t
Jan 21, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-456048075
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/pks-t
pks-thttps://github.com/pks-t
Jan 21, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-456050864
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
January 21, 2019 17:39https://github.com/libgit2/libgit2/pull/4924#event-2086993682
https://github.com/lhchavez
lhchavezhttps://github.com/lhchavez
Jan 21, 2019https://github.com/libgit2/libgit2/pull/4924#issuecomment-456152343
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Feb 23, 2020 https://github.com/libgit2/libgit2/pull/4924#ref-pullrequest-569442418
[Snyk] Upgrade nodegit from 0.4.1 to 0.26.4 saurabharch/Breezeblocks#1 https://github.com/saurabharch/Breezeblocks/pull/1
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 22, 2020 https://github.com/libgit2/libgit2/pull/4924#ref-pullrequest-604472000
[Snyk] Upgrade nodegit from 0.24.3 to 0.26.5 aminatakonate000/Graviton-App#4 https://github.com/aminatakonate000/Graviton-App/pull/4
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
May 5, 2020 https://github.com/libgit2/libgit2/pull/4924#ref-pullrequest-612362441
[Snyk] Upgrade nodegit from 0.24.3 to 0.26.5 Barnstorm-Online/ngp-openapi-generator#1 https://github.com/Barnstorm-Online/ngp-openapi-generator/pull/1
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4924
https://github.com/tiennou
tiennou https://github.com/tiennou
https://github.com/libgit2/libgit2/pull/4924/files/90a40e8a3b48c24424ae5dbbd7f285a6a6837734
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4924
https://github.com/lhchavez
https://github.com/ethomson
https://github.com/neithernut
https://github.com/tiennou
https://github.com/pks-t
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.