René's URL Explorer Experiment


Title: Allow certificate and credential callbacks to decline to act by ethomson · Pull Request #4879 · libgit2/libgit2 · GitHub

Open Graph Title: Allow certificate and credential callbacks to decline to act by ethomson · Pull Request #4879 · libgit2/libgit2

X Title: Allow certificate and credential callbacks to decline to act by ethomson · Pull Request #4879 · libgit2/libgit2

Description: Custom transports may want to ask libgit2 to invoke a configured credential or certificate callback; however they likely do not know if a callback was actually configured. Return a sentinal value (greater than zero) if there is no callback configured instead of crashing. With this, we want to define what > 0 means for these callbacks, because they themselves might return it. Credential callbacks are already defined to return > 0 to defer these checks, but they were only inconsistently implemented (winhttp supported this, http and ssh transports did not). Add this support consistently to all transports for both credential callbacks and certificate checking.

Open Graph Description: Custom transports may want to ask libgit2 to invoke a configured credential or certificate callback; however they likely do not know if a callback was actually configured. Return a sentinal value ...

X Description: Custom transports may want to ask libgit2 to invoke a configured credential or certificate callback; however they likely do not know if a callback was actually configured. Return a sentinal value ...

Opengraph URL: https://github.com/libgit2/libgit2/pull/4879

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:be5011ba-5d72-1807-e4cf-839a4741be72
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8376:2F3AB6:5047E24:69A57F2:6A5D8D71
html-safe-noncef07f23b18cc4d5c2d67b0dea6d5069c4f736b920fa9f552314d1a378ae142d48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Mzc2OjJGM0FCNjo1MDQ3RTI0OjY5QTU3RjI6NkE1RDhENzEiLCJ2aXNpdG9yX2lkIjoiOTE4MTgwNjAzMjM0MzM3MTEyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8fa078adafbb645b684fa9d9a88922911280b0a913631b1b168137823f17cec4
hovercard-subject-tagpull_request:228708890
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/libgit2/libgit2/pull/4879/files
twitter:imagehttps://avatars.githubusercontent.com/u/1130014?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1130014?s=400&v=4
og:image:altCustom transports may want to ask libgit2 to invoke a configured credential or certificate callback; however they likely do not know if a callback was actually configured. Return a sentinal value ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id901662
octolytics-dimension-repository_nwolibgit2/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/libgit2/libgit2/pull/4879/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4879%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4879%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=libgit2%2Flibgit2
Reloadhttps://github.com/libgit2/libgit2/pull/4879/files
Reloadhttps://github.com/libgit2/libgit2/pull/4879/files
Reloadhttps://github.com/libgit2/libgit2/pull/4879/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4879/files
libgit2 https://github.com/libgit2
libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Fork 2.6k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Star 10.5k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Code https://github.com/libgit2/libgit2
Issues 423 https://github.com/libgit2/libgit2/issues
Pull requests 108 https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality 9 https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Code https://github.com/libgit2/libgit2
Issues https://github.com/libgit2/libgit2/issues
Pull requests https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Flibgit2%2Flibgit2%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Flibgit2%2Flibgit2%2Fissues%2Fnew%2Fchoose
pks-thttps://github.com/pks-t
masterhttps://github.com/libgit2/libgit2/tree/master
ethomson/defer_cert_cred_cbhttps://github.com/libgit2/libgit2/tree/ethomson/defer_cert_cred_cb
Conversation 8 https://github.com/libgit2/libgit2/pull/4879
Commits 2 https://github.com/libgit2/libgit2/pull/4879/commits
Checks 0 https://github.com/libgit2/libgit2/pull/4879/checks
Files changed https://github.com/libgit2/libgit2/pull/4879/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4879/files
Allow certificate and credential callbacks to decline to act https://github.com/libgit2/libgit2/pull/4879/files#top
Show all changes 2 commits https://github.com/libgit2/libgit2/pull/4879/files
8ee1009 transport: see if cert/cred callbacks exist before calling them ethomson Nov 6, 2018 https://github.com/libgit2/libgit2/pull/4879/commits/8ee1009874d11a61ccd4b89322432c3633b4cc1f
a2e6e0e transport: allow cred/cert callbacks to return GIT_PASSTHROUGH ethomson Nov 6, 2018 https://github.com/libgit2/libgit2/pull/4879/commits/a2e6e0ea0e947954836b27572e753c7f95e5a1f4
Clear filters https://github.com/libgit2/libgit2/pull/4879/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4879/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4879/files
errors.h https://github.com/libgit2/libgit2/pull/4879/files#diff-16ce4ba357b7e6949a83661245088374fd581421b567a4780a98d17f682e72d4
transport.h https://github.com/libgit2/libgit2/pull/4879/files#diff-189a3134cac2b108f2143533cd586ad8c6a7a326593b9103c0a62b79ed2230be
types.h https://github.com/libgit2/libgit2/pull/4879/files#diff-96e375df61a17f8d6149856200c0949f7fa107ebaf7c2605094a93998632db84
http.c https://github.com/libgit2/libgit2/pull/4879/files#diff-4ae32386cf6a4e831b232c50f549e48d44adfa7a63a4aa0a436a6b43cf278ba9
smart.c https://github.com/libgit2/libgit2/pull/4879/files#diff-88455053c1ba4d5a2d5b80e23f6dbb95b3d59ca9f71e4f84c09a2b3b003ead6a
ssh.c https://github.com/libgit2/libgit2/pull/4879/files#diff-38bd676aed1cb7cffb3d148175dacb0bb4752244457b9468a9c277315b3b1b99
winhttp.c https://github.com/libgit2/libgit2/pull/4879/files#diff-a73ee15948b6492f83f9d6c64fb061c7a8a4dd5072f5a693e23060ac8971723b
include/git2/errors.hhttps://github.com/libgit2/libgit2/pull/4879/files#diff-16ce4ba357b7e6949a83661245088374fd581421b567a4780a98d17f682e72d4
View file https://github.com/libgit2/libgit2/blob/a2e6e0ea0e947954836b27572e753c7f95e5a1f4/include/git2/errors.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4879/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4879/files#diff-16ce4ba357b7e6949a83661245088374fd581421b567a4780a98d17f682e72d4
https://github.com/libgit2/libgit2/pull/4879/files#diff-16ce4ba357b7e6949a83661245088374fd581421b567a4780a98d17f682e72d4
include/git2/sys/transport.hhttps://github.com/libgit2/libgit2/pull/4879/files#diff-189a3134cac2b108f2143533cd586ad8c6a7a326593b9103c0a62b79ed2230be
View file https://github.com/libgit2/libgit2/blob/a2e6e0ea0e947954836b27572e753c7f95e5a1f4/include/git2/sys/transport.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4879/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4879/files#diff-189a3134cac2b108f2143533cd586ad8c6a7a326593b9103c0a62b79ed2230be
https://github.com/libgit2/libgit2/pull/4879/files#diff-189a3134cac2b108f2143533cd586ad8c6a7a326593b9103c0a62b79ed2230be
https://github.com/libgit2/libgit2/pull/4879/files#diff-189a3134cac2b108f2143533cd586ad8c6a7a326593b9103c0a62b79ed2230be
include/git2/types.hhttps://github.com/libgit2/libgit2/pull/4879/files#diff-96e375df61a17f8d6149856200c0949f7fa107ebaf7c2605094a93998632db84
View file https://github.com/libgit2/libgit2/blob/a2e6e0ea0e947954836b27572e753c7f95e5a1f4/include/git2/types.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4879/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4879/files#diff-96e375df61a17f8d6149856200c0949f7fa107ebaf7c2605094a93998632db84
https://github.com/libgit2/libgit2/pull/4879/files#diff-96e375df61a17f8d6149856200c0949f7fa107ebaf7c2605094a93998632db84
src/transports/http.chttps://github.com/libgit2/libgit2/pull/4879/files#diff-4ae32386cf6a4e831b232c50f549e48d44adfa7a63a4aa0a436a6b43cf278ba9
View file https://github.com/libgit2/libgit2/blob/a2e6e0ea0e947954836b27572e753c7f95e5a1f4/src/transports/http.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4879/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4879/files#diff-4ae32386cf6a4e831b232c50f549e48d44adfa7a63a4aa0a436a6b43cf278ba9
https://github.com/libgit2/libgit2/pull/4879/files#diff-4ae32386cf6a4e831b232c50f549e48d44adfa7a63a4aa0a436a6b43cf278ba9
https://github.com/libgit2/libgit2/pull/4879/files#diff-4ae32386cf6a4e831b232c50f549e48d44adfa7a63a4aa0a436a6b43cf278ba9
https://github.com/libgit2/libgit2/pull/4879/files#diff-4ae32386cf6a4e831b232c50f549e48d44adfa7a63a4aa0a436a6b43cf278ba9
src/transports/smart.chttps://github.com/libgit2/libgit2/pull/4879/files#diff-88455053c1ba4d5a2d5b80e23f6dbb95b3d59ca9f71e4f84c09a2b3b003ead6a
View file https://github.com/libgit2/libgit2/blob/a2e6e0ea0e947954836b27572e753c7f95e5a1f4/src/transports/smart.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4879/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4879/files#diff-88455053c1ba4d5a2d5b80e23f6dbb95b3d59ca9f71e4f84c09a2b3b003ead6a
https://github.com/libgit2/libgit2/pull/4879/files#diff-88455053c1ba4d5a2d5b80e23f6dbb95b3d59ca9f71e4f84c09a2b3b003ead6a
src/transports/ssh.chttps://github.com/libgit2/libgit2/pull/4879/files#diff-38bd676aed1cb7cffb3d148175dacb0bb4752244457b9468a9c277315b3b1b99
View file https://github.com/libgit2/libgit2/blob/a2e6e0ea0e947954836b27572e753c7f95e5a1f4/src/transports/ssh.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4879/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4879/files#diff-38bd676aed1cb7cffb3d148175dacb0bb4752244457b9468a9c277315b3b1b99
https://github.com/libgit2/libgit2/pull/4879/files#diff-38bd676aed1cb7cffb3d148175dacb0bb4752244457b9468a9c277315b3b1b99
https://github.com/libgit2/libgit2/pull/4879/files#diff-38bd676aed1cb7cffb3d148175dacb0bb4752244457b9468a9c277315b3b1b99
https://github.com/libgit2/libgit2/pull/4879/files#diff-38bd676aed1cb7cffb3d148175dacb0bb4752244457b9468a9c277315b3b1b99
src/transports/winhttp.chttps://github.com/libgit2/libgit2/pull/4879/files#diff-a73ee15948b6492f83f9d6c64fb061c7a8a4dd5072f5a693e23060ac8971723b
View file https://github.com/libgit2/libgit2/blob/a2e6e0ea0e947954836b27572e753c7f95e5a1f4/src/transports/winhttp.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4879/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4879/files#diff-a73ee15948b6492f83f9d6c64fb061c7a8a4dd5072f5a693e23060ac8971723b
https://github.com/libgit2/libgit2/pull/4879/files#diff-a73ee15948b6492f83f9d6c64fb061c7a8a4dd5072f5a693e23060ac8971723b
https://github.com/libgit2/libgit2/pull/4879/files#diff-a73ee15948b6492f83f9d6c64fb061c7a8a4dd5072f5a693e23060ac8971723b
https://github.com/libgit2/libgit2/pull/4879/files#diff-a73ee15948b6492f83f9d6c64fb061c7a8a4dd5072f5a693e23060ac8971723b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.