René's URL Explorer Experiment


Title: patch_parse: populate line numbers while parsing diffs by tiennou · Pull Request #4687 · libgit2/libgit2 · GitHub

Open Graph Title: patch_parse: populate line numbers while parsing diffs by tiennou · Pull Request #4687 · libgit2/libgit2

X Title: patch_parse: populate line numbers while parsing diffs by tiennou · Pull Request #4687 · libgit2/libgit2

Description: A cross-platform, linkable library implementation of Git that you can use in your application. - patch_parse: populate line numbers while parsing diffs by tiennou · Pull Request #4687 · libgit2/libgit2

Open Graph Description: This should fix #4672. Looks like providing the "parsed" line numbers in the line struct was never actually wired (!).

X Description: This should fix #4672. Looks like providing the "parsed" line numbers in the line struct was never actually wired (!).

Opengraph URL: https://github.com/libgit2/libgit2/pull/4687

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d09171f0-7bad-3a19-6e88-aed88369b840
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95C4:1712DC:98FE29B:CDEE3EA:6A5E6D91
html-safe-nonce3bb0919a65f5434f04eceb86aa5d7839e328dd5f364d44e1ef6bd5401eba6c12
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUM0OjE3MTJEQzo5OEZFMjlCOkNERUUzRUE6NkE1RTZEOTEiLCJ2aXNpdG9yX2lkIjoiMjEyMTc2NzM4Mjc3NTkxNzk2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0318b0765b8516f0525e5502f597ee814abe6586b50866e5d9ace03d4c36054d
hovercard-subject-tagpull_request:195643381
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/libgit2/libgit2/4687/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f21ee68d7ee9f87794cb91b34d808640c7b12ab6149a65eac849aa4527cf3e00/libgit2/libgit2/pull/4687
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f21ee68d7ee9f87794cb91b34d808640c7b12ab6149a65eac849aa4527cf3e00/libgit2/libgit2/pull/4687
og:image:altThis should fix #4672. Looks like providing the "parsed" line numbers in the line struct was never actually wired (!).
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametiennou
hostnamegithub.com
expected-hostnamegithub.com
None0e33eedeef87e76d6b013d348ad423a9e503a88efa7080eec1ed2ddba90606bd
turbo-cache-controlno-cache
go-importgithub.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id901662
octolytics-dimension-repository_nwolibgit2/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release15c56e0437fea28b3adfecf1764d0b42db481e03
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/libgit2/libgit2/pull/4687#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4687
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4687
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=libgit2%2Flibgit2
Reloadhttps://github.com/libgit2/libgit2/pull/4687
Reloadhttps://github.com/libgit2/libgit2/pull/4687
Reloadhttps://github.com/libgit2/libgit2/pull/4687
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
libgit2 https://github.com/libgit2
libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Fork 2.6k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Star 10.5k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Code https://github.com/libgit2/libgit2
Issues 423 https://github.com/libgit2/libgit2/issues
Pull requests 108 https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality 9 https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Code https://github.com/libgit2/libgit2
Issues https://github.com/libgit2/libgit2/issues
Pull requests https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
ethomsonhttps://github.com/ethomson
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
tiennou:fix/4672https://github.com/tiennou/libgit2/tree/fix/4672
Conversationhttps://github.com/libgit2/libgit2/pull/4687
Commits1 (1)https://github.com/libgit2/libgit2/pull/4687/commits
Checkshttps://github.com/libgit2/libgit2/pull/4687/checks
Files changedhttps://github.com/libgit2/libgit2/pull/4687/files
patch_parse: populate line numbers while parsing diffshttps://github.com/libgit2/libgit2/pull/4687#top
ethomsonhttps://github.com/ethomson
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
tiennou:fix/4672https://github.com/tiennou/libgit2/tree/fix/4672
https://github.com/tiennou
tiennouhttps://github.com/tiennou
Jun 18, 2018https://github.com/libgit2/libgit2/pull/4687#issue-333428423
#4672https://github.com/libgit2/libgit2/issues/4672
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/tiennou
tiennouhttps://github.com/tiennou
Jun 18, 2018 https://github.com/libgit2/libgit2/pull/4687#pullrequestreview-129731941
View reviewed changes https://github.com/libgit2/libgit2/pull/4687/files
tests/diff/parse.chttps://github.com/libgit2/libgit2/pull/4687/files#diff-004552254d91dbb730b7838237fe25423e86acedf98984095c2c35e0ae77060a
tiennouhttps://github.com/tiennou
Jun 18, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196219455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
tiennouhttps://github.com/tiennou
Jun 18, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196221215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
ethomsonhttps://github.com/ethomson
Jun 19, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196333838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
src/patch_parse.chttps://github.com/libgit2/libgit2/pull/4687/files#diff-8082ba83aaa0ee74e4f49415641c276259ea02e30621968e37952340cd287fb0
tiennouhttps://github.com/tiennou
Jun 18, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196220517
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
ethomsonhttps://github.com/ethomson
Jun 19, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196333275
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
tiennouhttps://github.com/tiennou
Jun 19, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196551904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/tiennou
patch_parse: populate line numbers while parsing diffshttps://github.com/libgit2/libgit2/pull/4687/commits/f9e28026753f7b6c871a160ad584b2dc2639d30f
f9e2802https://github.com/libgit2/libgit2/pull/4687/commits/f9e28026753f7b6c871a160ad584b2dc2639d30f
https://github.com/tiennou
tiennouhttps://github.com/tiennou
force-pushedhttps://github.com/libgit2/libgit2/compare/54c6b5fedf2c9cb661e02d73947e299bfe05b498..f9e28026753f7b6c871a160ad584b2dc2639d30f
54c6b5fhttps://github.com/libgit2/libgit2/commit/54c6b5fedf2c9cb661e02d73947e299bfe05b498
f9e2802https://github.com/libgit2/libgit2/commit/f9e28026753f7b6c871a160ad584b2dc2639d30f
Compare https://github.com/libgit2/libgit2/compare/54c6b5fedf2c9cb661e02d73947e299bfe05b498..f9e28026753f7b6c871a160ad584b2dc2639d30f
June 18, 2018 22:13https://github.com/libgit2/libgit2/pull/4687#event-1687310164
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jun 19, 2018https://github.com/libgit2/libgit2/pull/4687#issuecomment-398315175
#4672https://github.com/libgit2/libgit2/issues/4672
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jun 19, 2018 https://github.com/libgit2/libgit2/pull/4687#pullrequestreview-129862092
View reviewed changes https://github.com/libgit2/libgit2/pull/4687/files/f9e28026753f7b6c871a160ad584b2dc2639d30f
tests/diff/parse.chttps://github.com/libgit2/libgit2/pull/4687/files/f9e28026753f7b6c871a160ad584b2dc2639d30f#diff-004552254d91dbb730b7838237fe25423e86acedf98984095c2c35e0ae77060a
ethomsonhttps://github.com/ethomson
Jun 19, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196333031
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
tiennouhttps://github.com/tiennou
Jun 19, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r196550656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
examplehttps://github.com/libgit2/libgit2/blob/master/tests/diff/patch.c?utf8=%E2%9C%93#L313
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
pks-thttps://github.com/pks-t
Jun 22, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r197355573
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
tiennouhttps://github.com/tiennou
Jun 22, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r197439319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
ethomsonhttps://github.com/ethomson
Jun 26, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r198059854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
tiennouhttps://github.com/tiennou
Jun 26, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r198107175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cl_reflog_check_entryhttps://github.com/libgit2/libgit2/blob/master/tests/refs/reflog/reflog_helpers.c#L30
check_single_patch_statshttps://github.com/libgit2/libgit2/blob/master/tests/diff/patch.c#L448
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
pks-thttps://github.com/pks-t
Jun 29, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r199116653
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
tiennouhttps://github.com/tiennou
Jun 29, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r199233750
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
pks-thttps://github.com/pks-t
Jul 6, 2018https://github.com/libgit2/libgit2/pull/4687#discussion_r200626092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/tiennou
tiennouhttps://github.com/tiennou
Jun 19, 2018https://github.com/libgit2/libgit2/pull/4687#issuecomment-398518261
#4672https://github.com/libgit2/libgit2/issues/4672
tests/diff/patch.c:260https://github.com/libgit2/libgit2/blob/master/tests/diff/patch.c?utf8=%E2%9C%93#L260
Never hooked uphttps://github.com/libgit2/libgit2/pull/d34f68261ef95b517944d4fa89ee13b4a68d3cb4
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jun 22, 2018https://github.com/libgit2/libgit2/pull/4687#issuecomment-399381817
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/pks-t
pks-thttps://github.com/pks-t
Jul 6, 2018 https://github.com/libgit2/libgit2/pull/4687#pullrequestreview-134980586
View reviewed changes https://github.com/libgit2/libgit2/pull/4687/files/f9e28026753f7b6c871a160ad584b2dc2639d30f
pks-thttps://github.com/pks-t
https://github.com/libgit2/libgit2/pull/4687#pullrequestreview-134980586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ethomsonhttps://github.com/ethomson
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Jul 6, 2018https://github.com/libgit2/libgit2/pull/4687#issuecomment-403008730
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
f463379https://github.com/libgit2/libgit2/commit/f4633791104fa5be75115fd4c7fab0c097da345e
Jul 6, 2018https://github.com/libgit2/libgit2/pull/4687#event-1720083130
https://github.com/pks-t
pks-thttps://github.com/pks-t
backport-0.27.6 https://github.com/libgit2/libgit2/issues?q=state%3Aopen%20label%3Abackport-0.27.6
Oct 11, 2018https://github.com/libgit2/libgit2/pull/4687#event-1898000449
https://github.com/tiennou
tiennouhttps://github.com/tiennou
November 1, 2018 03:56https://github.com/libgit2/libgit2/pull/4687#event-1939573299
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Feb 23, 2020 https://github.com/libgit2/libgit2/pull/4687#ref-pullrequest-569442418
[Snyk] Upgrade nodegit from 0.4.1 to 0.26.4 saurabharch/Breezeblocks#1 https://github.com/saurabharch/Breezeblocks/pull/1
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 22, 2020 https://github.com/libgit2/libgit2/pull/4687#ref-pullrequest-604472000
[Snyk] Upgrade nodegit from 0.24.3 to 0.26.5 aminatakonate000/Graviton-App#4 https://github.com/aminatakonate000/Graviton-App/pull/4
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
May 5, 2020 https://github.com/libgit2/libgit2/pull/4687#ref-pullrequest-612362441
[Snyk] Upgrade nodegit from 0.24.3 to 0.26.5 Barnstorm-Online/ngp-openapi-generator#1 https://github.com/Barnstorm-Online/ngp-openapi-generator/pull/1
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4687
https://github.com/ethomson
ethomson https://github.com/ethomson
https://github.com/libgit2/libgit2/pull/4687/files/f9e28026753f7b6c871a160ad584b2dc2639d30f
https://github.com/pks-t
pks-t https://github.com/pks-t
https://github.com/libgit2/libgit2/pull/4687/files/f9e28026753f7b6c871a160ad584b2dc2639d30f
git_diff_line.{new,old}_lineno is incorrect https://github.com/libgit2/libgit2/issues/4672
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4687
https://github.com/tiennou
https://github.com/ethomson
https://github.com/pks-t
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.