René's URL Explorer Experiment


Title: Fix git_worktree_validate failing on bare repositories by tiennou · Pull Request #4686 · libgit2/libgit2 · GitHub

Open Graph Title: Fix git_worktree_validate failing on bare repositories by tiennou · Pull Request #4686 · libgit2/libgit2

X Title: Fix git_worktree_validate failing on bare repositories by tiennou · Pull Request #4686 · libgit2/libgit2

Description: This fixes #4669, as well as checking that #4684 really isn't our fault (I wasn't sure, since #4630 was about that problem). Sidenotes : I was expecting git_worktree_validate to return a "logical C bool", but it instead return negative error codes that don't map to "the standard" ones. That was surprising 😉. Looking at the diff, I'm also unsure what the list_bare test I moved was actually testing, as it's not run against the testsuite's repository.

Open Graph Description: This fixes #4669, as well as checking that #4684 really isn't our fault (I wasn't sure, since #4630 was about that problem). Sidenotes : I was expecting git_worktree_validate to return a &q...

X Description: This fixes #4669, as well as checking that #4684 really isn't our fault (I wasn't sure, since #4630 was about that problem). Sidenotes : I was expecting git_worktree_validate to ret...

Opengraph URL: https://github.com/libgit2/libgit2/pull/4686

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:52f75191-953b-5d76-91c8-cd2564ac5f7e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90B0:1712DC:65FEFAA:860305A:6A5DCAE8
html-safe-nonce3141f1a256fe0c0e62db6be33a91707274ebc5bf0b3763bc47c8841b6498f7cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEIwOjE3MTJEQzo2NUZFRkFBOjg2MDMwNUE6NkE1RENBRTgiLCJ2aXNpdG9yX2lkIjoiMzkzODgzOTg2NjcwOTQ5NDUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1f47655a75cbedee668a7ea345cd9fb35729447fcc20df69639076198f086f50
hovercard-subject-tagpull_request:195610559
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/libgit2/libgit2/pull/4686/files
twitter:imagehttps://avatars.githubusercontent.com/u/81099?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/81099?s=400&v=4
og:image:altThis fixes #4669, as well as checking that #4684 really isn't our fault (I wasn't sure, since #4630 was about that problem). Sidenotes : I was expecting git_worktree_validate to return a &q...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id901662
octolytics-dimension-repository_nwolibgit2/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/libgit2/libgit2/pull/4686/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4686%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4686%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=libgit2%2Flibgit2
Reloadhttps://github.com/libgit2/libgit2/pull/4686/files
Reloadhttps://github.com/libgit2/libgit2/pull/4686/files
Reloadhttps://github.com/libgit2/libgit2/pull/4686/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4686/files
libgit2 https://github.com/libgit2
libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Fork 2.6k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Star 10.5k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Code https://github.com/libgit2/libgit2
Issues 423 https://github.com/libgit2/libgit2/issues
Pull requests 108 https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality 9 https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Code https://github.com/libgit2/libgit2
Issues https://github.com/libgit2/libgit2/issues
Pull requests https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Flibgit2%2Flibgit2%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Flibgit2%2Flibgit2%2Fissues%2Fnew%2Fchoose
pks-thttps://github.com/pks-t
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
tiennou:fix/more-worktree-from-barehttps://github.com/tiennou/libgit2/tree/fix/more-worktree-from-bare
Conversation 23 https://github.com/libgit2/libgit2/pull/4686
Commits 7 https://github.com/libgit2/libgit2/pull/4686/commits
Checks 0 https://github.com/libgit2/libgit2/pull/4686/checks
Files changed https://github.com/libgit2/libgit2/pull/4686/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4686/files
Fix git_worktree_validate failing on bare repositories https://github.com/libgit2/libgit2/pull/4686/files#top
Show all changes 7 commits https://github.com/libgit2/libgit2/pull/4686/files
7e3c13e tests: worktree/bare: gather all tests tiennou Jun 29, 2018 https://github.com/libgit2/libgit2/pull/4686/commits/7e3c13e08078f56b3307eba3b0c054ff6cc59c24
bd40f0d tests: worktree/bare: check git_worktree_list tiennou Jun 29, 2018 https://github.com/libgit2/libgit2/pull/4686/commits/bd40f0d7bbb5a50e08e27275b21ffa082d4f0e82
83c35f7 tests: worktree/bare: fix git_worktree_validate tiennou Jun 29, 2018 https://github.com/libgit2/libgit2/pull/4686/commits/83c35f7ea4f48a1f805c53277e65ab5e8429c6a7
d092112 tests: add a helper to build sandbox subpaths quickly tiennou Jun 29, 2018 https://github.com/libgit2/libgit2/pull/4686/commits/d0921127c9ff2baaa8a766de43d3921933ad919d
8356bf7 tests: worktree/bare: test some paths tiennou Jun 29, 2018 https://github.com/libgit2/libgit2/pull/4686/commits/8356bf7e1a7ef6fa68f1c918d03011bf774c9ffb
292a6ec worktree: skip building a buffer when validating tiennou Jun 29, 2018 https://github.com/libgit2/libgit2/pull/4686/commits/292a6eca338932d33e9de77956919a781c9c4bd6
1da6329 worktree: don't return "untyped" negative numbers as error codes tiennou Jun 29, 2018 https://github.com/libgit2/libgit2/pull/4686/commits/1da6329fd7f862ac355178dc89c8b321f420fca6
Clear filters https://github.com/libgit2/libgit2/pull/4686/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4686/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4686/files
worktree.c https://github.com/libgit2/libgit2/pull/4686/files#diff-901344d7a8b2466c8b7d4f499b8dde3f78c2cb02eac92c193d86f5b156f39db5
clar_libgit2.c https://github.com/libgit2/libgit2/pull/4686/files#diff-b5bf6caca82194dbd6f271605a6f94c774df1ec2ea4ec5517593dda6c5403c55
clar_libgit2.h https://github.com/libgit2/libgit2/pull/4686/files#diff-a7bc7d419f095dee8cd3c544696a41edd17fefa2aa4cd645bc690b7667546690
bare.c https://github.com/libgit2/libgit2/pull/4686/files#diff-e72079629eb46e9baf2724401608c97806bba08ccc8d9df723bee63188dbbec1
open.c https://github.com/libgit2/libgit2/pull/4686/files#diff-b733a093af13103ada6d23cc28e6fd06c3bdc8ca8147326380276f2df6378438
worktree.c https://github.com/libgit2/libgit2/pull/4686/files#diff-445771d4dad4b2134ccc2b40133171db884cd36fbb39c8f1cb37a3d847c193bb
src/worktree.chttps://github.com/libgit2/libgit2/pull/4686/files#diff-901344d7a8b2466c8b7d4f499b8dde3f78c2cb02eac92c193d86f5b156f39db5
View file https://github.com/tiennou/libgit2/blob/1da6329fd7f862ac355178dc89c8b321f420fca6/src/worktree.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4686/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4686/files#diff-901344d7a8b2466c8b7d4f499b8dde3f78c2cb02eac92c193d86f5b156f39db5
https://github.com/libgit2/libgit2/pull/4686/files#diff-901344d7a8b2466c8b7d4f499b8dde3f78c2cb02eac92c193d86f5b156f39db5
tests/clar_libgit2.chttps://github.com/libgit2/libgit2/pull/4686/files#diff-b5bf6caca82194dbd6f271605a6f94c774df1ec2ea4ec5517593dda6c5403c55
View file https://github.com/tiennou/libgit2/blob/1da6329fd7f862ac355178dc89c8b321f420fca6/tests/clar_libgit2.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4686/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4686/files#diff-b5bf6caca82194dbd6f271605a6f94c774df1ec2ea4ec5517593dda6c5403c55
https://github.com/libgit2/libgit2/pull/4686/files#diff-b5bf6caca82194dbd6f271605a6f94c774df1ec2ea4ec5517593dda6c5403c55
tests/clar_libgit2.hhttps://github.com/libgit2/libgit2/pull/4686/files#diff-a7bc7d419f095dee8cd3c544696a41edd17fefa2aa4cd645bc690b7667546690
View file https://github.com/tiennou/libgit2/blob/1da6329fd7f862ac355178dc89c8b321f420fca6/tests/clar_libgit2.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4686/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4686/files#diff-a7bc7d419f095dee8cd3c544696a41edd17fefa2aa4cd645bc690b7667546690
https://github.com/libgit2/libgit2/pull/4686/files#diff-a7bc7d419f095dee8cd3c544696a41edd17fefa2aa4cd645bc690b7667546690
tests/worktree/bare.chttps://github.com/libgit2/libgit2/pull/4686/files#diff-e72079629eb46e9baf2724401608c97806bba08ccc8d9df723bee63188dbbec1
View file https://github.com/tiennou/libgit2/blob/1da6329fd7f862ac355178dc89c8b321f420fca6/tests/worktree/bare.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4686/{{ revealButtonHref }}
tests/worktree/open.chttps://github.com/libgit2/libgit2/pull/4686/files#diff-b733a093af13103ada6d23cc28e6fd06c3bdc8ca8147326380276f2df6378438
View file https://github.com/tiennou/libgit2/blob/1da6329fd7f862ac355178dc89c8b321f420fca6/tests/worktree/open.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4686/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4686/files#diff-b733a093af13103ada6d23cc28e6fd06c3bdc8ca8147326380276f2df6378438
pks-thttps://github.com/pks-t
Jun 22, 2018https://github.com/libgit2/libgit2/pull/4686/files#r197356835
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4686/files
tiennouhttps://github.com/tiennou
Jun 22, 2018https://github.com/libgit2/libgit2/pull/4686/files#r197556527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4686/files
https://github.com/libgit2/libgit2/pull/4686/files#diff-b733a093af13103ada6d23cc28e6fd06c3bdc8ca8147326380276f2df6378438
tests/worktree/worktree.chttps://github.com/libgit2/libgit2/pull/4686/files#diff-445771d4dad4b2134ccc2b40133171db884cd36fbb39c8f1cb37a3d847c193bb
View file https://github.com/tiennou/libgit2/blob/1da6329fd7f862ac355178dc89c8b321f420fca6/tests/worktree/worktree.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4686/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4686/files#diff-445771d4dad4b2134ccc2b40133171db884cd36fbb39c8f1cb37a3d847c193bb
https://github.com/libgit2/libgit2/pull/4686/files#diff-445771d4dad4b2134ccc2b40133171db884cd36fbb39c8f1cb37a3d847c193bb
https://github.com/libgit2/libgit2/pull/4686/files#diff-445771d4dad4b2134ccc2b40133171db884cd36fbb39c8f1cb37a3d847c193bb
https://github.com/libgit2/libgit2/pull/4686/files#diff-445771d4dad4b2134ccc2b40133171db884cd36fbb39c8f1cb37a3d847c193bb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.