René's URL Explorer Experiment

Title: Custom memory allocators by pks-t · Pull Request #4576 · libgit2/libgit2 · GitHub

Open Graph Title: Custom memory allocators by pks-t · Pull Request #4576 · libgit2/libgit2

X Title: Custom memory allocators by pks-t · Pull Request #4576 · libgit2/libgit2

Description: This is an RFC regarding custom memory allocators. Existing standard allocators are being renamed to git__stdalloc__. By default, our usual allocators git__ are being defined to git__stdalloc__. For CRTDBG, our allocators git__ are being defined to git__crtdbg__. If the CMake option "PLUGGABLE_ALLOCATORS" is set, we use an indirection. Instead of using typedefs, each of our allocator functions is not a define but instead a function pointer, which is by default set to the respecfive git__stdalloc__ function. Our git_libgit2_opts function is extended by "GIT_OPT_SET_ALLOCATOR, which receives as argument a git_allocator structure. Its members will then be used to change the function pointers. I don't know whether we really need to distinguish between builds with and without pluggable allocators. The question is whether there's a performance hit when using function pointers. I haven't measured that yet, though. The other thing I'm unhappy about is the CRTDBG stuff. It would be rather cool if we could allow users of libgit2 to swap in CRTDBG at runtime, in contrast to how we do it at compile time right now. It would also easily be possible, except for the fact that all CRTDBG functions have two additional parameters to create the correct trace: LINE and FILE. We could just extend all our allocators by these parameters. But this could again have a performance penalty, I guess. Again, this needs to be measured. Anyway. I first want your opinions on these points. The implementation would still need a bit of cleanup. The git_allocator stuff should probably be its own module "alloc.{c,h}", but that's minor stuff only.

Open Graph Description: This is an RFC regarding custom memory allocators. Existing standard allocators are being renamed to git__stdalloc__<fn>. By default, our usual allocators git__<fn> are being defined to...

X Description: This is an RFC regarding custom memory allocators. Existing standard allocators are being renamed to git__stdalloc__&lt;fn&gt;. By default, our usual allocators git__&lt;fn&gt; are ...

Opengraph URL: https://github.com/libgit2/libgit2/pull/4576

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width