René's URL Explorer Experiment


Title: Static linking for bundled deps by pks-t · Pull Request #4339 · libgit2/libgit2 · GitHub

Open Graph Title: Static linking for bundled deps by pks-t · Pull Request #4339 · libgit2/libgit2

X Title: Static linking for bundled deps by pks-t · Pull Request #4339 · libgit2/libgit2

Description: A cross-platform, linkable library implementation of Git that you can use in your application. - Static linking for bundled deps by pks-t · Pull Request #4339 · libgit2/libgit2

Open Graph Description: This fixes #4336. The problem is that we do not link in static dependencies for a static libgit2 library. The mistake stems from expecting TARGET_LINK_LIBRARIES to merge static archives, which does...

X Description: This fixes #4336. The problem is that we do not link in static dependencies for a static libgit2 library. The mistake stems from expecting TARGET_LINK_LIBRARIES to merge static archives, which does...

Opengraph URL: https://github.com/libgit2/libgit2/pull/4339

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:740c5c14-d962-b4a1-022e-2752996f98e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF0C:2F3AB6:52B783F:6CEE2DB:6A5D98FC
html-safe-nonced181c78e8c441f8a568ea8c64b2ccfdf1220ea73f1373c09f55f0d1664545c76
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjBDOjJGM0FCNjo1MkI3ODNGOjZDRUUyREI6NkE1RDk4RkMiLCJ2aXNpdG9yX2lkIjoiMzI4MDc0OTMzOTY0MDQzNjk4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac74a448b11278bd31c3545789e8fec3617f4fc5b951fca50ea106d196ddf8b315
hovercard-subject-tagpull_request:139320812
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/libgit2/libgit2/4339/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e249d7dfb86d05218b12f2558172a125106f0e712d3340c9715596619cc2650f/libgit2/libgit2/pull/4339
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e249d7dfb86d05218b12f2558172a125106f0e712d3340c9715596619cc2650f/libgit2/libgit2/pull/4339
og:image:altThis fixes #4336. The problem is that we do not link in static dependencies for a static libgit2 library. The mistake stems from expecting TARGET_LINK_LIBRARIES to merge static archives, which does...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepks-t
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id901662
octolytics-dimension-repository_nwolibgit2/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/libgit2/libgit2/pull/4339#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4339
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4339
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=libgit2%2Flibgit2
Reloadhttps://github.com/libgit2/libgit2/pull/4339
Reloadhttps://github.com/libgit2/libgit2/pull/4339
Reloadhttps://github.com/libgit2/libgit2/pull/4339
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
libgit2 https://github.com/libgit2
libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Fork 2.6k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Star 10.5k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Code https://github.com/libgit2/libgit2
Issues 423 https://github.com/libgit2/libgit2/issues
Pull requests 108 https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality 9 https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Code https://github.com/libgit2/libgit2
Issues https://github.com/libgit2/libgit2/issues
Pull requests https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
carlosmnhttps://github.com/carlosmn
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
pks-t:pks/static-linkinghttps://github.com/pks-t/libgit2/tree/pks/static-linking
Conversationhttps://github.com/libgit2/libgit2/pull/4339
Commits7 (7)https://github.com/libgit2/libgit2/pull/4339/commits
Checkshttps://github.com/libgit2/libgit2/pull/4339/checks
Files changedhttps://github.com/libgit2/libgit2/pull/4339/files
Static linking for bundled depshttps://github.com/libgit2/libgit2/pull/4339#top
carlosmnhttps://github.com/carlosmn
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
pks-t:pks/static-linkinghttps://github.com/pks-t/libgit2/tree/pks/static-linking
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 5, 2017https://github.com/libgit2/libgit2/pull/4339#issue-255273617
#4336https://github.com/libgit2/libgit2/issues/4336
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 6, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-327379962
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
force-pushedhttps://github.com/libgit2/libgit2/compare/23fb3825104b05cccd213ca991e23a8580831489..0179b7aff03e6b27b95f4dd09a3f1208901f08b4
23fb382https://github.com/libgit2/libgit2/commit/23fb3825104b05cccd213ca991e23a8580831489
0179b7ahttps://github.com/libgit2/libgit2/commit/0179b7aff03e6b27b95f4dd09a3f1208901f08b4
Compare https://github.com/libgit2/libgit2/compare/23fb3825104b05cccd213ca991e23a8580831489..0179b7aff03e6b27b95f4dd09a3f1208901f08b4
September 6, 2017 06:10https://github.com/libgit2/libgit2/pull/4339#event-1236180692
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 6, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-327385815
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
@ethomsonhttps://github.com/ethomson
@carlosmnhttps://github.com/carlosmn
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/ethomson
ethomsonhttps://github.com/ethomson
Sep 6, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-327405118
#4321https://github.com/libgit2/libgit2/pull/4321
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/carlosmn
carlosmnhttps://github.com/carlosmn
Sep 6, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-327457971
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 12, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-328724771
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
force-pushedhttps://github.com/libgit2/libgit2/compare/9864001c3e474878b69f3668472f03658bd37ef4..36086c3f1d10c1235dc77ac56277567d7dac5590
9864001https://github.com/libgit2/libgit2/commit/9864001c3e474878b69f3668472f03658bd37ef4
36086c3https://github.com/libgit2/libgit2/commit/36086c3f1d10c1235dc77ac56277567d7dac5590
Compare https://github.com/libgit2/libgit2/compare/9864001c3e474878b69f3668472f03658bd37ef4..36086c3f1d10c1235dc77ac56277567d7dac5590
September 13, 2017 14:57https://github.com/libgit2/libgit2/pull/4339#event-1247433954
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 20, 2017 https://github.com/libgit2/libgit2/pull/4339#ref-issue-254883090
A static build does not include the http parser symbols #4336 https://github.com/libgit2/libgit2/issues/4336
https://github.com/pks-t
pks-thttps://github.com/pks-t
force-pushedhttps://github.com/libgit2/libgit2/compare/36086c3f1d10c1235dc77ac56277567d7dac5590..0179b7aff03e6b27b95f4dd09a3f1208901f08b4
36086c3https://github.com/libgit2/libgit2/commit/36086c3f1d10c1235dc77ac56277567d7dac5590
0179b7ahttps://github.com/libgit2/libgit2/commit/0179b7aff03e6b27b95f4dd09a3f1208901f08b4
Compare https://github.com/libgit2/libgit2/compare/36086c3f1d10c1235dc77ac56277567d7dac5590..0179b7aff03e6b27b95f4dd09a3f1208901f08b4
September 20, 2017 13:25https://github.com/libgit2/libgit2/pull/4339#event-1257426194
pks-thttps://github.com/pks-t
September 20, 2017 15:26https://github.com/libgit2/libgit2/pull/4339#commits-pushed-c17c3f8
https://github.com/pks-t
travis: drop support for Ubuntu Precisehttps://github.com/libgit2/libgit2/pull/4339/commits/c17c3f8a07377d76432fb2e4369b9805387ac099
c17c3f8https://github.com/libgit2/libgit2/pull/4339/commits/c17c3f8a07377d76432fb2e4369b9805387ac099
https://github.com/pks-t
cmake: distinguish libgit2 objects and sourceshttps://github.com/libgit2/libgit2/pull/4339/commits/1d9dd882b32cbaa5d4c8b0b39558ce8ac16274fa
1d9dd88https://github.com/libgit2/libgit2/pull/4339/commits/1d9dd882b32cbaa5d4c8b0b39558ce8ac16274fa
https://github.com/pks-t
cmake: bump minimum version to 2.8.11https://github.com/libgit2/libgit2/pull/4339/commits/cf9f345217d7d28a55a08e7a25a9fdfca9fc3beb
cf9f345https://github.com/libgit2/libgit2/pull/4339/commits/cf9f345217d7d28a55a08e7a25a9fdfca9fc3beb
https://github.com/pks-t
cmake: always use object library for git2internalhttps://github.com/libgit2/libgit2/pull/4339/commits/172a585f8860f87c80800add5bf6d47470bb0f7e
172a585https://github.com/libgit2/libgit2/pull/4339/commits/172a585f8860f87c80800add5bf6d47470bb0f7e
https://github.com/pks-t
cmake: unify version check for target include directorieshttps://github.com/libgit2/libgit2/pull/4339/commits/d8d2f21e24933cddabf30f2d4a4ddf1be0072e56
d8d2f21https://github.com/libgit2/libgit2/pull/4339/commits/d8d2f21e24933cddabf30f2d4a4ddf1be0072e56
https://github.com/pks-t
cmake: fix static linking for bundled depshttps://github.com/libgit2/libgit2/pull/4339/commits/8c19969a88c3b6e72564e812537b15cbc0fb4cc0
8c19969https://github.com/libgit2/libgit2/pull/4339/commits/8c19969a88c3b6e72564e812537b15cbc0fb4cc0
https://github.com/pks-t
pks-thttps://github.com/pks-t
force-pushedhttps://github.com/libgit2/libgit2/compare/0179b7aff03e6b27b95f4dd09a3f1208901f08b4..8c19969a88c3b6e72564e812537b15cbc0fb4cc0
0179b7ahttps://github.com/libgit2/libgit2/commit/0179b7aff03e6b27b95f4dd09a3f1208901f08b4
8c19969https://github.com/libgit2/libgit2/commit/8c19969a88c3b6e72564e812537b15cbc0fb4cc0
Compare https://github.com/libgit2/libgit2/compare/0179b7aff03e6b27b95f4dd09a3f1208901f08b4..8c19969a88c3b6e72564e812537b15cbc0fb4cc0
September 20, 2017 13:26https://github.com/libgit2/libgit2/pull/4339#event-1257427314
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 20, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-330852936
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/lunij
lunijhttps://github.com/lunij
Sep 20, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-330933566
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
@pks-thttps://github.com/pks-t
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/lunij
lunijhttps://github.com/lunij
Sep 20, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-330987745
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 22, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-331370467
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 22, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-331373381
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 22, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-331376618
#4356https://github.com/libgit2/libgit2/pull/4356
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
pks-thttps://github.com/pks-t
Sep 22, 2017 https://github.com/libgit2/libgit2/pull/4339#ref-issue-258264856
Missing libgit2.dylib #4352 https://github.com/libgit2/libgit2/issues/4352
https://github.com/carlosmn
carlosmnhttps://github.com/carlosmn
Sep 27, 2017 https://github.com/libgit2/libgit2/pull/4339#ref-pullrequest-260975398
Plug some leaks in curl's proxy handling #4359 https://github.com/libgit2/libgit2/pull/4359
https://github.com/Uncommon
Uncommonhttps://github.com/Uncommon
Sep 27, 2017 https://github.com/libgit2/libgit2/pull/4339#ref-issue-260789553
Link error with Xcode 9, macOS 10.13 libgit2/objective-git#638 https://github.com/libgit2/objective-git/issues/638
https://github.com/carlosmn
carlosmnhttps://github.com/carlosmn
Sep 28, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-332849979
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/carlosmn
carlosmnhttps://github.com/carlosmn
Sep 28, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-332858214
#4317https://github.com/libgit2/libgit2/pull/4317
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/carlosmn
travis: keep installing our custom libcurl buildhttps://github.com/libgit2/libgit2/pull/4339/commits/366f4136ec50888d2d52316dc07d775a71bed97e
366f413https://github.com/libgit2/libgit2/pull/4339/commits/366f4136ec50888d2d52316dc07d775a71bed97e
c17c3f8https://github.com/pks-t/libgit2/commit/c17c3f8a07377d76432fb2e4369b9805387ac099
https://github.com/carlosmn
carlosmnhttps://github.com/carlosmn
Sep 28, 2017https://github.com/libgit2/libgit2/pull/4339#issuecomment-332890700
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/carlosmn
carlosmnhttps://github.com/carlosmn
c7c5f2chttps://github.com/libgit2/libgit2/commit/c7c5f2c4ecc727ac555f51bd20353f7f3ae9c07a
Sep 28, 2017https://github.com/libgit2/libgit2/pull/4339#event-1270151098
https://github.com/pks-t
pks-thttps://github.com/pks-t
November 11, 2017 20:35https://github.com/libgit2/libgit2/pull/4339#event-1337356198
https://github.com/PetrusZ
PetrusZhttps://github.com/PetrusZ
Apr 11, 2018 https://github.com/libgit2/libgit2/pull/4339#ref-issue-313205892
gem install failure due to dependency rugged-0.21.4 and libgit2 cause link failed when using system http_parser patrickdavey/vimwiki_markdown#13 https://github.com/patrickdavey/vimwiki_markdown/issues/13
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4339
A static build does not include the http parser symbols https://github.com/libgit2/libgit2/issues/4336
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4339
https://github.com/pks-t
https://github.com/ethomson
https://github.com/carlosmn
https://github.com/lunij
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.