René's URL Explorer Experiment


Title: Split up CMakeLists.txt build instructions by pks-t · Pull Request #4282 · libgit2/libgit2 · GitHub

Open Graph Title: Split up CMakeLists.txt build instructions by pks-t · Pull Request #4282 · libgit2/libgit2

X Title: Split up CMakeLists.txt build instructions by pks-t · Pull Request #4282 · libgit2/libgit2

Description: While discussing build issues with @ethomson, I've been reminded to how unwieldy our current CMakeLists.txt is. Besides being huge, it also has several problems with the build enviroment leaking between targets. One example are defines for our test suite, which are also set when we build our library code, which is unfortunate. To fix this, I've started taking a look at splitting up the CMakeLists.txt. It's been quite annoying to do and probably has issues left, but I think it's a good think to do in the long run. Furthermore, I hope it will help the issue with precompiled headers from #3950. While at it, this PR also fixes building our library twice by using an object library, as in #3950.

Open Graph Description: While discussing build issues with @ethomson, I've been reminded to how unwieldy our current CMakeLists.txt is. Besides being huge, it also has several problems with the build enviroment leakin...

X Description: While discussing build issues with @ethomson, I've been reminded to how unwieldy our current CMakeLists.txt is. Besides being huge, it also has several problems with the build enviroment le...

Opengraph URL: https://github.com/libgit2/libgit2/pull/4282

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:26f9c25f-a0e6-9a2d-cfbb-f795fe5e5bc2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB248:34684:473ED3A:5EC2A2A:6A5D8D65
html-safe-nonce3f54c36072ac7ed052a8cb3e78c3af413a95e37478760ce62c86288b5c67b8c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjQ4OjM0Njg0OjQ3M0VEM0E6NUVDMkEyQTo2QTVEOEQ2NSIsInZpc2l0b3JfaWQiOiIzNjE5MDI1MzQ0NzQwMDM1OTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac04efeb117cca7a0d7599c2fc4dcb6061247e852b330ad981c53c39d01af97e2f
hovercard-subject-tagpull_request:127285325
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/libgit2/libgit2/pull/4282/files
twitter:imagehttps://avatars.githubusercontent.com/u/4056630?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4056630?s=400&v=4
og:image:altWhile discussing build issues with @ethomson, I've been reminded to how unwieldy our current CMakeLists.txt is. Besides being huge, it also has several problems with the build enviroment leakin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git
octolytics-dimension-user_id394745
octolytics-dimension-user_loginlibgit2
octolytics-dimension-repository_id901662
octolytics-dimension-repository_nwolibgit2/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/libgit2/libgit2/pull/4282/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4282%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flibgit2%2Flibgit2%2Fpull%2F4282%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=libgit2%2Flibgit2
Reloadhttps://github.com/libgit2/libgit2/pull/4282/files
Reloadhttps://github.com/libgit2/libgit2/pull/4282/files
Reloadhttps://github.com/libgit2/libgit2/pull/4282/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4282/files
libgit2 https://github.com/libgit2
libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Fork 2.6k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Star 10.5k https://github.com/login?return_to=%2Flibgit2%2Flibgit2
Code https://github.com/libgit2/libgit2
Issues 423 https://github.com/libgit2/libgit2/issues
Pull requests 108 https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality 9 https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Code https://github.com/libgit2/libgit2
Issues https://github.com/libgit2/libgit2/issues
Pull requests https://github.com/libgit2/libgit2/pulls
Discussions https://github.com/libgit2/libgit2/discussions
Actions https://github.com/libgit2/libgit2/actions
Projects https://github.com/libgit2/libgit2/projects
Security and quality https://github.com/libgit2/libgit2/security
Insights https://github.com/libgit2/libgit2/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Flibgit2%2Flibgit2%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Flibgit2%2Flibgit2%2Fissues%2Fnew%2Fchoose
ethomsonhttps://github.com/ethomson
libgit2:masterhttps://github.com/libgit2/libgit2/tree/master
pks-t:pks/remove-unused-clar-fixtureshttps://github.com/pks-t/libgit2/tree/pks/remove-unused-clar-fixtures
Conversation 31 https://github.com/libgit2/libgit2/pull/4282
Commits 21 https://github.com/libgit2/libgit2/pull/4282/commits
Checks 0 https://github.com/libgit2/libgit2/pull/4282/checks
Files changed https://github.com/libgit2/libgit2/pull/4282/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4282/files
Split up CMakeLists.txt build instructions https://github.com/libgit2/libgit2/pull/4282/files#top
Show all changes 21 commits https://github.com/libgit2/libgit2/pull/4282/files
096a49c cmake: try to detect threads library pks-t Jul 3, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/096a49c0dc4a8aec540251a1c9a77f86ba6fa2ca
f33911e cmake: remove unused variable "CLAR_RESOURCES" pks-t Jun 23, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/f33911e517d93f93b814151dafe6149df9c6c01f
caab827 cmake: create object library target pks-t Jun 23, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/caab8270a5c038fe9412e6de4ab8f114be61993b
3267115 cmake: create own precompiled headers for tests pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/3267115fc2f5f69384cc569dcb3a28aadd8305f7
35087f0 cmake: create separate CMakeLists.txt for tests pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/35087f0eeff10efaf2304fa0772e9836a9fd9fc7
a390a84 cmake: move defines into "features.h" header pks-t Jul 1, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/a390a8464e720365271238d80586d2b6c6ac3780
8341d6c cmake: move regcomp and futimens checks to "features.h" pks-t Jul 4, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/8341d6cf839d46dc382db96b7dd50ec9777e7244
dd332e2 cmake: use absolute path to deps pks-t Jun 23, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/dd332e2a9be13bbf68532b268d72112f301247bf
8e31cc2 cmake: keep track of libraries and includes via lists pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/8e31cc258008630e5790ab968bf435c891b74da9
32a2e50 cmake: inline TARGET_OS_LIBRARIES function pks-t Jul 1, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/32a2e5001c41c56ba02bd03b8656033ec6af7ea0
c363513 cmake: move definition of Win32 flags together pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/c3635130d8938ac9ce4625de9ff90a848b6064d5
8ee90c3 cmake: find dependencies after setting build flags pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/8ee90c3939bec73432fd6a97d3a15f632dafe64e
bed7ca3 cmake: define WIN_RC with other platform sources pks-t Jun 30, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/bed7ca3a3d73b06c2f97d10376607c022550aef3
4324850 cmake: move winhttp build instructions into subdirectory pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/432485001593d25c6900acbd17f089e056ce91d2
9e449e5 cmake: move regex build instructions into subdirectory pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/9e449e521456227477458999817c85bde00f0a0f
b751455 cmake: move http-parser build instructions into subdirectory pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/b75145549704e7118f7802b42d1e72ac9ff69b6f
1f43a43 cmake: move zlib build instructions into subdirectory pks-t Jun 28, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/1f43a43dcef50e9ab77a0468045f334b3217e5b4
72f27cb cmake: fix up source and binary directory paths pks-t Jun 30, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/72f27cb68be553ba0c8bd99b3c83e49487d1c87d
e5c9723 cmake: move library build instructions into subdirectory pks-t Jun 30, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/e5c9723d09e2463af14351c056922d3a802e9f26
8a43161 cmake: always include our own headers first pks-t Jul 5, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/8a43161b6b55f6ef434c7add945ee63cabfb0684
a3a3547 cmake: fix output location of import libraries and DLLs pks-t Aug 17, 2017 https://github.com/libgit2/libgit2/pull/4282/commits/a3a354738f94cf29e0572d0d83ef937e0d94968f
Clear filters https://github.com/libgit2/libgit2/pull/4282/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4282/files
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4282/files
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-02e62c52adcba4a1ce5bd9aaa98bdb6b102df4169d15e20965ce794e0c91ad75
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-788eb4247d6c39d6e9bb6e9557a9ad95a075f947c8120614a137fb2a29fc85be
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-0a378359215a9a4ee008304c854d1bd956b9b4149d2bb41880a8a4b56b645286
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-8bc816bd6da3f7d1c6913df3b7cdf7f600024b1242706db76524df7e8c06f001
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-940e5356fa1137e646ea135a6f68cacbfad4fe7124c3a69163468f588acf9283
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-148715d6ea0c0ea0a346af3f6bd610d010d490eca35ac6a9b408748f7ca9e3f4
common.h https://github.com/libgit2/libgit2/pull/4282/files#diff-649a0b286b520f22da501867c812f1acbc760fe028ea70edb14b60672ba7c716
features.h.in https://github.com/libgit2/libgit2/pull/4282/files#diff-d91c101720fafe94076836d8045df760c3d918f0f39104d9ef857f5c664d1bb5
posix.h https://github.com/libgit2/libgit2/pull/4282/files#diff-3820e0c93563eea6d6d310bdef6b065dfae3748513769a3e349dcf50b1a262a5
CMakeLists.txt https://github.com/libgit2/libgit2/pull/4282/files#diff-4461c617ceae0c7e0206622aacdf555aedd62eb129c2efb74c84fa1567bcbe0d
precompiled.c https://github.com/libgit2/libgit2/pull/4282/files#diff-d696a7aa23b1409903dabbba492a369f03d89d1b679589ac1a8d337165f770aa
precompiled.h https://github.com/libgit2/libgit2/pull/4282/files#diff-16677cbefc281223ac7cdd04d2698dd2b72767e2fad5320145b3ea69c03d68e7
CMakeLists.txthttps://github.com/libgit2/libgit2/pull/4282/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
View file https://github.com/pks-t/libgit2/blob/a3a354738f94cf29e0572d0d83ef937e0d94968f/CMakeLists.txt
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4282/files
deps/http-parser/CMakeLists.txthttps://github.com/libgit2/libgit2/pull/4282/files#diff-02e62c52adcba4a1ce5bd9aaa98bdb6b102df4169d15e20965ce794e0c91ad75
View file https://github.com/pks-t/libgit2/blob/a3a354738f94cf29e0572d0d83ef937e0d94968f/deps/http-parser/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4282/{{ revealButtonHref }}
deps/regex/CMakeLists.txthttps://github.com/libgit2/libgit2/pull/4282/files#diff-788eb4247d6c39d6e9bb6e9557a9ad95a075f947c8120614a137fb2a29fc85be
View file https://github.com/pks-t/libgit2/blob/a3a354738f94cf29e0572d0d83ef937e0d94968f/deps/regex/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4282/{{ revealButtonHref }}
deps/winhttp/CMakeLists.txthttps://github.com/libgit2/libgit2/pull/4282/files#diff-0a378359215a9a4ee008304c854d1bd956b9b4149d2bb41880a8a4b56b645286
View file https://github.com/pks-t/libgit2/blob/a3a354738f94cf29e0572d0d83ef937e0d94968f/deps/winhttp/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4282/{{ revealButtonHref }}
deps/zlib/CMakeLists.txthttps://github.com/libgit2/libgit2/pull/4282/files#diff-8bc816bd6da3f7d1c6913df3b7cdf7f600024b1242706db76524df7e8c06f001
View file https://github.com/pks-t/libgit2/blob/a3a354738f94cf29e0572d0d83ef937e0d94968f/deps/zlib/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4282/{{ revealButtonHref }}
examples/CMakeLists.txthttps://github.com/libgit2/libgit2/pull/4282/files#diff-940e5356fa1137e646ea135a6f68cacbfad4fe7124c3a69163468f588acf9283
View file https://github.com/pks-t/libgit2/blob/a3a354738f94cf29e0572d0d83ef937e0d94968f/examples/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/libgit2/libgit2/pull/4282/{{ revealButtonHref }}
https://github.com/libgit2/libgit2/pull/4282/files#diff-940e5356fa1137e646ea135a6f68cacbfad4fe7124c3a69163468f588acf9283
Please reload this pagehttps://github.com/libgit2/libgit2/pull/4282/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.