René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Regression in git_index_write_tree_to","articleBody":"This is a regression, it works fine with 0.27\r\n\r\nFound while upgrading pygit2 to v0.28, see https://travis-ci.org/libgit2/pygit2/jobs/503956525#L1044\r\nThis is the only test failure in the pygit2 test suite, it blocks release of pygit2 0.28.0\r\n\r\n### Reproduction steps\r\n\r\nPrepare the repositories:\r\n\r\n```bash\r\n$ git init src\r\nInitialized empty Git repository in [...]/src/.git/\r\n$ cat - \u003e src/hello.txt\r\nworld\r\n^D\r\n$ cd src\r\n$ git add hello.txt \r\n$ cd ..\r\n$ git init dst\r\nInitialized empty Git repository in [...]/dst/.git/\r\n```\r\n\r\nRun the following program:\r\n\r\n```c\r\n#include \u003cstdio.h\u003e\r\n#include \u003cgit2.h\u003e                                                                                                      \r\n                                                                                                                       \r\nint main()                                                                                                             \r\n{                                                                                                                      \r\n    char hex[GIT_OID_HEXSZ+1] = {0};\r\n    int err;\r\n    git_repository *src, *dst;                                                                                         \r\n    git_index *index;\r\n    git_oid id;\r\n    \r\n    git_libgit2_init();                                                                                                \r\n    \r\n    err = git_repository_open(\u0026src, \"src\");                                                                            \r\n    err = git_repository_open(\u0026dst, \"dst\");\r\n    err = git_repository_index(\u0026index, src);\r\n    \r\n/*\r\n    err = git_index_write_tree(\u0026id, index);\r\n    if (err \u003c 0) {\r\n        printf(\"git_index_write ERROR\\n\");\r\n        printf(\"%s\\n\", giterr_last()-\u003emessage);\r\n        return 1;\r\n    } else {\r\n        git_oid_fmt(hex, \u0026id);\r\n        printf(\"git_index_write SUCCESS %s\\n\", hex);\r\n    }\r\n*/\r\n\r\n    err = git_index_write_tree_to(\u0026id, index, dst);\r\n    if (err \u003c 0) {\r\n        printf(\"git_index_write_to ERROR\\n\");\r\n        printf(\"%s\\n\", giterr_last()-\u003emessage);\r\n        return 1;\r\n    } else {\r\n        git_oid_fmt(hex, \u0026id);\r\n        printf(\"git_index_write_to SUCCESS %s\\n\", hex);\r\n    }\r\n    \r\n    return 0;\r\n}                                                    \r\n```\r\n\r\n### Expected behavior\r\n\r\nExpected output:\r\n\r\n```bash\r\n$ gcc bug.c -lgit2 \u0026\u0026 ./a.out \r\ngit_index_write_to SUCCESS 7f2dbfa479cbe99062de2ef82b713f044c4406d8\r\n```\r\n\r\n### Actual behavior\r\n\r\nActual output:\r\n\r\n```bash\r\n$ gcc bug.c -lgit2 \u0026\u0026 ./a.out \r\ngit_index_write_to ERROR\r\nfailed to insert entry: invalid object specified - hello.txt\r\n``` \r\n\r\nIf you uncomment the commented block in the c program above, then it works.\r\n\r\n### Version of libgit2 (release number or SHA1)\r\n\r\n0.28.1\r\n\r\n### Operating system(s) tested\r\n\r\nGentoo Linux, and Travis (Ubuntu Linux)","author":{"url":"https://github.com/jdavid","@type":"Person","name":"jdavid"},"datePublished":"2019-03-09T17:48:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/5015/libgit2/issues/5015"}