Title: revwalk hide callback not changeable? · Issue #4887 · libgit2/libgit2 · GitHub
Open Graph Title: revwalk hide callback not changeable? · Issue #4887 · libgit2/libgit2
X Title: revwalk hide callback not changeable? · Issue #4887 · libgit2/libgit2
Description: The documentation for git_revwalk_new says This revision walker uses a custom memory pool and an internal commit cache, so it is relatively expensive to allocate. For maximum performance, this revision walker should be reused for differe...
Open Graph Description: The documentation for git_revwalk_new says This revision walker uses a custom memory pool and an internal commit cache, so it is relatively expensive to allocate. For maximum performance, this revi...
X Description: The documentation for git_revwalk_new says This revision walker uses a custom memory pool and an internal commit cache, so it is relatively expensive to allocate. For maximum performance, this revi...
Opengraph URL: https://github.com/libgit2/libgit2/issues/4887
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"revwalk hide callback not changeable?","articleBody":"The documentation for *git_revwalk_new* says\r\n\r\n\u003e This revision walker uses a custom memory pool and an internal commit cache, so it is relatively expensive to allocate.\r\n\u003e \r\n\u003e For maximum performance, this revision walker should be reused for different walks.\r\n\r\nThis is facilitated by *git_revwalk_reset* which removes all state on the revwalk object *except* (it seems) the hide callback function. This would be fine if I could just unset the callback myself, but *git_revwalk_add_hide_cb* errors out if a callback is already set, even if all I'm trying to do is to set it to `NULL`.\r\n\r\nSo it seems in the current state that the revwalk object can be reused but only if you want to use the same callback function. This seems a little restrictive, and I don't see any reason why we can't change the callback, either in *git_revwalk_add_hide_cb* or *git_revwalk_reset*, or both.\r\n\r\nI'd be happy to submit a fix so long as someone indicates which solution is preferable.","author":{"url":"https://github.com/TheBB","@type":"Person","name":"TheBB"},"datePublished":"2018-11-14T14:24:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/4887/libgit2/issues/4887"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f79940e2-f738-ecaa-6df0-2c7686656a8c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 86B0:1FC015:3A26C95:4FCA53B:6A5DEE94 |
| html-safe-nonce | 683a3b50a4a7024aaf401f269a19cd58c7fe120be9c581da34f8c9870123c180 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkIwOjFGQzAxNTozQTI2Qzk1OjRGQ0E1M0I6NkE1REVFOTQiLCJ2aXNpdG9yX2lkIjoiODAwNjc4Mjg0ODI1MDYzMDYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 55dd625eb3ec02a495a88fc7ec9907105b14ce534ab26e8f0acdf61bd4dd3505 |
| hovercard-subject-tag | issue:380721690 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/libgit2/libgit2/4887/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1e9283cd29a9d016b04995b05e96c516e8480cfb9b5f834e71485fa0a1992e09/libgit2/libgit2/issues/4887 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e9283cd29a9d016b04995b05e96c516e8480cfb9b5f834e71485fa0a1992e09/libgit2/libgit2/issues/4887 |
| og:image:alt | The documentation for git_revwalk_new says This revision walker uses a custom memory pool and an internal commit cache, so it is relatively expensive to allocate. For maximum performance, this revi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TheBB |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8e8f322dc74b1a8d5bafb296008dbb96bb4a0bc6ee2d6f30844ab111697c520d |
| turbo-cache-control | no-preview |
| go-import | github.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git |
| octolytics-dimension-user_id | 394745 |
| octolytics-dimension-user_login | libgit2 |
| octolytics-dimension-repository_id | 901662 |
| octolytics-dimension-repository_nwo | libgit2/libgit2 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 901662 |
| octolytics-dimension-repository_network_root_nwo | libgit2/libgit2 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ae00b343090b49d0d18b8184187f51a39ed917c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width