René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"git_ignore_path_is_ignored documentation misleading?","articleBody":"Due to an issue experienced elsewhere (https://github.com/git-tfs/git-tfs/issues/1208), I've stumbled across `git_ignore_path_is_ignored()` function from \"libgit2\", where it returned TRUE for a path already committed to the repository.\r\n\r\nI instantly thought this was a bug, as something already tracked shouldn't be subject to \".gitignore\" exclude rules (think [`git check-ignore`][1]), but eventually reading `git_ignore_path_is_ignored()` description, this seems to be by design...?\r\n\r\nhttps://github.com/libgit2/libgit2/blob/89c332e41b12a72d89de40d63bc568c56a2c336a/include/git2/ignore.h#L56-L60\r\n\r\nI guess there is a good reason for this (like making ignore rules parsing standalone, where one can check for index existence elsewhere... or something), but additional comment that follows seems misleading:\r\n\r\nhttps://github.com/libgit2/libgit2/blob/89c332e41b12a72d89de40d63bc568c56a2c336a/include/git2/ignore.h#L62-L63\r\n\r\nThis is not correct in the above mentioned case of an already tracked file, as even if it matches a pattern inside \".gitignore\", `git add .` will add modifications of that file to index, where `git_ignore_path_is_ignored()` will still return TRUE as if the file is to be ignored (which is not true).\r\n\r\nOf course, in case file is untracked, `git add .` will ignore it as expected (not adding it to index), and `git_ignore_path_is_ignored()` returning TRUE would make sense... just that it doesn't align with `git add .` in general, but in some case(s) only.\r\n\r\nShould this `git add .` comparison be dropped (or somehow reworded) to avoid confusion, or am I missing something?\r\n\r\nThanks, Buga\r\n\r\n[1]: https://git-scm.com/docs/git-check-ignore","author":{"url":"https://github.com/boogisha","@type":"Person","name":"boogisha"},"datePublished":"2018-07-10T21:17:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/4720/libgit2/issues/4720"}