Title: Rename git_push_transfer_progress to git_push_transfer_progress_cb · Issue #4654 · libgit2/libgit2 · GitHub
Open Graph Title: Rename git_push_transfer_progress to git_push_transfer_progress_cb · Issue #4654 · libgit2/libgit2
X Title: Rename git_push_transfer_progress to git_push_transfer_progress_cb · Issue #4654 · libgit2/libgit2
Description: Since git_push_transfer_progress is a callback, could it be renamed to git_push_transfer_progress_cb instead? NodeGit's code generator currently does not flag it as a callback because of this (see nodegit/nodegit#1500) The other members ...
Open Graph Description: Since git_push_transfer_progress is a callback, could it be renamed to git_push_transfer_progress_cb instead? NodeGit's code generator currently does not flag it as a callback because of this (see ...
X Description: Since git_push_transfer_progress is a callback, could it be renamed to git_push_transfer_progress_cb instead? NodeGit's code generator currently does not flag it as a callback because of this (...
Opengraph URL: https://github.com/libgit2/libgit2/issues/4654
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Rename git_push_transfer_progress to git_push_transfer_progress_cb","articleBody":"Since `git_push_transfer_progress` is a callback, could it be renamed to `git_push_transfer_progress_cb` instead? NodeGit's code generator currently does not flag it as a callback because of this (see nodegit/nodegit#1500) The other members in the `git_remote_callbacks` struct follow the same convention like `git_cred_acquire_cb`, `git_transfer_progress_cb`, `git_push_update_reference_cb`, and so on.\r\n\r\nBut I guess this ship has long sailed already?\r\n\r\n### Version of libgit2 (release number or SHA1)\r\nValid in `HEAD` https://github.com/libgit2/libgit2/blob/f9cf9a04ba61cba7b1112764dd25c0e4638bed75/include/git2/remote.h#L460-L466\r\n\r\nhttps://github.com/libgit2/libgit2/blob/f9cf9a04ba61cba7b1112764dd25c0e4638bed75/include/git2/remote.h#L350-L355","author":{"url":"https://github.com/rcjsuen","@type":"Person","name":"rcjsuen"},"datePublished":"2018-05-24T21:33:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/4654/libgit2/issues/4654"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e9d46945-9123-6596-5906-ca02fd677107 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D328:2C32F8:443929C:5A21D15:6A5D7B2E |
| html-safe-nonce | 2df6d94a25fdab8d504bb9a5c841a320922e56ca9b55d8d8d3e36ae124d63b69 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzI4OjJDMzJGODo0NDM5MjlDOjVBMjFEMTU6NkE1RDdCMkUiLCJ2aXNpdG9yX2lkIjoiMzI5MzY3NTAxMzY1Mjk3MDI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a85e96442ef56abce4f5975b5554c496f098acaa017bacba4b28b4477a360b4c |
| hovercard-subject-tag | issue:326303398 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/libgit2/libgit2/4654/issue_layout |
| twitter:image | https://opengraph.githubassets.com/420c26892a29442a1ce9d8760a5883d49df3b03996d42477777d61f15fc4f1fa/libgit2/libgit2/issues/4654 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/420c26892a29442a1ce9d8760a5883d49df3b03996d42477777d61f15fc4f1fa/libgit2/libgit2/issues/4654 |
| og:image:alt | Since git_push_transfer_progress is a callback, could it be renamed to git_push_transfer_progress_cb instead? NodeGit's code generator currently does not flag it as a callback because of this (see ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rcjsuen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| go-import | github.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git |
| octolytics-dimension-user_id | 394745 |
| octolytics-dimension-user_login | libgit2 |
| octolytics-dimension-repository_id | 901662 |
| octolytics-dimension-repository_nwo | libgit2/libgit2 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 901662 |
| octolytics-dimension-repository_network_root_nwo | libgit2/libgit2 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width