Title: No longer possible to add libgit2 to another cmake project with add_subdirectory · Issue #4381 · libgit2/libgit2 · GitHub
Open Graph Title: No longer possible to add libgit2 to another cmake project with add_subdirectory · Issue #4381 · libgit2/libgit2
X Title: No longer possible to add libgit2 to another cmake project with add_subdirectory · Issue #4381 · libgit2/libgit2
Description: Since #4282 (72f27cb in particular) it's no longer possible to add libgit2 to another cmake project with add_subdirectory. The uses of CMAKE_CURRENT_SOURCE_DIR changed to CMAKE_SOURCE_DIR which only works if libgit2 is the root project. ...
Open Graph Description: Since #4282 (72f27cb in particular) it's no longer possible to add libgit2 to another cmake project with add_subdirectory. The uses of CMAKE_CURRENT_SOURCE_DIR changed to CMAKE_SOURCE_DIR which onl...
X Description: Since #4282 (72f27cb in particular) it's no longer possible to add libgit2 to another cmake project with add_subdirectory. The uses of CMAKE_CURRENT_SOURCE_DIR changed to CMAKE_SOURCE_DIR which...
Opengraph URL: https://github.com/libgit2/libgit2/issues/4381
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"No longer possible to add libgit2 to another cmake project with add_subdirectory","articleBody":"Since #4282 (72f27cb68be553ba0c8bd99b3c83e49487d1c87d in particular) it's no longer possible to add libgit2 to another cmake project with add_subdirectory. The uses of `CMAKE_CURRENT_SOURCE_DIR` changed to `CMAKE_SOURCE_DIR` which only works if libgit2 is the root project. I'd suggest that cmake list files in subdirectories that need to refer to the root of the libgit2 source tree should use [libgit2_SOURCE_DIR](https://cmake.org/cmake/help/latest/variable/PROJECT-NAME_SOURCE_DIR.html) instead.","author":{"url":"https://github.com/hackhaslam","@type":"Person","name":"hackhaslam"},"datePublished":"2017-10-19T18:33:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/4381/libgit2/issues/4381"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1958b362-ec50-d694-d805-bdba1aa36843 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 812E:1F2D8B:27C3612:34F076D:6A5D8B88 |
| html-safe-nonce | 0e02cd5bd38f7353c6798c90b539678cc86aea3a572c0bd8d79a2ee1fa67c083 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTJFOjFGMkQ4QjoyN0MzNjEyOjM0RjA3NkQ6NkE1RDhCODgiLCJ2aXNpdG9yX2lkIjoiNjE1NjQxMDMxMTQ2NDAyOTA2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c404038720b949802dfc4d802b765bce45c21eece7b00aadbb411bd3a616b9ce |
| hovercard-subject-tag | issue:266944517 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/libgit2/libgit2/4381/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8de61b1fa4e3e152b39f595c2fed30888677e0c8726226c8aca1b671c53103b8/libgit2/libgit2/issues/4381 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8de61b1fa4e3e152b39f595c2fed30888677e0c8726226c8aca1b671c53103b8/libgit2/libgit2/issues/4381 |
| og:image:alt | Since #4282 (72f27cb in particular) it's no longer possible to add libgit2 to another cmake project with add_subdirectory. The uses of CMAKE_CURRENT_SOURCE_DIR changed to CMAKE_SOURCE_DIR which onl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hackhaslam |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| go-import | github.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git |
| octolytics-dimension-user_id | 394745 |
| octolytics-dimension-user_login | libgit2 |
| octolytics-dimension-repository_id | 901662 |
| octolytics-dimension-repository_nwo | libgit2/libgit2 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 901662 |
| octolytics-dimension-repository_network_root_nwo | libgit2/libgit2 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width