Title: coalesce() is never called within git_blame__like_git() · Issue #2658 · libgit2/libgit2 · GitHub
Open Graph Title: coalesce() is never called within git_blame__like_git() · Issue #2658 · libgit2/libgit2
X Title: coalesce() is never called within git_blame__like_git() · Issue #2658 · libgit2/libgit2
Description: Found with Clang warnings: void git_blame__like_git(git_blame *blame, uint32_t opt) { while (true) { git_blame__entry *ent; git_blame__origin *suspect = NULL; /* Find a suspect to break down */ for (ent = blame->ent; !suspect && ent; ent...
Open Graph Description: Found with Clang warnings: void git_blame__like_git(git_blame *blame, uint32_t opt) { while (true) { git_blame__entry *ent; git_blame__origin *suspect = NULL; /* Find a suspect to break down */ for...
X Description: Found with Clang warnings: void git_blame__like_git(git_blame *blame, uint32_t opt) { while (true) { git_blame__entry *ent; git_blame__origin *suspect = NULL; /* Find a suspect to break down */ for...
Opengraph URL: https://github.com/libgit2/libgit2/issues/2658
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"coalesce() is never called within git_blame__like_git()","articleBody":"Found with Clang warnings:\n\n```\nvoid git_blame__like_git(git_blame *blame, uint32_t opt)\n{\n while (true) {\n git_blame__entry *ent;\n git_blame__origin *suspect = NULL;\n\n /* Find a suspect to break down */\n for (ent = blame-\u003eent; !suspect \u0026\u0026 ent; ent = ent-\u003enext)\n if (!ent-\u003eguilty)\n suspect = ent-\u003esuspect;\n if (!suspect)\n return; /* all done */\n\n /* We'll use this suspect later in the loop, so hold on to it for now. */\n origin_incref(suspect);\n pass_blame(blame, suspect, opt);\n\n /* Take responsibility for the remaining entries */\n for (ent = blame-\u003eent; ent; ent = ent-\u003enext) {\n if (same_suspect(ent-\u003esuspect, suspect)) {\n ent-\u003eguilty = true;\n ent-\u003eis_boundary = !git_oid_cmp(\n git_commit_id(suspect-\u003ecommit),\n \u0026blame-\u003eoptions.oldest_commit);\n }\n }\n origin_decref(suspect);\n }\n\n coalesce(blame); \u003c----------- NEVER EXECUTED\n}\n```\n","author":{"url":"https://github.com/swisspol","@type":"Person","name":"swisspol"},"datePublished":"2014-10-26T17:05:04.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/2658/libgit2/issues/2658"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d6268c58-ff93-de01-1ace-9959fb9b5f9e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CF98:3A2E8:50ED1D7:6BCF445:6A5DBB82 |
| html-safe-nonce | c14c5228cf6f24a1d15bbe7990789fdfceafb5367ee46750a98777498089287b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjk4OjNBMkU4OjUwRUQxRDc6NkJDRjQ0NTo2QTVEQkI4MiIsInZpc2l0b3JfaWQiOiI3MDQyMjQ5OTg3NzMzNjk5NDU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4dfd13b158855e9ffab246ab82594b5640a2dcf8dbcde31a7e0fb28b178684aa |
| hovercard-subject-tag | issue:46848098 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/libgit2/libgit2/2658/issue_layout |
| twitter:image | https://opengraph.githubassets.com/20d8cac8a3af2e956560f3f439799f472f8ebd599cabf91d17896a00d6cde724/libgit2/libgit2/issues/2658 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/20d8cac8a3af2e956560f3f439799f472f8ebd599cabf91d17896a00d6cde724/libgit2/libgit2/issues/2658 |
| og:image:alt | Found with Clang warnings: void git_blame__like_git(git_blame *blame, uint32_t opt) { while (true) { git_blame__entry *ent; git_blame__origin *suspect = NULL; /* Find a suspect to break down */ for... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | swisspol |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| go-import | github.com/libgit2/libgit2 git https://github.com/libgit2/libgit2.git |
| octolytics-dimension-user_id | 394745 |
| octolytics-dimension-user_login | libgit2 |
| octolytics-dimension-repository_id | 901662 |
| octolytics-dimension-repository_nwo | libgit2/libgit2 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 901662 |
| octolytics-dimension-repository_network_root_nwo | libgit2/libgit2 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width