Title: Members of the Learning Equality code reviewers team are treated as contributors · Issue #139 · learningequality/.github · GitHub
Open Graph Title: Members of the Learning Equality code reviewers team are treated as contributors · Issue #139 · learningequality/.github
X Title: Members of the Learning Equality code reviewers team are treated as contributors · Issue #139 · learningequality/.github
Description: ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Observed behavior The automations treat members of the Learning Equality code reviewers tea...
Open Graph Description: ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Observed behavior The automations treat members of ...
X Description: ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Observed behavior The automations treat members of ...
Opengraph URL: https://github.com/learningequality/.github/issues/139
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Members of the Learning Equality code reviewers team are treated as contributors","articleBody":"\u003c!---HEADER START-->\n\n\u003cimg height=\"20px\" src=\"https://i.imgur.com/c7hUeb5.jpeg\">\n\n❌ **This issue is not open for contribution. Visit \u003ca href=\"https://learningequality.org/contributing-to-our-open-code-base/\" target=\"_blank\">Contributing guidelines\u003c/a>** to learn about the contributing process and how to find suitable issues.\n\n\u003cimg height=\"20px\" src=\"https://i.imgur.com/c7hUeb5.jpeg\">\n\n\u003c!---HEADER END-->\n\n## Observed behavior\n\nThe automations treat members of the [Learning Equality code reviewers](https://github.com/orgs/learningequality/teams/learning-equality-code-reviewers) team as community contributors.\n\nFor example, pcenov opened learningequality/kolibri#15827. The issue validation workflow posted its contributor greeting and asked rtibblesbot to validate the issue. pcenov is an active member of `learning-equality-code-reviewers`, so this should not have happened.\n\n#134 changed maintainer detection to use team membership. `MAINTAINER_TEAMS` in `scripts/constants.js` lists only these teams:\n\n- `le-admins-team`\n- `read-only-coding-agents`\n- `triaging-coding-agents`\n\n`learning-equality-code-reviewers` is not on the list. Team members who are in none of the three teams fail the maintainer check.\n\n## Expected behavior\n\nA member of `learning-equality-code-reviewers` is a maintainer. The automations do not treat them as a contributor on issues, comments, or pull requests.\n\n## Steps to reproduce\n\n1. Use an account that is in `learning-equality-code-reviewers` and in none of the teams in `MAINTAINER_TEAMS`.\n2. Open an issue in a repo listed in `ISSUE_VALIDATION_REPOS`, for example `test-actions`.\n3. The bot posts the \"Thanks for opening this issue!\" comment and adds the `community-issue-review` label.\n\n## Deliverables\n\n- Members of `learning-equality-code-reviewers` pass the maintainer check in every workflow that uses `isContributor` or `isMaintainer`.\n- A test in `scripts/is-contributor.test.js` covers a user who is only in `learning-equality-code-reviewers`.\n- `docs/testing-automations.md` still describes the maintainer teams correctly.\n\n## Technical pointers\n\n- `scripts/constants.js`: `MAINTAINER_TEAMS`\n- `scripts/utils.js`: `isMaintainer` checks each team with `teams.getMembershipForUserInOrg`.\n- Callers of the maintainer check:\n - `scripts/is-contributor.js`, which these workflows use: `issue-validation`, `contributor-issue-comment`, `contributor-pr-reply`, `pull-request-label`, `review-requested`, and `holiday-message`.\n - `scripts/pull-request-template.js`\n - `scripts/update-pr-spreadsheet.js`\n- #134 notes an open risk: it did not confirm that the app token can read membership of every team. Check this for the new team too.\n\n## AI usage\n\nClaude Code drafted this issue from a maintainer's report. It read the code on `main`, confirmed pcenov's team membership with the GitHub API, and found the workflows that call the maintainer check.\n","author":{"url":"https://github.com/bjester","@type":"Person","name":"bjester"},"datePublished":"2026-11-12T16:28:42Z","url":"https://github.com/learningequality/.github/issues/139"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e09b04e4-1b51-c6e7-2585-af5857cd2684 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B450:3EE843:17BE9FB:200354D:6AFFF378 |
| html-safe-nonce | 34ca828067d1d77a4e997fe1dbf66d2ce23aac54832d543d303a999723532720 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDUwOjNFRTg0MzoxN0JFOUZCOjIwMDM1NEQ6NkFGRkYzNzgiLCJ2aXNpdG9yX2lkIjoiNDIyMTcwNDAxMTk0Nzk2MzI1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4bbad0d31c401c5849cfc0b89b4f16e4477838821d8f34fa746a33336b443eaa |
| hovercard-subject-tag | issue:6354283981 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/learningequality/.github/139/issue_layout |
| twitter:image | https://opengraph.githubassets.com/853bad11cc30a9f89e4cdee4d7a5d29f8aff3fe27e21b23aa42dac78d460399d/learningequality/.github/issues/139 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/853bad11cc30a9f89e4cdee4d7a5d29f8aff3fe27e21b23aa42dac78d460399d/learningequality/.github/issues/139 |
| og:image:alt | ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Observed behavior The automations treat members of ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bjester |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/learningequality/.github git https://github.com/learningequality/.github.git |
| octolytics-dimension-user_id | 3926525 |
| octolytics-dimension-user_login | learningequality |
| octolytics-dimension-repository_id | 647407699 |
| octolytics-dimension-repository_nwo | learningequality/.github |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 647407699 |
| octolytics-dimension-repository_network_root_nwo | learningequality/.github |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width