Title: Two /assign comments at once can both pass the assignment limit · Issue #107 · learningequality/.github · GitHub
Open Graph Title: Two /assign comments at once can both pass the assignment limit · Issue #107 · learningequality/.github
X Title: Two /assign comments at once can both pass the assignment limit · Issue #107 · learningequality/.github
Description: ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Overview Two /assign comments seconds apart both pass the two issue limit. Each run counts ...
Open Graph Description: ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Overview Two /assign comments seconds apart both pa...
X Description: ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Overview Two /assign comments seconds apart both pa...
Opengraph URL: https://github.com/learningequality/.github/issues/107
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Two /assign comments at once can both pass the assignment limit","articleBody":"\u003c!---HEADER START-->\n\n\u003cimg height=\"20px\" src=\"https://i.imgur.com/c7hUeb5.jpeg\">\n\n❌ **This issue is not open for contribution. Visit \u003ca href=\"https://learningequality.org/contributing-to-our-open-code-base/\" target=\"_blank\">Contributing guidelines\u003c/a>** to learn about the contributing process and how to find suitable issues.\n\n\u003cimg height=\"20px\" src=\"https://i.imgur.com/c7hUeb5.jpeg\">\n\n\u003c!---HEADER END-->\n\n## Overview\n\nTwo `/assign` comments seconds apart both pass the two issue limit. Each run counts the\ncontributor's assignments before the other has written one, so both see a free slot.\n\nA contributor was assigned to two issues this way on 30 September.\n\n**Complexity:** Low\n**Target branch:** main\n\n### Context\n\n`scripts/contributor-issue-comment.js:159` reads the contributor's open assigned issues and recent\nunassignments. Line 174 adds them into `totalSlots`, and line 176 declines at\n`MAX_ASSIGNED_ISSUES`. The assignment itself happens at line 183.\n\nNothing holds between the read and the write, so two runs interleave.\n\nWhat happened in `learningequality/kolibri`:\n\n| Time (30 Sep) | Event |\n|---|---|\n| 04:00:32 | `/assign` on #14080 |\n| 04:00:35 | `/assign` on #14623 |\n| 04:01:14 | assigned to #14080 |\n| 04:01:19 | assigned to #14623 |\n\nBoth runs read a count of zero. Neither decline fired. The contributor holds both issues.\n\n### The Change\n\nSerialize per contributor. Add a job level `concurrency` group to `process-issue-comment` in\n`.github/workflows/contributor-issue-comment.yml`, keyed on the commenting user:\n\n```yaml\n concurrency:\n group: assign-${{ github.event.comment.user.login }}\n cancel-in-progress: false\n```\n\n`cancel-in-progress` must stay false. A cancelled run drops a contributor's request with no reply.\n\n### Known limit of this fix\n\nA concurrency group is scoped to the repository the run executes in, which is the consumer repo.\nThe limit it protects is counted across every repo in `COMMUNITY_REPOS`.\n\nSo this fixes two `/assign` comments in the same repo, which is the observed case. Two comments in\ndifferent repos at the same moment still race. Closing that needs a different approach, such as\nre-reading the count after assigning and unassigning when the limit turns out to be exceeded. That\nis out of scope here unless it is seen in practice.\n\n### Out of Scope\n\n- Changing `MAX_ASSIGNED_ISSUES` or the cooldown.\n- The cross-repo case described above.\n\n### Acceptance Criteria\n\n- [ ] `process-issue-comment` carries a concurrency group keyed on the commenting user.\n- [ ] The group does not cancel a run in progress.\n- [ ] Two `/assign` comments by the same contributor in one repo, seconds apart, result in one\n assignment and one decline.\n- [ ] Two `/assign` comments by different contributors still run at the same time.\n\n### Testing\n\nTest in `test-actions`. See\n[testing the automations](https://github.com/learningequality/.github/blob/main/docs/testing-automations.md).\nThe cases need an account outside the organization.\n\n1. Comment `/assign` on two `good first issue` issues within a few seconds, from one account.\n Expect one assignment and one decline naming the limit.\n2. Comment `/assign` from two different accounts at the same time. Expect both to be handled.\n\n### References\n\n- #104 gates a second assignment on an open pull request. It reads the same state through the same\n call, so it inherits this race until this lands.\n- Seen in learningequality/kolibri#14080 and learningequality/kolibri#14623.\n\n## AI usage\n\nI used Claude Code to read the two issue timelines, confirm that no unassignment took place, and\nfind the overlap between the two runs. I decided the fix and its scope.\n","author":{"url":"https://github.com/akolson","@type":"Person","name":"akolson"},"datePublished":"2026-10-01T07:38:24Z","url":"https://github.com/learningequality/.github/issues/107"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e3199d58-bdec-c905-17db-09e06e2bb46b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA8E:30DBED:24ACB04:2F7E62A:6AFFEC42 |
| html-safe-nonce | 5989651c40170dec20648d0aaae3ee4ba3d4746b29b6f53499125283ad0c8e9b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQThFOjMwREJFRDoyNEFDQjA0OjJGN0U2MkE6NkFGRkVDNDIiLCJ2aXNpdG9yX2lkIjoiNzc2MDMzMDk3MzAzMTQyNzEzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 448d1a0950f4fc7706075d88ef8094544da2b2d578aa24a5315f00dcdb5956f0 |
| hovercard-subject-tag | issue:5658713934 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/learningequality/.github/107/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c4c65d450787592106156007d0c2b7dde8cf8a202490196b0def125cb3fcaaf3/learningequality/.github/issues/107 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c4c65d450787592106156007d0c2b7dde8cf8a202490196b0def125cb3fcaaf3/learningequality/.github/issues/107 |
| og:image:alt | ❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues. Overview Two /assign comments seconds apart both pa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | akolson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/learningequality/.github git https://github.com/learningequality/.github.git |
| octolytics-dimension-user_id | 3926525 |
| octolytics-dimension-user_login | learningequality |
| octolytics-dimension-repository_id | 647407699 |
| octolytics-dimension-repository_nwo | learningequality/.github |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 647407699 |
| octolytics-dimension-repository_network_root_nwo | learningequality/.github |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width