| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e78a9aa0-0c2d-1628-740b-1a76bd859c7c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B00:115883:96FB2E:C636FE:696B54A8 |
| html-safe-nonce | de89786d293b5daba6c8501ef586a9b4d42503fc0edf5fcabf24828c41e7f520 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjAwOjExNTg4Mzo5NkZCMkU6QzYzNkZFOjY5NkI1NEE4IiwidmlzaXRvcl9pZCI6IjU5ODc0MDI5NDQ2MjM2Mjk0ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c59b7545d07e27d6275ee4e65e08e5c21cd8dbb785ee7a5ae6c0b561a040e60e |
| hovercard-subject-tag | pull_request:1720956660 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/lcompilers/lpython/2524/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7489a0cb50247cb4b0eefd7fd7c33b975b3254f09c48ea1ab07db154054e6afe/lcompilers/lpython/pull/2524 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7489a0cb50247cb4b0eefd7fd7c33b975b3254f09c48ea1ab07db154054e6afe/lcompilers/lpython/pull/2524 |
| og:image:alt | istitle and isalpha were implemented only for variables and not constant strings, so I added implementations and tests.
Moved their tests to test_str_attributesalong with all the other string metho... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | advikkabra |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/lcompilers/lpython git https://github.com/lcompilers/lpython.git |
| octolytics-dimension-user_id | 96538276 |
| octolytics-dimension-user_login | lcompilers |
| octolytics-dimension-repository_id | 442864346 |
| octolytics-dimension-repository_nwo | lcompilers/lpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 442864346 |
| octolytics-dimension-repository_network_root_nwo | lcompilers/lpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/lcompilers/lpython/pull/2524#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flcompilers%2Flpython%2Fpull%2F2524 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flcompilers%2Flpython%2Fpull%2F2524 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=lcompilers%2Flpython |
| Reload | https://github.com/lcompilers/lpython/pull/2524 |
| Reload | https://github.com/lcompilers/lpython/pull/2524 |
| Reload | https://github.com/lcompilers/lpython/pull/2524 |
|
lcompilers
| https://github.com/lcompilers |
| lpython | https://github.com/lcompilers/lpython |
|
Notifications
| https://github.com/login?return_to=%2Flcompilers%2Flpython |
|
Fork
173
| https://github.com/login?return_to=%2Flcompilers%2Flpython |
|
Star
1.6k
| https://github.com/login?return_to=%2Flcompilers%2Flpython |
|
Code
| https://github.com/lcompilers/lpython |
|
Issues
503
| https://github.com/lcompilers/lpython/issues |
|
Pull requests
85
| https://github.com/lcompilers/lpython/pulls |
|
Actions
| https://github.com/lcompilers/lpython/actions |
|
Projects
0
| https://github.com/lcompilers/lpython/projects |
|
Wiki
| https://github.com/lcompilers/lpython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/lcompilers/lpython/security |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
|
Insights
| https://github.com/lcompilers/lpython/pulse |
|
Code
| https://github.com/lcompilers/lpython |
|
Issues
| https://github.com/lcompilers/lpython/issues |
|
Pull requests
| https://github.com/lcompilers/lpython/pulls |
|
Actions
| https://github.com/lcompilers/lpython/actions |
|
Projects
| https://github.com/lcompilers/lpython/projects |
|
Wiki
| https://github.com/lcompilers/lpython/wiki |
|
Security
| https://github.com/lcompilers/lpython/security |
|
Insights
| https://github.com/lcompilers/lpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Flcompilers%2Flpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Flcompilers%2Flpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/lcompilers/lpython/pull/2524#issue-comment-box |
| certik | https://github.com/certik |
| lcompilers:main | https://github.com/lcompilers/lpython/tree/main |
| advikkabra:strattributes | https://github.com/advikkabra/lpython/tree/strattributes |
|
Refactor string attributes and add constant string implementations
| https://github.com/lcompilers/lpython/pull/2524#top |
| certik | https://github.com/certik |
| lcompilers:main | https://github.com/lcompilers/lpython/tree/main |
| advikkabra:strattributes | https://github.com/advikkabra/lpython/tree/strattributes |
|
Conversation
5
| https://github.com/lcompilers/lpython/pull/2524 |
|
Commits
9
| https://github.com/lcompilers/lpython/pull/2524/commits |
|
Checks
0
| https://github.com/lcompilers/lpython/pull/2524/checks |
|
Files changed
| https://github.com/lcompilers/lpython/pull/2524/files |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| https://github.co/hiddenchars |
| https://github.com/lcompilers/lpython/pull/{{ revealButtonHref }} |
|
| https://github.com/advikkabra |
| advikkabra | https://github.com/advikkabra |
| Feb 11, 2024 | https://github.com/lcompilers/lpython/pull/2524#issue-2128998335 |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| advikkabra | https://github.com/advikkabra |
| February 11, 2024 16:00 | https://github.com/lcompilers/lpython/pull/2524#commits-pushed-3d52754 |
|
| https://github.com/advikkabra |
| Refactoring string attributes to reduce redundant code | https://github.com/lcompilers/lpython/pull/2524/commits/3d527548106c17d6c8c358a45722697691e8c472 |
| 3d52754 | https://github.com/lcompilers/lpython/pull/2524/commits/3d527548106c17d6c8c358a45722697691e8c472 |
|
| https://github.com/advikkabra |
| Added constant string implementation of isalpha | https://github.com/lcompilers/lpython/pull/2524/commits/b880b0f2bf8418b0e2df3a20212037c7c97ac063 |
| b880b0f | https://github.com/lcompilers/lpython/pull/2524/commits/b880b0f2bf8418b0e2df3a20212037c7c97ac063 |
|
| https://github.com/advikkabra |
| Added constant string implementation of istitle | https://github.com/lcompilers/lpython/pull/2524/commits/baa71c4202ee7cc1b2a7a7caa1b504ecd1009a16 |
| baa71c4 | https://github.com/lcompilers/lpython/pull/2524/commits/baa71c4202ee7cc1b2a7a7caa1b504ecd1009a16 |
|
| https://github.com/advikkabra |
| Added isalpha tests for constant string implementation, and moved the… | https://github.com/lcompilers/lpython/pull/2524/commits/deed28246f78e6b1e9a50ca7d22e724fc59be440 |
| deed282 | https://github.com/lcompilers/lpython/pull/2524/commits/deed28246f78e6b1e9a50ca7d22e724fc59be440 |
|
| https://github.com/advikkabra |
| Added istitle tests for constant string implementation, and moved the… | https://github.com/lcompilers/lpython/pull/2524/commits/66eb5837d52996209c0be07ca4fb6e843d86c8d9 |
| 66eb583 | https://github.com/lcompilers/lpython/pull/2524/commits/66eb5837d52996209c0be07ca4fb6e843d86c8d9 |
|
| https://github.com/advikkabra |
| Rename function to follow convention | https://github.com/lcompilers/lpython/pull/2524/commits/35ffb95d009bde9facb649bce5a582a2ebe0fbf2 |
| 35ffb95 | https://github.com/lcompilers/lpython/pull/2524/commits/35ffb95d009bde9facb649bce5a582a2ebe0fbf2 |
|
| https://github.com/advikkabra |
| Fixed isalpha bug | https://github.com/lcompilers/lpython/pull/2524/commits/bebf5dcbca76d5d91825a0d9235bf4cb1ca20702 |
| bebf5dc | https://github.com/lcompilers/lpython/pull/2524/commits/bebf5dcbca76d5d91825a0d9235bf4cb1ca20702 |
|
| https://github.com/advikkabra |
| Removed redundant code in python istitle implementation | https://github.com/lcompilers/lpython/pull/2524/commits/90999bb573224cafa2da487b695327f40fc91372 |
| 90999bb | https://github.com/lcompilers/lpython/pull/2524/commits/90999bb573224cafa2da487b695327f40fc91372 |
| https://github.com/certik |
| certik | https://github.com/certik |
| Feb 11, 2024 | https://github.com/lcompilers/lpython/pull/2524#issuecomment-1937902145 |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| https://github.com/certik |
| certik | https://github.com/certik |
| February 11, 2024 22:53 | https://github.com/lcompilers/lpython/pull/2524#event-11768569349 |
| https://github.com/advikkabra |
| advikkabra | https://github.com/advikkabra |
| Feb 12, 2024 | https://github.com/lcompilers/lpython/pull/2524#issuecomment-1938172498 |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| https://github.com/advikkabra |
| advikkabra | https://github.com/advikkabra |
| Feb 12, 2024 | https://github.com/lcompilers/lpython/pull/2524#issuecomment-1938308430 |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| https://github.com/advikkabra |
| advikkabra | https://github.com/advikkabra |
| Feb 15, 2024 | https://github.com/lcompilers/lpython/pull/2524#issuecomment-1945310579 |
| @certik | https://github.com/certik |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| https://github.com/advikkabra |
| advikkabra | https://github.com/advikkabra |
| February 17, 2024 18:32 | https://github.com/lcompilers/lpython/pull/2524#event-11837024374 |
|
| https://github.com/advikkabra |
| Merge branch 'main' into strattributes | https://github.com/lcompilers/lpython/pull/2524/commits/b3bb6022d95f7ab8ffbc53b32fd7db7e3881549c |
| b3bb602 | https://github.com/lcompilers/lpython/pull/2524/commits/b3bb6022d95f7ab8ffbc53b32fd7db7e3881549c |
| https://github.com/certik |
| certik | https://github.com/certik |
|
Feb 18, 2024
| https://github.com/lcompilers/lpython/pull/2524#pullrequestreview-1887365611 |
|
View reviewed changes
| https://github.com/lcompilers/lpython/pull/2524/files/b3bb6022d95f7ab8ffbc53b32fd7db7e3881549c |
| certik | https://github.com/certik |
| https://github.com/lcompilers/lpython/pull/2524#pullrequestreview-1887365611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
| https://github.com/certik |
| certik | https://github.com/certik |
| 21ba898 | https://github.com/lcompilers/lpython/commit/21ba8986318d2e4c6ac7a2134435812a7e78b8f2 |
| Feb 18, 2024 | https://github.com/lcompilers/lpython/pull/2524#event-11842355810 |
| Agent-Hellboy | https://github.com/Agent-Hellboy |
|
Mar 5, 2024
| https://github.com/lcompilers/lpython/pull/2524#ref-commit-f5a772c |
|
| https://github.com/advikkabra |
|
| https://github.com/Agent-Hellboy |
| Refactor string attributes and add constant string implementations ( | https://github.com/Agent-Hellboy/lpython/commit/f5a772cf1811ab94ea871fd84c4ffc5d1ce0478d |
| l… | https://github.com/lcompilers/lpython/pull/2524 |
| f5a772c | https://github.com/Agent-Hellboy/lpython/commit/f5a772cf1811ab94ea871fd84c4ffc5d1ce0478d |
| …compilers#2524 | https://github.com/lcompilers/lpython/pull/2524 |
| hankluo6 | https://github.com/hankluo6 |
|
Mar 8, 2024
| https://github.com/lcompilers/lpython/pull/2524#ref-commit-be1ef3f |
|
| https://github.com/advikkabra |
|
| https://github.com/hankluo6 |
| Refactor string attributes and add constant string implementations ( | https://github.com/hankluo6/lpython/commit/be1ef3f93e834cec08843bd9d2ad220b99353b90 |
| l… | https://github.com/lcompilers/lpython/pull/2524 |
| be1ef3f | https://github.com/hankluo6/lpython/commit/be1ef3f93e834cec08843bd9d2ad220b99353b90 |
| …compilers#2524 | https://github.com/lcompilers/lpython/pull/2524 |
| https://github.com/advikkabra |
| advikkabra | https://github.com/advikkabra |
| July 21, 2024 13:22 | https://github.com/lcompilers/lpython/pull/2524#event-13592427904 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Flcompilers%2Flpython%2Fpull%2F2524 |
|
| https://github.com/certik |
|
certik
| https://github.com/certik |
|
| https://github.com/lcompilers/lpython/pull/2524/files/b3bb6022d95f7ab8ffbc53b32fd7db7e3881549c |
| Please reload this page | https://github.com/lcompilers/lpython/pull/2524 |
|
| https://github.com/advikkabra |
|
| https://github.com/certik |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |