René's URL Explorer Experiment


Title: Improve visibility of install problems by andyf0x · Pull Request #536 · joeferner/node-java · GitHub

Open Graph Title: Improve visibility of install problems by andyf0x · Pull Request #536 · joeferner/node-java

X Title: Improve visibility of install problems by andyf0x · Pull Request #536 · joeferner/node-java

Description: Hi @joeferner, I found while looking at some platform-specific installation problems, that these errors were not visible. This PR should help to address this. It adds some checks to make sure we have a valid Java home directory before attempting the build. I was also going to fix the version on package-lock file (omitted from 1621a7a when v0.12.2 was released), but Dependabot had already fixed it, so I'm including that here also. I should have another PR ready soon to address the actual platform-specific issues, but that's a little more involved, so figured it makes sense to separate the PR's.

Open Graph Description: Hi @joeferner, I found while looking at some platform-specific installation problems, that these errors were not visible. This PR should help to address this. It adds some checks to make sure we ha...

X Description: Hi @joeferner, I found while looking at some platform-specific installation problems, that these errors were not visible. This PR should help to address this. It adds some checks to make sure we ha...

Opengraph URL: https://github.com/joeferner/node-java/pull/536

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:95d71371-d2e2-2f0f-7677-166be1bbd65f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBCA:10FB47:4225E:59991:6AFD4833
html-safe-nonced4a1cd561ebba2d5ca17ec61f004c1e2ce151229516ae4c0900a828cc0e4d980
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkNBOjEwRkI0Nzo0MjI1RTo1OTk5MTo2QUZENDgzMyIsInZpc2l0b3JfaWQiOiI1NjE0NjcxMzA3NDQ3NTUyMDUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1ec9b71175a304f04b5497764efc7a33b5cc6fae1b9044c3b7d9b1cc8d196292
hovercard-subject-tagpull_request:759950214
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/joeferner/node-java/pull/536/files
twitter:imagehttps://avatars.githubusercontent.com/u/20788215?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20788215?s=400&v=4
og:image:altHi @joeferner, I found while looking at some platform-specific installation problems, that these errors were not visible. This PR should help to address this. It adds some checks to make sure we ha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/joeferner/node-java git https://github.com/joeferner/node-java.git
octolytics-dimension-user_id808857
octolytics-dimension-user_loginjoeferner
octolytics-dimension-repository_id3228734
octolytics-dimension-repository_nwojoeferner/node-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3228734
octolytics-dimension-repository_network_root_nwojoeferner/node-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/joeferner/node-java/pull/536/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F536%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F536%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=joeferner%2Fnode-java
Reloadhttps://github.com/joeferner/node-java/pull/536/files
Reloadhttps://github.com/joeferner/node-java/pull/536/files
Reloadhttps://github.com/joeferner/node-java/pull/536/files
joefernerhttps://github.com/joeferner
node-javahttps://github.com/joeferner/node-java
Codehttps://github.com/joeferner/node-java
Issues208 (208)https://github.com/joeferner/node-java/issues
Pull requests2 (2)https://github.com/joeferner/node-java/pulls
Actionshttps://github.com/joeferner/node-java/actions
Projectshttps://github.com/joeferner/node-java/projects
Wikihttps://github.com/joeferner/node-java/wiki
Security and qualityhttps://github.com/joeferner/node-java/security
Insightshttps://github.com/joeferner/node-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
joefernerhttps://github.com/joeferner
joeferner:masterhttps://github.com/joeferner/node-java/tree/master
andyf0x:masterhttps://github.com/andyf0x/node-java/tree/master
Conversation 0 https://github.com/joeferner/node-java/pull/536
Commits 3 https://github.com/joeferner/node-java/pull/536/commits
Checks 0 https://github.com/joeferner/node-java/pull/536/checks
Files changed https://github.com/joeferner/node-java/pull/536/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/536/files
Improve visibility of install problems https://github.com/joeferner/node-java/pull/536/files#top
Show all changes 3 commits https://github.com/joeferner/node-java/pull/536/files
5a5f1e7 Bump path-parse from 1.0.6 to 1.0.7 dependabot[bot] Aug 11, 2021 https://github.com/joeferner/node-java/pull/536/commits/5a5f1e79df8d41fe38be55a4419b7f026aae4f44
8f0952d Fix error check for bad javalib directory andyf0x Oct 16, 2021 https://github.com/joeferner/node-java/pull/536/commits/8f0952da9d2c334dac3d318f9761730e1f587795
88168d1 Exit with error if Java home can't be found andyf0x Oct 17, 2021 https://github.com/joeferner/node-java/pull/536/commits/88168d12446d91540a00ed78c18f144df2c9e234
Clear filters https://github.com/joeferner/node-java/pull/536/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/536/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/536/files
findJavaHome.js https://github.com/joeferner/node-java/pull/536/files#diff-bccc3776c53e773eb4ee0b7fa550f7b0c301219f79728edc582483780b9eef06
find_java_libdir.sh https://github.com/joeferner/node-java/pull/536/files#diff-125dd2a1a1e28b573e9ce05e69bd793b8c88c6a72e86ddcebe182980d2071a2f
package-lock.json https://github.com/joeferner/node-java/pull/536/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
findJavaHome.jshttps://github.com/joeferner/node-java/pull/536/files#diff-bccc3776c53e773eb4ee0b7fa550f7b0c301219f79728edc582483780b9eef06
View file https://github.com/andyf0x/node-java/blob/88168d12446d91540a00ed78c18f144df2c9e234/findJavaHome.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/536/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/536/files#diff-bccc3776c53e773eb4ee0b7fa550f7b0c301219f79728edc582483780b9eef06
find_java_libdir.shhttps://github.com/joeferner/node-java/pull/536/files#diff-125dd2a1a1e28b573e9ce05e69bd793b8c88c6a72e86ddcebe182980d2071a2f
View file https://github.com/andyf0x/node-java/blob/88168d12446d91540a00ed78c18f144df2c9e234/find_java_libdir.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/536/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/536/files#diff-125dd2a1a1e28b573e9ce05e69bd793b8c88c6a72e86ddcebe182980d2071a2f
https://github.com/joeferner/node-java/pull/536/files#diff-125dd2a1a1e28b573e9ce05e69bd793b8c88c6a72e86ddcebe182980d2071a2f
package-lock.jsonhttps://github.com/joeferner/node-java/pull/536/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
View file https://github.com/andyf0x/node-java/blob/88168d12446d91540a00ed78c18f144df2c9e234/package-lock.json
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/joeferner/node-java/pull/536/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.