René's URL Explorer Experiment


Title: Clarifications to Promises implementation (mostly documentation). by jimlloyd · Pull Request #189 · joeferner/node-java · GitHub

Open Graph Title: Clarifications to Promises implementation (mostly documentation). by jimlloyd · Pull Request #189 · joeferner/node-java

X Title: Clarifications to Promises implementation (mostly documentation). by jimlloyd · Pull Request #189 · joeferner/node-java

Description: @joeferner This PR mostly changes documentation about Promises. One significant change is that I figured out how to make this implementation work with the popular promises library Q. I also discovered the bluebird now works with node 0.8 after all. This means all 5 libraries I have test with pass all 6 cases in our test matrix. I also realized that since the three promisified methods of the java module are not promisified until onJvmCreated that they cannot be the first java method an application calls. For now, I just recommend calling another method such as java.import() first. I considered creating a public method java.finalizeInitialization(), which would call the internal method ensureJvm(), but it seemed more trouble than it was worth, at last at the moment.

Open Graph Description: @joeferner This PR mostly changes documentation about Promises. One significant change is that I figured out how to make this implementation work with the popular promises library Q. I also discove...

X Description: @joeferner This PR mostly changes documentation about Promises. One significant change is that I figured out how to make this implementation work with the popular promises library Q. I also discove...

Opengraph URL: https://github.com/joeferner/node-java/pull/189

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73b445c4-9f20-0038-7c5f-172e182b0d11
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE176:1A631D:148E06:1BE9F2:6AFD4D2E
html-safe-nonce3971d95057e042ff4cc742670e6b1a260ec55ed376ba3d376bfe85144bae4ff3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTc2OjFBNjMxRDoxNDhFMDY6MUJFOUYyOjZBRkQ0RDJFIiwidmlzaXRvcl9pZCI6IjQ0NDcyMTgwNDcyODI2NjI3MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfc82e4d493a0965e98fa6bc3427f7ce46e6ea37eebe23789fdf5b5ecef5a133b
hovercard-subject-tagpull_request:27450266
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/joeferner/node-java/pull/189/files
twitter:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
og:image:alt@joeferner This PR mostly changes documentation about Promises. One significant change is that I figured out how to make this implementation work with the popular promises library Q. I also discove...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/joeferner/node-java git https://github.com/joeferner/node-java.git
octolytics-dimension-user_id808857
octolytics-dimension-user_loginjoeferner
octolytics-dimension-repository_id3228734
octolytics-dimension-repository_nwojoeferner/node-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3228734
octolytics-dimension-repository_network_root_nwojoeferner/node-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb6f01f7cb9f35f8c09949773241a3d49dd04b340
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/joeferner/node-java/pull/189/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F189%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F189%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=joeferner%2Fnode-java
Reloadhttps://github.com/joeferner/node-java/pull/189/files
Reloadhttps://github.com/joeferner/node-java/pull/189/files
Reloadhttps://github.com/joeferner/node-java/pull/189/files
joefernerhttps://github.com/joeferner
node-javahttps://github.com/joeferner/node-java
Codehttps://github.com/joeferner/node-java
Issues208 (208)https://github.com/joeferner/node-java/issues
Pull requests2 (2)https://github.com/joeferner/node-java/pulls
Actionshttps://github.com/joeferner/node-java/actions
Projectshttps://github.com/joeferner/node-java/projects
Wikihttps://github.com/joeferner/node-java/wiki
Security and qualityhttps://github.com/joeferner/node-java/security
Insightshttps://github.com/joeferner/node-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
joefernerhttps://github.com/joeferner
joeferner:masterhttps://github.com/joeferner/node-java/tree/master
jimlloyd:feature/promises-clarifications.r1https://github.com/jimlloyd/node-java/tree/feature/promises-clarifications.r1
Conversation 0 https://github.com/joeferner/node-java/pull/189
Commits 1 https://github.com/joeferner/node-java/pull/189/commits
Checks 0 https://github.com/joeferner/node-java/pull/189/checks
Files changed https://github.com/joeferner/node-java/pull/189/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/189/files
Clarifications to Promises implementation (mostly documentation). https://github.com/joeferner/node-java/pull/189/files#top
Show all changes 1 commit https://github.com/joeferner/node-java/pull/189/files
94f1886 Clarifications to Promises implementation (mostly documentation). jimlloyd Jan 15, 2015 https://github.com/joeferner/node-java/pull/189/commits/94f18865937a04bf8c586993276f068f607c6a94
Clear filters https://github.com/joeferner/node-java/pull/189/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/189/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/189/files
README.md https://github.com/joeferner/node-java/pull/189/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
testHelpers.js https://github.com/joeferner/node-java/pull/189/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
README.mdhttps://github.com/joeferner/node-java/pull/189/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/jimlloyd/node-java/blob/94f18865937a04bf8c586993276f068f607c6a94/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/189/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/189/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
https://github.com/joeferner/node-java/pull/189/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
testHelpers.jshttps://github.com/joeferner/node-java/pull/189/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
View file https://github.com/jimlloyd/node-java/blob/94f18865937a04bf8c586993276f068f607c6a94/testHelpers.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/189/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/189/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.